<Swing Dev> [11] RFR JDK-8198777: JList.getPreferredScrollableViewportSize(): fix mistake in doc for height calc

Semyon Sadetsky semyon.sadetsky at oracle.com
Thu Mar 1 00:52:09 UTC 2018


Hello Alexey,

"height of the first cell" has relative meaning. I suggest to change it 
to "height of cell with index 0".

Also, it would be nice to specify the case when the model is empty.

--Semyon

On 02/28/2018 01:39 PM, Alexey Ivanov wrote:
> Hello,
>
> Could you please review the fix for jdk11?
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8198777
> webrev: http://cr.openjdk.java.net/~aivanov/8198777/webrev.0/
> csr: https://bugs.openjdk.java.net/browse/JDK-8198822
>
> It is a small fix to documentation of 
> JList.getPreferredScrollableViewportSize().
>
> If either fixedCellWidth or fixedCellHeight are not set and the model 
> isn't empty, heuristics are used. The height is based one the height 
> of the first cell rather than fixedCellHeight.
>
>
> Regards,
> Alexey




More information about the swing-dev mailing list