<Swing Dev> RFR JDK-8198922 Provide instrumentation for sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java

Fri Mar 2 19:41:00 UTC 2018

> On Mar 2, 2018, at 11:36 AM, Philip Race <philip.race at oracle.com> wrote:
> 
> Instead of checking this in, why not make the changes locally, don't commit,
> instead submit a test job to run sanity as many times as needed until you get
> the stack trace you need. That seems like a much faster way of getting what
> you need.

This test fails no more than 3 times in 1000 runs on a fast Mac host. I am not able to make it to fail locally. We already have machinery which is doing that repeated execution, so, on the contrary, committing this and observing the results there is much easier than to replicate that system locally.

Shura

> 
> -phil.
> 
> On 3/2/18, 11:19 AM, Alexandre (Shura) Iline wrote:
>> Hi,
>> 
>> Could you please take a look on this fix?
>> 
>> This fix adds some instrumentation to an existing test which is known to fail intermittently.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8198922
>> Webrev: http://cr.openjdk.java.net/~shurailine/8198922/webrev.00/
>> 
>> Thank you.
>> 
>> Shura