<Swing Dev> [11] RFR JDK-8194767:Regression automated Test 'javax/swing/JEditorPane/6917744/bug6917744.java' fails

Phil Race philip.race at oracle.com
Fri Mar 2 22:30:36 UTC 2018


looks ok.

-phil

On 03/02/2018 11:46 AM, semyon.sadetsky at oracle.com wrote:
> +1
>
> --Semyon
>
>
> On 3/2/18 9:55 AM, Prasanta Sadhukhan wrote:
>> Thanks Semyon for the review. Updated webrev: 
>> http://cr.openjdk.java.net/~psadhukhan/8194767/webrev.01/
>>
>> Regards
>> Prasanta
>> On 3/2/2018 10:40 PM, Semyon Sadetsky wrote:
>>> Hi Prasant,
>>>
>>>   72                 frame.setVisible(true);
>>>   73
>>>   74                 p = editorPane.getLocationOnScreen();
>>>
>>> It may not receive the right screen location that quick. You need to 
>>> wait when the frame is shown.
>>>
>>> Since this is a test bug please remove regression labels in JIRA.
>>>
>>> --Semyon
>>>
>>> On 03/02/2018 06:09 AM, Prasanta Sadhukhan wrote:
>>>> Hi All,
>>>>
>>>> Please review a test fix for an issue where the test fails citing 
>>>> "Invalid HTML position" because pressing PAGE_DOWN does not cause 
>>>> the document to scroll down to end of document.
>>>> This is because even though robot send PAGE_DOWN key events but the 
>>>> focus is not in the editorpane so it does not scroll.
>>>>
>>>> Proposed fix is to make sure the editorPane is in focus and caret 
>>>> is present in the document so that robot PAGE_DOWN events by robot 
>>>> causes it to scroll to end of document.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8194767
>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8194767/webrev.00/
>>>>
>>>> Regards
>>>> Prasanta
>>>
>>
>




More information about the swing-dev mailing list