<Swing Dev> [11][JDK-8197785]javax.accessibility.AccessibilityBundle will reload the ResourceBundle for every call to toDisplayString

[Sergey Bylokhov]

Hi, Krishna.
The .02 version of the fix have changed the behavior of 
toDisplayString() method. Before the fix it throws NPE for key=null, 
after the fix it returns null. I guess version .01 should be fine as it 
simple and supposed to fix one reported bug.

On 07/03/2018 08:19, Krishna Addepalli wrote:
> Thanks for the review Semyon!
> 
> -----Original Message-----
> From: Semyon Sadetsky
> Sent: Wednesday, March 7, 2018 9:27 PM
> To: Krishna Addepalli <krishna.addepalli at oracle.com>; Philip Race <philip.race at oracle.com>
> Cc: swing-dev at openjdk.java.net
> Subject: Re: <Swing Dev> [11][JDK-8197785]javax.accessibility.AccessibilityBundle will reload the ResourceBundle for every call to toDisplayString
> 
> +1
> 
> --Semyon
> 
> 
> On 3/7/18 5:28 AM, Krishna Addepalli wrote:
>> Hi Semyon,
>>
>> Modified the code as per your suggestions. Here is the new webrev:
>> http://cr.openjdk.java.net/~kaddepalli/8197785/webrev02
>>
>> Thanks,
>> Krishna
>>
>> -----Original Message-----
>> From: Semyon Sadetsky
>> Sent: Tuesday, March 6, 2018 11:46 PM
>> To: Phil Race <philip.race at oracle.com>; Krishna Addepalli
>> <krishna.addepalli at oracle.com>
>> Cc: swing-dev at openjdk.java.net
>> Subject: Re: <Swing Dev>
>> [11][JDK-8197785]javax.accessibility.AccessibilityBundle will reload
>> the ResourceBundle for every call to toDisplayString
>>
>> On 03/06/2018 10:01 AM, Phil Race wrote:
>>
>>>
>>> On 03/06/2018 09:45 AM, Semyon Sadetsky wrote:
>>>> Can you point to place where this Hashmap is updated other then
>>>> where it is initialized?
>>> You mean Hashtable ?
>> Right, sorry.
>>>    161                 table.put(locale, resourceTable);
>>>
>>> Will be executed once per locale.
>> It updates "table" not "resourceTable". The "table" field could be treated differently since writing in it really very rare but it is ok to leave it as it is. All what I meant concerned only the "resourceTable".
>>
>> --Semyon
>>> -phil.
>>>
> 


-- 
Best regards, Sergey.