<Swing Dev> [11][JDK-8197785]javax.accessibility.AccessibilityBundle will reload the ResourceBundle for every call to toDisplayString

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Mar 7 18:40:24 UTC 2018


On 07/03/2018 10:21, semyon.sadetsky at oracle.com wrote:
>> That's not ok, since we change a behavior without discussion that the 
>> benefits of change outweigh the disadvantages, when we implemented 
>> some unrelated fix.
> That's not true. You may find the discussion in the current thread. Fill 
> free to provide your arguments to it.

I found nothing related to the behavior, only some conclusion about 
possible performance difference.

>>> It is an improvement. NPE is not expected result according to the 
>>> toDisplayString() method spec.
>>
>> It also changed result of toDisplayString(), previously it did not 
>> returned null. I think .01 is better and simpler.
>>
> Returning null is better than throwing NPE especially in the case when 
> NPE doesn't correspond to the spec. Krishna kindly agreed to fix both 
> issues at once. I didn't get what is the problem?

Nope, if the method start to return null means that all its usage should 
be checked for null return value. As I said it is better to use version 
.01 which fixed the problem w/o side effects.

-- 
Best regards, Sergey.



More information about the swing-dev mailing list