<Swing Dev> [11] [JDK-8074286] : Add getSelectedIndices() to ListSelectionModel
Prasanta Sadhukhan
prasanta.sadhukhan at oracle.com
Tue Mar 13 08:10:18 UTC 2018
Hi Pankaj,
Looks good to me, only thing I have some reservations is
JList.getSelectedValues is deprecated since jdk7, so in my opinion, we
should not modify it. Please add noreg-cleanup label to JBS.
Regards
Prasanta
On 3/9/2018 6:47 AM, Sergey Bylokhov wrote:
> Hi, Pankaj.
> The fix looks fine, please add @since tag for the new methods in CSR.
>
> On 02/02/2018 09:06, Pankaj Bansal wrote:
>> Hi All,
>>
>> Please review a fix for the Enhancement. I will raise a CSR after
>> technical evaluation.
>>
>> Enhancement:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8074286
>>
>> Webrev:
>>
>> http://cr.openjdk.java.net/~pbansal/8074286/webrev.00/
>>
>> The enhancement requests to add getSelectedIndices function to
>> ListSelectionModel Interface as same function with duplicate
>> implementation is being used in JList, JTable and
>> DefaultTableColumnModel.
>>
>> I have also added the getSelectedItemsCount function in
>> ListSelectionModel, as this is also being used at multiple places
>> with same implementation.
>>
>> JList.getSelectedValues and JList.getSelectedValuesList are also
>> modified to use getSelectionIndices instead of replicating the same
>> code.
>>
>> Regards,
>>
>> Pankaj Bansal
>>
>
>
More information about the swing-dev
mailing list