<Swing Dev> RFR 8186549: move ExtendedRobot closer to tests

[Philip Race]

I don't understand why the relative path is used  in some two cases and
an absolute path in others. OK you didn't change that but does it make
sense to standardise on what I hope is the absolute path which is easier
to get right and will withstand the tests being moved ?
Can we do the same for "helpers" ?

-phil.

test/jdk/java/awt/Modal/ModalExclusionTests/ApplicationExcludeDialogFileTest.java

@@ -29,11 +29,11 @@
   * @bug 8047179 8044429
   * @summary Check whether a FileDialog blocks an application modality 
excluded Dialog
   *          (it shouldn't). Checks also whether setting a parent 
dialog to be
   *          modality excluded excludes its children from being blocked 
too.
   *
- * @library ../helpers /lib/testlibrary/
+ * @library ../helpers /lib/client/
   * @library /test/lib
   * @build ExtendedRobot
   * @build Flag
   * @build TestDialog
   * @build TestWindow

test/jdk/java/awt/Modal/ModalDialogOrderingTest/ModalDialogOrderingTest.java

@@ -33,11 +33,11 @@
   * @test
   * @key headful
   * @bug 8008728
   * @summary [macosx] Swing. JDialog. Modal dialog goes to background
   * @author Alexandr Scherbatiy
- * @library ../../../../lib/testlibrary
+ * @library ../../../../lib/client
   * @build ExtendedRobot
   * @run main ModalDialogOrderingTest
   */
  public class ModalDialogOrderingTest {


-phil.

On 11/6/18, 5:21 PM, Alexandre (Shura) Iline wrote:
> Ping.
>
>> On Oct 29, 2018, at 3:02 PM, Alexandre (Shura) Iline<alexandre.iline at oracle.com>  wrote:
>>
>> Hi.
>>
>> Please take a look on this fix for JDK-8186549.
>>
>> For testing I have selected tests and groups of tests which use the ExtendedRobot class. The tests show the same pass rate. There are still few tests which use lib/testlibrary, they are not affected by this fix.
>>
>> Task: https://bugs.openjdk.java.net/browse/JDK-8186549
>> Webrev: http://cr.openjdk.java.net/~shurailine/8186549/webrev.00
>> Tests used for testing the fix: http://cr.openjdk.java.net/~shurailine/8186549/extended_robot_tests
>>
>> Shura
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20181106/3811dbad/attachment.html>