<Swing Dev> [12] RFR JDK-8213181:Updation of ProblemList.txt for removal of passing swing test
Prasanta Sadhukhan
prasanta.sadhukhan at oracle.com
Thu Nov 8 07:34:07 UTC 2018
On 08-Nov-18 11:59 AM, Prasanta Sadhukhan wrote:
>
>
> On 08-Nov-18 11:52 AM, Sergey Bylokhov wrote:
>> On 07/11/2018 21:44, Prasanta Sadhukhan wrote:
>>> I found that these tests are passing when ran for 100 iterations on
>>> windows
>>> javax/swing/plaf/basic/Test6984643.java
>>
>> It is necessary to check the code of the tests as well, for example
>> the test above was reported in JDK-8198340.
>> The reason is that we have a race between shiudown of the app(caused
>> by the jtreg) and initialization
>> of the test on EDT because the test uses invokeLater(), so the main()
>> method is ended before the end of invokeLater().
>>
>> And it looks like a product bug in Win32ShellFolderManager2 which
>> should not throw IllegalStateException.
>>
>> Others tests should be checked is a similar way.
>>
>> BTW if the test is not marked as @headful it is necessary to check
>> its stability in the headless environment as well.
>>
>>
> I guess these 2 tests which I have added in last sprint because they
> fail in local machine (and not in mach5)
> javax/swing/JButton/8151303/PressedIconTest.java
> javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java
>
> are marked as headful and passing for 100 iterations, so I guess at
> least we should remove these 2 tests for this bugid as it does not
> need to be tested in mac5.
>
> Rest I will look at later point as you told it might be some
> instability that might cause it.
>
javax/swing/JComboBox/6607130/bug6607130.java
- Could not find anything wrong with test. Sometimes, if mouse is moved
while test is running, then we can get the same problem as mentioned in
the bug JDK-8196091 and this is headful so no need to test on mach5.
Can we remove this from problemlist?
javax/swing/JPopupMenu/6675802/bug6675802.java
- Could not find anything wrong with test. No exception is found in
windows7 and windows10 (as mentioned in bugreport JDK-8196097) and test
passed. It was failing locally and now passing in our windows7,10.
Not marked as headful so willl not remove from problemlist
javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java
- as per JDK-8196098, failing with wrong jtextfield height. But it
passed for us in windows7,10. probably some font issue that might have
existed in Phil's machine. Marked as headful so no issue with mach5.
Can we remove this from problemlist?
javax/swing/plaf/basic/Test6984643.java
- As stated above. will not remove from problemlist
javax/swing/text/JTextComponent/5074573/bug5074573.java
sun.awt.SunToolkit$InfiniteLoop
at java.desktop/sun.awt.SunToolkit.realSync(SunToolkit.java:1474)
at java.desktop/sun.awt.SunToolkit.realSync(SunToolkit.java:1402)
at java.desktop/java.awt.Robot.waitForIdle(Robot.java:692)
where realSync() in Robot.java was added as per JDK-8076178
<https://bugs.openjdk.java.net/browse/JDK-8076178>
Although it pass for 100 iterations, I will not remove this from
Problemlist as not sure why it failed last time as the realsync call is
still present in same location in Robot.java
javax/swing/SwingWorker/6493680/bug6493680.java
- mach5 instablity. will not remove from problem list
javax/swing/UIDefaults/8149879/InternalResourceBundle.java
- mach5 instablity. will not remove from problem list
javax/swing/PopupFactory/8048506/bug8048506.java
- test fails to dispose frame and hides popup. although it has worked
for 100 iterations, it might cause some issue sometime due to
non-disposal. will not remove from problemlist.
In light of above comments, I think we can safely remove these below 4
tests from problemlist
javax/swing/JButton/8151303/PressedIconTest.java
javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java
javax/swing/JComboBox/6607130/bug6607130.java
javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java
Regards
Prasanta
> Regards
> Prasanta
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20181108/a677f39a/attachment.html>
More information about the swing-dev
mailing list