<Swing Dev> RFR 8186549: move ExtendedRobot closer to tests

[Alexandre (Shura) Iline]

That aside, Phil, Sergey, I would really like your opinion on test selection. Did I run the right tests to verify the fix?

Shura

> On Nov 7, 2018, at 3:05 PM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> wrote:
> 
> Phil, Igor,
> 
> A quick check shows that indeed most of cases where a “lib” library used by relative path (which may or may not be the top level library) are in the client tests.
> 
> $ egrep -r '@library.* (../)+lib' --include "*.java" . | cut -d ':' -f 1 | cut -d / -f 2-3 | uniq -c
>      59 java/awt
>       1 tools/jimage
>      15 tools/jlink
>      43 com/sun
>      39 javax/swing
> 
> $ egrep -r '@library.* (../)+lib' --include "*.java" com/sun | cut -d ':' -f 1 | cut -d / -f 2-3 | uniq -c
>      43 sun/jndi
> 
> Further, almost all of such cases, in client tests, is included into my last fix:
> 
> $ egrep -r '@library.* (../)+lib/client' --include "*.java" . | cut -d ':' -f 1 | cut -d / -f 2-3 | uniq -c
>      56 java/awt
>      39 javax/swing
> 
> The is to say, I will update the webrev with using absolute path to lib/client.
> 
> Shura
> 
> 
>> On Nov 6, 2018, at 5:30 PM, Philip Race <philip.race at oracle.com <mailto:philip.race at oracle.com>> wrote:
>> 
>> I don't understand why the relative path is used  in some two cases and
>> an absolute path in others. OK you didn't change that but does it make
>> sense to standardise on what I hope is the absolute path which is easier
>> to get right and will withstand the tests being moved ? 
>> Can we do the same for "helpers" ?
>> 
>> -phil.
>> 
>> test/jdk/java/awt/Modal/ModalExclusionTests/ApplicationExcludeDialogFileTest.java
>> 
>> @@ -29,11 +29,11 @@
>>   * @bug 8047179 8044429
>>   * @summary Check whether a FileDialog blocks an application modality excluded Dialog
>>   *          (it shouldn't). Checks also whether setting a parent dialog to be
>>   *          modality excluded excludes its children from being blocked too.
>>   *
>> - * @library ../helpers /lib/testlibrary/
>> + * @library ../helpers /lib/client/
>>   * @library /test/lib
>>   * @build ExtendedRobot
>>   * @build Flag
>>   * @build TestDialog
>>   * @build TestWindow
>> 
>> test/jdk/java/awt/Modal/ModalDialogOrderingTest/ModalDialogOrderingTest.java
>> 
>> @@ -33,11 +33,11 @@
>>   * @test
>>   * @key headful
>>   * @bug 8008728
>>   * @summary [macosx] Swing. JDialog. Modal dialog goes to background
>>   * @author Alexandr Scherbatiy
>> - * @library ../../../../lib/testlibrary
>> + * @library ../../../../lib/client
>>   * @build ExtendedRobot
>>   * @run main ModalDialogOrderingTest
>>   */
>>  public class ModalDialogOrderingTest {
>>  
>> 
>> -phil.
>> 
>> On 11/6/18, 5:21 PM, Alexandre (Shura) Iline wrote:
>>> 
>>> Ping.
>>> 
>>>> On Oct 29, 2018, at 3:02 PM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> <mailto:alexandre.iline at oracle.com> wrote:
>>>> 
>>>> Hi.
>>>> 
>>>> Please take a look on this fix for JDK-8186549.
>>>> 
>>>> For testing I have selected tests and groups of tests which use the ExtendedRobot class. The tests show the same pass rate. There are still few tests which use lib/testlibrary, they are not affected by this fix.
>>>> 
>>>> Task: https://bugs.openjdk.java.net/browse/JDK-8186549 <https://bugs.openjdk.java.net/browse/JDK-8186549>
>>>> Webrev: http://cr.openjdk.java.net/~shurailine/8186549/webrev.00 <http://cr.openjdk.java.net/~shurailine/8186549/webrev.00>
>>>> Tests used for testing the fix: http://cr.openjdk.java.net/~shurailine/8186549/extended_robot_tests <http://cr.openjdk.java.net/~shurailine/8186549/extended_robot_tests>
>>>> 
>>>> Shura
>>>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20181108/8dd62af7/attachment.html>