<Swing Dev> [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732

[Prasanta Sadhukhan]

On 26-Nov-18 6:51 PM, shashidhara.veerabhadraiah at oracle.com wrote:
>
> Hi Prasanta, I think we should not create a behavior across the 
> functions. doCompare() does only the comparison and it may be used for 
> other purposes and is complete with respect to the comparison 
> functionality.
>
> run() function has a different behavior as it needs to populate the 
> prevRemotePrinters and then the currentRemotePrinters and then use the 
> comparison functionality. I think this is a good way to do.
>
Even without the if-else check, it does populates the 
prevRemotePrinters, no?
if "prevRemotePrinters" is null and currentRemotePrinters is null, then 
no need to update. If currentRemotePrinters is null, then what is the 
point of using getRemotePrintersNames() to update prevRemotePrinters as 
currentRemotePrinters is also obtained from getRemotePrintersNames!!
If "prevRemotePrinters" is null and currentRemotePrinters is not null, 
then doCompare() called from run() will be true and prevRemotePrinters 
will be populated with currentRemotePrinters.
If "prevRemotePrinters" is not null and currentRemotePrinters is null, 
then also prevRemotePrinters will be populated with currentRemotePrinters.

Regards
Prasanta
>
> Thanks and regards,
>
> Shashi
>
>
> On 26/11/18 6:03 PM, Prasanta Sadhukhan wrote:
>>
>> Hi Shashi,
>>
>> I think l437 check of if-else if (prevRemotePrinters != null) {is not 
>> required. prevRemotePrinters null check is addressed in str1==null 
>> case in doCompare().
>> If prevRemotePrinters is null and currentRemotePrinters is not null, 
>> then you update prevRemotePrinters to currentRemotePrinters as per 
>> l415 where doCompare returns true.
>> Also, If prevRemotePrinters is not null and currentRemotePrinters is 
>> null, then also you update prevRemotePrinters to 
>> currentRemotePrinters which is the output of getRemotePrintersNames().
>>
>> Regards
>> Prasanta
>> On 26-Nov-18 2:33 PM, Shashidhara Veerabhadraiah wrote:
>>>
>>> Hi All, Please review a NPE fix for the below bug.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8212202
>>>
>>> Webrev: http://cr.openjdk.java.net/~sveerabhadra/8212202/webrev.00/ 
>>> <http://cr.openjdk.java.net/%7Esveerabhadra/8212202/webrev.00/>
>>>
>>> Function getRemotePrintersNames() may return null values and hence 
>>> they need to be handled from the caller of that function which was 
>>> missing earlier. This fix handles the null return values of the said 
>>> function.
>>>
>>> Thanks and regards,
>>>
>>> Shashi
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20181126/c64a4e1c/attachment-0001.html>