<Swing Dev> [12]RFR: JDK-7124301: [macosx] When in a tab group if you arrow between tabs there are no VoiceOver announcements.

Krishna Addepalli krishna.addepalli at oracle.com
Tue Nov 27 01:59:30 UTC 2018


Hi Sergey,

I thought that whenever the title of a component changes, it is important for VO to announce it, and hence did not put in any checks. 
Let me know if this shouldn’t be, and I can put a check,

Thanks,
Krishna

> On 27-Nov-2018, at 1:42 AM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> Hi, Krishna.
> The "ACCESSIBLE_NAME_PROPERTY" is also used in JTable/JFileChooser etc,
> are you sure that we need to call the "titleChanged(ptr)" for all of them?
> 
> On 22/11/2018 21:04, shashidhara.veerabhadraiah at oracle.com wrote:
>> Hi Krishna, The changes looks fine to me.
>> Thanks and regards,
>> Shashi
>> On 19/11/18 3:28 PM, Krishna Addepalli wrote:
>>> 
>>> Hi All,
>>> 
>>> Please review a fix for
>>> 
>>> JDK-7124301: https://bugs.openjdk.java.net/browse/JDK-7124301
>>> 
>>> Webrev: http://cr.openjdk.java.net/~kaddepalli/7124301/webrev00/ <http://cr.openjdk.java.net/%7Ekaddepalli/7124301/webrev00/>
>>> 
>>> The problem is that, there was no implementation for notifying the VO regarding the change in the title of the component, which is why, when the tab group was changed, there were no VO announcements.
>>> 
>>> This fix provides that implementation, and now VO announces the title of the tab.
>>> 
>>> Thanks,
>>> 
>>> Krishna
>>> 
> 
> 
> -- 
> Best regards, Sergey.



More information about the swing-dev mailing list