<Swing Dev> [11] RFR [JDK-8211160] Handle different look and feels in JInternalFrameOperator

[Sergey Bylokhov]

Looks fine, I assume that the fix is for jdk12 not jdk11.

On 01/10/2018 01:28, Muneer Kolarkunnu wrote:
> Gentle Reminder.
> 
> Regards,
> 
> Muneer
> 
> *From:* Muneer Kolarkunnu
> *Sent:* Thursday, September 27, 2018 6:37 AM
> *To:* swing-dev at openjdk.java.net
> *Cc:* Aleksandre Iline <alexandre.iline at oracle.com>
> *Subject:* <Swing Dev> [11] RFR [JDK-8211160] Handle different look and 
> feels in JInternalFrameOperator
> 
> Hi All,
> 
> Please review fix for a bug in jemmy:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8211160
> 
> Webrev: http://cr.openjdk.java.net/~akolarkunnu/8211160/webrev.00/ 
> <http://cr.openjdk.java.net/%7Eakolarkunnu/8211160/webrev.00/>
> 
> This fix is a copy of fix made in the Jemmy code-tools repository.
> 
> http://hg.openjdk.java.net/code-tools/jemmy/v2/rev/00c9f753cd0a
> 
> Description:
> 
> There are multiple issues in JInternalFrameOperator w.r.t multiple L&F.
> 
> In Motif L&F:
> 
> JInternalFrame doesn't has tooltip text for minimize and maximize buttons.
> 
> It doesn't have the close button.
> 
> Reference: com.sun.java.swing.plaf.motif.MotifInternalFrameTitlePane
> 
> So these different actions implemented using motif system menus: 
> InternalFramePopupMenuDriver.java.
> 
> In Nimbus, Motif and Windows Classic L&F:
> 
> We have to press two times on desktop icon to restore it to previous state.
> 
> GTK L&F:
> 
> There is a deadlock issue - Changes in API 
> org.netbeans.jemmy.operators.JInternalFrameOperator.JDesktopIconOperator.getInternalFrame() 
> s to handle this issue.
> 
> There is a ClassCastException while invoking some constructors - Changes 
> in two constructors to handle this issue.
> 
> Regards,
> 
> Muneer
> 


-- 
Best regards, Sergey.