<Swing Dev> [12] RFR JDK-8203281:[Windows] JComboBox change in ui when editor.setBorder() is called

Prasanta Sadhukhan prasanta.sadhukhan at oracle.com
Tue Oct 2 07:35:53 UTC 2018


Thanks Martin. I can sponsor the webrev as uploaded here

http://cr.openjdk.java.net/~psadhukhan/8203281/webrev.1/

BTW, which windows platforms you tested this fix?
As I tested on windows10, the left one is before the fix and right one 
is after.


looks good to me.

Regards
Prasanta
On 02-Oct-18 1:02 AM, Martin M wrote:
> Hi Prasanta,
>
> This time I am sending you correction in diff format, because 
> webrev.zip with .js file inside is blocked by gmail filters.
> I removed .js last time manually from webrev, but it should not be 
> done this way I think.
>
> Please let me know if webrev.zip without .js is ok for you, because 
> that`s all I can do.
> A year ago my sponsor uploaded webrev for me, cause I have no rights 
> to do it.
>
> best regards,
> Martin
>
> po 1. 10. 2018 o 12:10 Prasanta Sadhukhan 
> <prasanta.sadhukhan at oracle.com <mailto:prasanta.sadhukhan at oracle.com>> 
> napísal(a):
>
>     BTW, I saw that you have
>
>     379 , arrowButton.getPrefrredSize().widthwhich will cause build
>     failure. Did you actually build this code and test? Regards Prasanta
>     On 01-Oct-18 11:24 AM, Prasanta Sadhukhan wrote:
>>
>>     Thanks Martin. Can you please send the webrev in proper format
>>     like you did for 6490753 as in below?
>>
>>     http://cr.openjdk.java.net/~alexsch/mraz.martin/6490753/webrev.00/
>>     <http://cr.openjdk.java.net/%7Ealexsch/mraz.martin/6490753/webrev.00/>
>>
>>     Regards
>>     Prasanta
>>     On 29-Sep-18 1:53 AM, Martin M wrote:
>>>     Hi Prasanta,
>>>
>>>     As I understand, your solution sets default XPFillBorder to
>>>     combobox in newer versions of windows except vista.
>>>     But then animated native border is not visible in win7 or win10.
>>>     I propose to add EmptyBorder 1px thick to see native border and
>>>     calculate new size and position of arrow button.
>>>
>>>     please see my attached webrev
>>>
>>>     br,
>>>     Martin
>>>
>>>     pi 28. 9. 2018 o 6:27 Prasanta Sadhukhan
>>>     <prasanta.sadhukhan at oracle.com
>>>     <mailto:prasanta.sadhukhan at oracle.com>> napísal(a):
>>>
>>>         Hi Martin,
>>>
>>>
>>>         On 08-Sep-18 3:06 PM, Martin M wrote:
>>>>         Hi Prasanta,
>>>>
>>>>         As far as I know, there are only 2 options in swing on
>>>>         windows. WindowsLookAndFeel (includes XP theme, aero for
>>>>         Vista, Win7, Win10...) and WindowsClassicLookAndFeel
>>>>         (includes classic theme for win95, win98).
>>>>         The fix was done for WindowsLookAndFeel, so it affects not
>>>>         only Vista version but also win7 aero and win10.
>>>>
>>>>         I think that EmptyBorder(0,0,0,0) should be replaced by
>>>>         EmptyBorder(1,1,1,1) to see animated native border and
>>>>         therefore BasicComboboxEditor will not be placed over
>>>>         native border. But then arrowbutton will be placed on wrong
>>>>         coordinates and also its size will not be ok.
>>>>         I will create webrev with needed changes.
>>>>
>>>         ok, but what is the problem with my webrev? The oldest
>>>         supported platform for jdk12, which is what my fix is
>>>         targeted to, is windows 7 and the fix seems to work for
>>>         windows 7 and windows10 as far I have tested.
>>>         If you see any problem with my webrev, please let me know
>>>         or if you are ok, then please approve it
>>>         or if you still insist on sending your webrev, then please
>>>         send it soon as we are already 2 months since my webrev is
>>>         out for review.
>>>
>>>         Regards
>>>         Prasanta
>>>>         br,
>>>>         Martin
>>>>
>>>>         št 6. 9. 2018 o 19:34 Prasanta Sadhukhan
>>>>         <prasanta.sadhukhan at oracle.com
>>>>         <mailto:prasanta.sadhukhan at oracle.com>> napísal(a):
>>>>
>>>>             Ping? It's been a month.
>>>>
>>>>             Even if JDK-6490753 fix is not only for Vista, but a
>>>>             portion of it
>>>>             [where I propose a fix] is causing issue in windows7,
>>>>             10, so it is
>>>>             modified to make sure it works correctly in
>>>>             windows7-10. It will also
>>>>             not affect windows vista.
>>>>             Please provide comments on this.
>>>>
>>>>             Regards
>>>>             Prasanta
>>>>             On 8/9/2018 3:09 PM, Prasanta Sadhukhan wrote:
>>>>             > Gentle reminder.
>>>>             >
>>>>             > I guess it's for vista as the bug description states
>>>>             it's for
>>>>             >
>>>>             > Vista Info:
>>>>             > ===========
>>>>             > Vista Build No: 5840
>>>>             > Vista Theme: Default Theme(Aero)
>>>>             >
>>>>             > Regards
>>>>             > Prasanta
>>>>             > On 8/2/2018 12:27 AM, Sergey Bylokhov wrote:
>>>>             >> Hi, Prasanta.
>>>>             >> I am not sure that previous fix[JDK-6490753] was
>>>>             implemented for
>>>>             >> Vista only.
>>>>             >> Maybe Martin (CC) can take a look to this?
>>>>             >>
>>>>             >> On 01/08/2018 10:11, Prasanta Sadhukhan wrote:
>>>>             >>> Hi All,
>>>>             >>>
>>>>             >>> Please review a fix for an issue where it is seen
>>>>             that combobox gets
>>>>             >>> an unwanted border around it.
>>>>             >>> This is a aftereffect of JDK-6490753
>>>>             >>> <https://bugs.openjdk.java.net/browse/JDK-6490753>
>>>>             where am empty
>>>>             >>> border is added to combobox to make it look like
>>>>             Vista native combobox.
>>>>             >>> Proposed fix is to make sure no empty border is
>>>>             drawn if windows
>>>>             >>> version is not vista.
>>>>             >>> Here's the combobox looks like before and after fix
>>>>             in windows 10
>>>>             >>> and 7.
>>>>             >>>
>>>>             >>> Before fix
>>>>             >>>
>>>>             >>> After Fix
>>>>             >>>
>>>>             >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8203281
>>>>             >>> webrev:
>>>>             http://cr.openjdk.java.net/~psadhukhan/8203281/webrev.0/
>>>>             <http://cr.openjdk.java.net/%7Epsadhukhan/8203281/webrev.0/>
>>>>             >>>
>>>>             >>> Regards
>>>>             >>> Prasanta
>>>>             >>
>>>>             >>
>>>>             >
>>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20181002/a511da4f/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcapoonemjhoigcb.png
Type: image/png
Size: 2886 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20181002/a511da4f/gcapoonemjhoigcb-0001.png>


More information about the swing-dev mailing list