<Swing Dev> [12] RFR JDK-8213116:javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java fails in Windows

Prasanta Sadhukhan prasanta.sadhukhan at oracle.com
Wed Oct 31 18:40:37 UTC 2018


Hi All,

Please review a fix for an issue where it is seen that this test 
javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
fails because combobox height is more than textfield height on which the 
combobox is placed.

This is a regression ofJDK-8203281: 
<https://bugs.openjdk.java.net/browse/JDK-8203281>[Windows] JComboBox 
change in ui when editor.setBorder() is called where combobox arrow 
button height is reduced by 2
[http://hg.openjdk.java.net/jdk/client/file/20e47d686221/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsComboBoxUI.java#l381]
but the minimum size of combobox is set to old values which was added 
during<https://bugs.openjdk.java.net/browse/JDK-8179027>
JDK-8179027: <https://bugs.openjdk.java.net/browse/JDK-8179027>JComboBox 
too small under Windows LAF
which was done to address regression caused by
JDK-6490753: <https://bugs.openjdk.java.net/browse/JDK-6490753> 
Vista:JComboBox doesn't looks as native combobox in different states of 
component.

Now, JDK-8203281 <https://bugs.openjdk.java.net/browse/JDK-8203281> was 
also a regression caused by JDK-6490753 
<https://bugs.openjdk.java.net/browse/JDK-6490753> so the combobox size 
needs to be altered in the fix done for JDK-8179027 
<https://bugs.openjdk.java.net/browse/JDK-8179027> to make sure the 
values are compatible.

Bug: https://bugs.openjdk.java.net/browse/JDK-8213116
webrev: http://cr.openjdk.java.net/~psadhukhan/8213116/webrev.0/

Regards
Prasanta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20181101/7c3ebbdd/attachment-0001.html>


More information about the swing-dev mailing list