<Swing Dev> <AWT Dev> [8u-backport] JDK 8145547: [AWT/Swing] Conditional support for GTK 3 on Linux

[Kevin Rushforth]

The backport of the following fix, which removes sun.misc.GThreadHelper, 
will break all FX interop applications, even if GTK2 is used:

https://bugs.openjdk.java.net/browse/JDK-8154546 : Retire 
sun.misc.GThreadHelper

The FX GTK port still uses that class, so the class needs to be left in 
until after the FX support for GTK 3 has been backported.

-- Kevin



On 9/5/2018 12:56 AM, Pankaj Bansal wrote:
>
> Hi All,
>
> Please review the patch for 8u-dev backport for JDK-8145547. It adds 
> conditional support for gtk3.
>
> The original fix does not apply cleanly as few changes were done  in 
> jdk9 before the gtk3 support was added, major once being JDK-8025815 
> <https://bugs.openjdk.java.net/browse/JDK-8025815>, JDK-8014212 
> <https://bugs.openjdk.java.net/browse/JDK-8014212> and JDK-8137571 
> <https://bugs.openjdk.java.net/browse/JDK-8137571>
>
> Along with the enhancement, following bug fixes have also been 
> included in the backport webrev
>
> 1.https://bugs.openjdk.java.net/browse/JDK-8155772: gtk3_interface.c 
> compilation error on Ubuntu 12.10
>
> 2.https://bugs.openjdk.java.net/browse/JDK-8156020: 8145547 breaks AIX 
> and and uses RTLD_NOLOAD incorrectly
>
> 3.https://bugs.openjdk.java.net/browse/JDK-8156121: Fail forward" 
> fails for GTK3 if no GTK2 available
>
> 4.https://bugs.openjdk.java.net/browse/JDK-8156128: Tests for 
> [AWT/Swing] Conditional support for GTK 3 on Linux
>
> 5.https://bugs.openjdk.java.net/browse/JDK-8157827: 
> AWT_Desktop/Automated/Exceptions/BasicTest loads incorrect GTK version 
> when jdk.gtk.version=3
>
> 6.https://bugs.openjdk.java.net/browse/JDK-8160160: The menu displayed 
> nothing with the option"-server -d64 -Xmixed 
> -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel".
>
> 7.https://bugs.openjdk.java.net/browse/JDK-8191041: Questionable 
> Rendering of Disabled Text in Swing GTK L&F
>
> 8.https://bugs.openjdk.java.net/browse/JDK-8203003: Several FileDialog 
> Modality Tests fail on Linux due to X errors
>
> 9.https://bugs.openjdk.java.net/browse/JDK-8155784: Build failure on 
> Linux arm64
>
> 10.https://bugs.openjdk.java.net/browse/JDK-8154546: Retire 
> sun.misc.GThreadHelper
>
> 11.https://bugs.openjdk.java.net/browse/JDK-8152968: JTree Collapse 
> Buttons Clipped Off Under GTK
>
> 12.https://bugs.openjdk.java.net/browse/JDK-8160448: Make GTK3 menus 
> appearence similar to native.
>
> 13.https://bugs.openjdk.java.net/browse/JDK-8155613: [PIT] crash in 
> AWT_Desktop/Automated/Exceptions/BasicTest
>
> 14.https://bugs.openjdk.java.net/browse/JDK-8160054: The FileChooser 
> didn't displayed large font with GTK LAF option.
>
> 15.https://bugs.openjdk.java.net/browse/JDK-8164321: Crash of 
> SwingNode with GTK LaF
>
> 16.https://bugs.openjdk.java.net/browse/JDK-8161740: [parfait] Memory 
> leak in Java_sun_awt_UNIXToolkit_load_1gtk_1icon of awt_UNIXToolkit.c:132
>
> 17.https://bugs.openjdk.java.net/browse/JDK-8168077: Solaris build 
> failed: gtk2_interface.h typedef redeclared: GThreadFunctions
>
> webrev: http://cr.openjdk.java.net/~pbansal/gtk3_backport/webrev.00/ 
> <http://cr.openjdk.java.net/%7Epbansal/gtk3_backport/webrev.00/>
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8145547
>
> JDK 9 Changeset: 
> http://hg.openjdk.java.net/jdk9/client/jdk/rev/6d60dfa5e3f8
>
> I have run the related jtreg and jck tests and results are fine.
>
> Regards,
>
> Pankaj
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20180905/f5728e11/attachment.html>