<Swing Dev> [12] RFR [TEST][JDK-8210055] Enable different look and feel tests in SwingSet3 demo tests

[Sergey Bylokhov]

Looks fine.

On 24/09/2018 02:13, Muneer Kolarkunnu wrote:
> Gentle Reminder.
> 
> Regards,
> 
> Muneer
> 
> *From:* Muneer Kolarkunnu
> *Sent:* Tuesday, September 18, 2018 3:08 PM
> *To:* Sergey Bylokhov <sergey.bylokhov at oracle.com>; 
> swing-dev at openjdk.java.net
> *Cc:* Aleksandre Iline <alexandre.iline at oracle.com>
> *Subject:* Re: <Swing Dev> [12] RFR [TEST][JDK-8210055] Enable different 
> look and feel tests in SwingSet3 demo tests
> 
> Hi Sergey,
> 
> Hi Sergey,
> 
> Thanks for feedback.
> 
> *Before applying the patch:* That is the expected behavior.
> 
> In SwingSet2 demo, we have a checkbox menu item to enable/disable tool 
> tips.(Options->Enable Tool Tips).
> 
> I used this feature to test the swing component JCheckBoxMenuItem.
> 
> So after disabling tooltip, it keeps mouse pointer on thumbnail and make 
> sure it doesn’t show tooltip. It will wait for a minute(jemmy default 
> timeout duration).
> 
> *After applying the patch:*
> 
> Default timeout for a jtreg test is 120 seconds, obviously it will take 
> more time than this default timeout to complete test on four or five 
> look and feels.
> 
> In my local and SBR tests, I was giving timeoutFactor as 8 on jtreg 
> command. That’s why I didn’t see this timeout issue.
> 
> So I updated the test run command with timeout=600 seconds [5(max number 
> of L&Fs)*120].
> 
> New webrev: http://cr.openjdk.java.net/~akolarkunnu/8210055/webrev.01/ 
> <http://cr.openjdk.java.net/%7Eakolarkunnu/8210055/webrev.01/>
> 
> Regards,
> 
> Muneer
> 
> -----Original Message-----
> From: Sergey Bylokhov
> Sent: Tuesday, September 18, 2018 3:12 AM
> To: Muneer Kolarkunnu <abdul.kolarkunnu at oracle.com 
> <mailto:abdul.kolarkunnu at oracle.com>>; swing-dev at openjdk.java.net 
> <mailto:swing-dev at openjdk.java.net>
> Cc: Aleksandre Iline <alexandre.iline at oracle.com 
> <mailto:alexandre.iline at oracle.com>>
> Subject: Re: <Swing Dev> [12] RFR [TEST][JDK-8210055] Enable different 
> look and feel tests in SwingSet3 demo tests
> 
> Hi, Muneer.
> 
> Can you please take a look to this test:
> 
> open/test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java
> 
> On macOS before the fix, this test shown the frame for long period of 
> time without any actions and then completes w/o errors. After the fix it 
> fails because of timeout.
> 
> On 16/09/2018 22:46, Muneer Kolarkunnu wrote:
> 
>  > Hi All,
> 
>  >
> 
>  > Please review the fix to add support for testing for all the available
> 
>  > look and feels for the DialogDemoTest,WindowDemoTest and 
> SwingSet2DemoTest.
> 
>  >
> 
>  > Task: https://bugs.openjdk.java.net/browse/JDK-8210055
> 
>  >
> 
>  > Webrev Link:http://cr.openjdk.java.net/~akolarkunnu/8210055/webrev.00/
> 
>  > <http://cr.openjdk.java.net/%7Eakolarkunnu/8210055/webrev.00/>
> 
>  >
> 
>  > Summary: We use “availableLookAndFeels” dataProvider from TestHelpers
> 
>  > class  to run the test iteratively using all the available look and 
> feels.
> 
>  >
> 
>  > But there were some issues while running these tests directly on
> 
>  > different look and feels.
> 
>  >
> 
>  > Issues:
> 
>  >
> 
>  > SwingSet2DemoTest: In SwingSet 2 application, it was creating some
> 
>  > menus only once, because of that removed check in the review. For
> 
>  > different look and feel tests it will be loading application multiple
> 
>  > times, but some menus were not getting created.
> 
>  > DialogDemoTest and WindowDemoTest: Added isShown() check to get exact
> 
>  > active Window for each look and feel test.
> 
>  >
> 
>  > Please see the bug description for the exception stack traces.
> 
>  >
> 
>  > Regards,
> 
>  >
> 
>  > Muneer
> 
>  >
> 
> --
> 
> Best regards, Sergey.
> 


-- 
Best regards, Sergey.