<Swing Dev> [15] RFR JDK-8235744: PIT: test/jdk/javax/swing/text/html/TestJLabelWithHTMLText.java times out in linux-x64

[Phil Race]

OK, if we are using localhost already this should be fine.

+1 to push to the JDK 14 stabilisation forest: 
http://hg.openjdk.java.net/jdk/jdk14

-phil

On 12/11/19 10:25 PM, Pankaj Bansal wrote:
>
> Hello Phil,
>
> <<The bug is still in "new" state and has no evaluation. Please add 
> what you added here.
>
> Done
> <<Also I think it best to push this test fix to 14, not 15, once 
> approved, so it does not interfere with JDK 14 final testing.
>
> Ok, I will push this to 14.
> <<Can't this be tested with a file: URL ? What are other similar tests 
> using ?
>
> This can be tested with any url like localhost, file: url. We only 
> need a url which can be accessed without proxy. There are many tests 
> which are using one of these two. That is why I just used localhost. I 
> could use file: url too, but I think that won’t make much difference here.
>
> Regards,
>
> Pankaj
>
> *From:*Phil Race
> *Sent:* Thursday, December 12, 2019 12:13 AM
> *To:* Pankaj Bansal; swing-dev at openjdk.java.net
> *Subject:* Re: <Swing Dev> [15] RFR JDK-8235744: PIT: 
> test/jdk/javax/swing/text/html/TestJLabelWithHTMLText.java times out 
> in linux-x64
>
> The bug is still in "new" state and has no evaluation. Please add what 
> you added here.
> Also I think it best to push this test fix to 14, not 15, once 
> approved, so it does not interfere with JDK 14 final testing.
> Can't this be tested with a file: URL ? What are other similar tests 
> using ?
>
>
> -phil.
>
> On 12/11/19 2:45 AM, Pankaj Bansal wrote:
>
>     Hi All,
>
>     Please review the following test only fix for jdk15.
>
>
>     Bug:
>
>     https://bugs.openjdk.java.net/browse/JDK-8235744
>
>     webrev:
>
>     http://cr.openjdk.java.net/~pbansal/8235744/webrev00/
>
>     Issue:
>
>     The test
>     test/jdk/javax/swing/text/html/TestJLabelWithHTMLText.java on
>     linux-64.
>
>     The test was added under
>     https://bugs.openjdk.java.net/browse/JDK-8230235. The test has a
>     JLabel and a html text with empty image tag. The client property
>     “DocumentBaseKey” is set on the JLabel with value
>     “https://www.google.com/”. If the test is run on a linux machine
>     on a network which requires proxy settings to access internet, the
>     test is timed out if no proxy is set for java. The test just keeps
>     trying to access the url set in “DocumentBaseKey” and as it is set
>     to “https://www.google.com/”, it requires a proxy. I think the
>     test passes on mach5 system as no system proxy is required there
>     to access internet there.
>
>     Fix:
>
>     The fix is to change the “DocumentBaseKey” value to a URL where
>     proxy is not required even if the network needs a proxy to access
>     internet. This can be localhost, some local directory url etc. In
>     the fix, localhost is used. I have verified that after making this
>     change, the test passes with the fix done in
>     https://bugs.openjdk.java.net/browse/JDK-8230235 and fails without
>     the fix.
>
>     Testing:
>
>     I have run this on local machines on network which required proxy
>     to access internet. I have also ran a mach5 job and it is working
>     fine.
>
>
>     Regards,
>     Pankaj Bansal
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20191212/1a7a5057/attachment.htm>