<Swing Dev> [13] JDK-8190361: Incorrect version info in jaccessinspector.exe and jaccesswalker.exe

[Shashidhara Veerabhadraiah]

Hi Phil, It looks like JDK_BUILD_ID is no more set. Here is the code: http://hg.openjdk.java.net/verona/stage/rev/4999895b3a44#l2.7. So mostly the XSTR() function returns the string itself if no value is set.

 

Here is the updated Webrev: http://cr.openjdk.java.net/~sveerabhadra/8190361/webrev.02/

 

Thanks and regards,

Shashi

 

From: Philip Race 
Sent: Wednesday, February 13, 2019 11:24 PM
To: Shashidhara Veerabhadraiah <shashidhara.veerabhadraiah at oracle.com>
Cc: swing-dev <swing-dev at openjdk.java.net>
Subject: Re: <Swing Dev> [13] JDK-8190361: Incorrect version info in jaccessinspector.exe and jaccesswalker.exe

 

I'd prefer to see the webrev updated since it is the only line changed :-)
But part of my confusion is I don't understand why JDK_VERSION_STRING
will be evaluated but JDK_BUILD_ID will be copied literally - rather than
using its value ?

-phil.

On 2/11/19, 12:28 AM, Shashidhara Veerabhadraiah wrote: 

Hi Phil, The version string "JDK_VERSION_STRING" is the one that was brought in as part of the implementation of the JEP: https://bugs.openjdk.java.net/browse/JDK-8085822

 

In this they introduced a change in the name of the version string and here is that change:

http://hg.openjdk.java.net/verona/stage/rev/4999895b3a44#l2.8

 

I think it was missed out change as part of the implementation of that JEP for version string name change. I have added the same info as a confidential comment to the bug.

 

I edited the file on the visual studio with just a replacing the text and I think it has inserted unnecessary indentations. I will modify that while pushing in if it is ok with you(if that's the only change).

 

Thanks and regards,

Shashi

 

From: Phil Race 
Sent: Friday, February 8, 2019 10:28 PM
To: Shashidhara Veerabhadraiah HYPERLINK "mailto:shashidhara.veerabhadraiah at oracle.com"<shashidhara.veerabhadraiah at oracle.com>; swing-dev HYPERLINK "mailto:swing-dev at openjdk.java.net"<swing-dev at openjdk.java.net>
Subject: Re: <Swing Dev> [13] JDK-8190361: Incorrect version info in jaccessinspector.exe and jaccesswalker.exe

 

So yes .. it changes that .. but could you explain why the new string is correct ?
I don't see an evaluation here, or in the bug report - where there should be one!
Also the indentation seems wrong  - even when I look at the "raw" file.

-phil.

On 2/8/19 1:07 AM, Shashidhara Veerabhadraiah wrote:

Hi All, Please review a fix for the below customer bug.

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8190361

 

Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Esveerabhadra/8190361/webrev.01/"http://cr.openjdk.java.net/~sveerabhadra/8190361/webrev.01/

 

The version string for the jaccessinspector and jaccesswalker modules had the string "JDK_BUILD_ID" and this change fixes that. The only doubt I had is that, hopefully these resource files are not generated from a different file and is editable by manual way.

 

Thanks and regards,

Shashi

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190213/73a2ff3a/attachment.html>