<Swing Dev> [12] RFR JDK-8218469, JDK-8218470, JDK-8218472, JDK-8203627 : GTK3 rendering fixes for tck-red bugs

[Phil Race]

One of the bugs covered by this fix 
https://bugs.openjdk.java.net/browse/JDK-8218469
has had a release note (RN) attached declaring that JDK 12 won't consider
the GTKLookAndFeel running on top of GTK+3.20 and later supported.
This RN also covers the related bugs which are also caused by GTK+3.20 :

https://bugs.openjdk.java.net/browse/JDK-8218470
https://bugs.openjdk.java.net/browse/JDK-8218472
https://bugs.openjdk.java.net/browse/JDK-8218473
https://bugs.openjdk.java.net/browse/JDK-8218479

So we have downgraded all of these to P2, and therefore they are no longer
candidates to fix in JDK 12 in the current RC phase per 
https://openjdk.java.net/jeps/3

Please push the fixes to jdk/client (ie JDK 13) instead.
The existing reviews should be OK so long as the patches still apply (eg
offset changes are OK, but no rejections).

-phil.


On 2/13/19 10:59 AM, Phil Race wrote:
> I've tested this fix on
> - OL 7.3 (aka RH 7.3)
> - OL 7.6 (aka RH 7.6)
> - Ubuntu 16.04
> - Ubuntu 18.04
> - Ubuntu 18.10
>
> All looks good to me.
>
> -phil.
>
> On 2/12/19 1:42 PM, Pankaj Bansal wrote:
>>
>> Hi All,
>>
>> Some more fixes are included in the patch to fix some rendering 
>> issues with RadioButton or CheckBox in MenuItems, RadioButton and 
>> Checkbox state flags.
>>
>> webrev: http://cr.openjdk.java.net/~pbansal/8218469/webrev01/
>>
>> -Pankaj
>>
>> *From:*Pankaj Bansal
>> *Sent:* Tuesday, February 12, 2019 11:38 PM
>> *To:* swing-dev at openjdk.java.net
>> *Subject:* <Swing Dev> [12] RFR JDK-8218469, JDK-8218470, 
>> JDK-8218472, JDK-8203627 : GTK3 rendering fixes for tck-red bugs
>>
>> Hi All,
>>
>> Please review the following fix.
>>
>>
>> Bug:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8218469 -  JSlider display 
>> issue with slider for GTKLookAndFeel
>>
>> https://bugs.openjdk.java.net/browse/JDK-8218470-  JScrollBar display 
>> issue with GTKLookAndFeel
>>
>> https://bugs.openjdk.java.net/browse/JDK-8218472- JProgressBar 
>> display issue with GTKLookAndFeel
>>
>> https://bugs.openjdk.java.net/browse/JDK-8203627 - Swing applications 
>> with JRadioButton and JCheckbox fail to render correctly when using 
>> GTK3 and the GTK L&F
>>
>> webrev
>>
>> http://cr.openjdk.java.net/~pbansal/8218469/webrev00/
>>
>> Issue:
>>
>> From gtk 3.20, gtk has changed the way themes and styles work for 
>> many widgets. Due to which, jdk is not able to render some widgets 
>> properly including JSlider, JProgressBar, JScrollBar, JRadioButton, 
>> JCheckbox.
>>
>> gtk 3.20 release notes: 
>> https://developer.gnome.org/gtk3/stable/ch32s10.html
>>
>> Fix:
>>
>> This patch fixes rendering issues in all these widgets by using 
>> correct way to define styles.
>>
>>
>> Regards,
>> Pankaj Bansal
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190214/0fb346e5/attachment.html>