<Swing Dev> [13] RFR [JDK-8211322] Reduce the timeout of tooltip in SwingSet2DemoTest

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Feb 26 08:11:01 UTC 2019


Looks fine.

On 25/02/2019 23:32, gauri.patil at oracle.com wrote:
> Hi All,
> 
> 
>              Gentle Reminder.
> 
> 
> Thanks and Regards
> 
> Gauri Patil
> 
> 
> On 20/02/19 11:03 AM, gauri.patil at oracle.com wrote:
>> Hi Shura,
>>
>>                 A bug is created for this issue, the bug id for the same is,
>>
>>    https://bugs.openjdk.java.net/browse/CODETOOLS-7902388.
>>
>>
>> Thanks and Regards
>>
>> Gauri Patil
>>
>>
>> On 25/01/19 10:09 PM, Alexandre (Shura) Iline wrote:
>>> Hi.
>>>
>>> SwingSet2DemoTest.java changes look good.
>>>
>>> I have a small comment on JToolTipOperator changes:
>>>   323            Thread.currentThread().interrupt();
>>>   324            throw (new JemmyException("Waiting of " + waitable.getDescription()
>>>   325                + " state has been interrupted!"));
>>> only one of the two should happen: either throw or calling Thread.interrupt().
>>> also there are extra unneeded brackets.
>>>
>>> I do not see it as harmful, as it will result in an exception anyway. But it still needs to be cleaned up.
>>>
>>> I understand that JToolTipOperator is just brought over from the Jemmy repo on code-tools, so I suggest you to push this and create a bug to clean the code in the Jemmy repo.
>>>
>>> Shura
>>>
>>>> On Jan 24, 2019, at 10:39 PM, gauri.patil at oracle.com wrote:
>>>>
>>>> Hi All,
>>>>
>>>> Please review fix for the task:
>>>>
>>>> Task: https://bugs.openjdk.java.net/browse/JDK-8211322
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~vagarwal/8211322/webrev.2/
>>>>
>>>> Changes in jemmy file JToolTipOperator is already checked in jemmy repo by task http://hg.openjdk.java.net/code-tools/jemmy/v2/rev/079c447a1c3e .
>>>>
>>>> Description of fixes:
>>>>
>>>> In SwingSet2 demo, we have a checkbox menu item to enable/disable tool tips.(Options->Enable Tool Tips).
>>>> We used this feature to test the swing component JCheckBoxMenuItem.
>>>> So after disabling tooltip, it keeps mouse pointer on thumbnail and make sure it doesn’t show tooltip. It will wait for 1 minute(jemmy default timeout duration).
>>>>
>>>> Reduce this timeout to say 5 seconds, that's enough to show tooltip on a component usual scenario.
>>>>
>>>>
>>>> Thanks and Regards
>>>> Gauri Patil
>>>>
>>
> 


-- 
Best regards, Sergey.


More information about the swing-dev mailing list