<Swing Dev> [13] RFR JDK-8214252: Expanded & Collapsed nodes of a JTree look the same on GTK3

[Pankaj Bansal]

Hi All,

Please review the following fix. 


Bug: https://bugs.openjdk.java.net/browse/JDK-8214252

webrev: http://cr.openjdk.java.net/~pbansal/8214252/webrev.00/



Issue:

The icon for collapsed and expanded node in JTree looks same. It is always showing collapsed icon even when a node has been expanded.

 

Fix:

gtk3 has added new state flags and changed the meaning of a few existing state flags from gtk 3.14 version. Earlier GTK_STATE_FLAG_ACTIVE was used for checked state of widgets like checkbox, radiobutton, tree icon (expanded or collapsed) etc. From gtk 3.14 version,  GTK_STATE_FLAG_CHECKED flag has been added to denotes the checked state for these widgets. This change has been taken care of in case of checkbox and radiobutton, but not for tree icon (expanded or collapsed). This change fixes this issue.

https://developer.gnome.org/gtk3/stable/GtkStyleContext.html#gtk-render-expander

https://developer.gnome.org/gtk3/stable/gtk3-Standard-Enumerations.html#GTK-STATE-FLAG-CHECKED:CAPS

 

This can be verified by running SwingSet2 demo or any other JTree Sample/Demo/Test. So, no new test is being added. I have tested this on Ubuntu 18.04, Ubuntu 16.04 and OEL 7.5. 


Regards,
Pankaj Bansal

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190109/59958df0/attachment.html>