<Swing Dev> [13] RFR JDK-8214111: There is no icon in all JOptionPane target image

[Prasanta Sadhukhan]

Hi Pankaj,

looks ok to me.
Although there is this statement for gtk_check_version()
"However, such a check isn’t completely reliable, since the module may 
be linked against an old version of GTK+ and calling the old version of 
|gtk_check_version()| 
<https://developer.gnome.org/gtk3/stable/gtk3-Feature-Test-Macros.html#gtk-check-version>, 
but still get loaded into an application using a newer version of GTK" 
in which case this fix may not work. However, I do not see any alternative.

Regards
Prasanta
On 14-Jan-19 5:56 PM, Pankaj Bansal wrote:
>
> Hi All,
>
> Please review the following fix.
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214111
>
> webrev: http://cr.openjdk.java.net/~pbansal/8214111/webrev.00/ 
> <http://cr.openjdk.java.net/%7Epbansal/8214111/webrev.00/>
>
> Issue:
>
> The icons are not being displayed in JOptionPane for warning, error, 
> info dialog etc. This issue is being observed in OEL with gtk3.
>
> Fix:
>
> The icon names used in JOptionPane for GTKLookAndFeel are mentioned in 
> GTKStyle.java. These icon names were changed from gtk3 version  3.10. 
> This change was not incorporated in jdk and so the icons are not being 
> displayed properly in OEL. In Ubuntu, there are symbolic links present 
> in icon themes with old names which link to actual icons with correct 
> names. So the icons are being displayed successfully in Ubuntu through 
> these symbolic links though the icon names should have been changed 
> according to gtk3 specification change.
>
> https://developer.gnome.org/gtk2/stable/gtk2-Stock-Items.html#GTK-STOCK-DIALOG-ERROR:CAPS
>
> https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-DIALOG-ERROR:CAPS
>
> This fix can be verified by running SwingSet2 demo or any other 
> JOptionPane Sample/Demo/Test. So, no new test is being added. I have 
> tested this on Ubuntu 18.04, Ubuntu 16.04 and OEL 7.5 with both gtk2 
> and gtk3.
>
>
> Regards,
> Pankaj Bansal
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190118/646a8a16/attachment-0001.html>