<Swing Dev> [14] JDK-8225423: GTK L&F: JSplitPane: There is no divider shown

[Phil Race]

Hi,


I am a bit confused by some things in the bug report where first it
was said it is also not visible in a native app, but now it seems it
should be visible ? Why the discrepancy ?

Have you verified this fix on the OS versions you list below ? I think 
you should also verify it on OL 8 Beta. fp_gtk_hpaned_new and 
fp_gtk_vpaned_new look to be unused after this change, so should be 
deleted. -phil.



On 7/8/19 2:47 AM, Prasanta Sadhukhan wrote:
>
> Hi All,
>
> Please review a fix for an issue where it is seen that the splitpane 
> divider is not seen for GTK3 in ubuntu18.04, 19.04, oel7.5.
>
> Due to change in style handling for many widgets from gtk3.20, many 
> widgets was not rendered correctly of which we had solved many in 
> http://hg.openjdk.java.net/jdk/jdk/rev/76668d618a99
> but JSplitPane was not rectified.
>
> It was seen that from
>
> https://developer.gnome.org/gtk3/stable/GtkVPaned.html#gtk-vpaned-new 
> and https://developer.gnome.org/gtk3/stable/GtkHPaned.html#gtk-hpaned-new
>
> that GtkHPaned and GtkVPaned has been deprecated and we should use 
> GtkPaned instead.
>
> Proposed fix makes sure that we use GtkPaned for JSplitpane and also 
> adjust the position of the handle/splitpane divider in render_handle() 
> method to make sure it is visible.
>
> With this change, we can now see a thin line between the pane as is 
> observed via native gtk program.
>
> Bug:https://bugs.openjdk.java.net/browse/JDK-8225423
>
> webrev: http://cr.openjdk.java.net/~psadhukhan/8225423/webrev.0/
>
> Snapshot Before fix and After fix is shown Before Fix 
> <http://cr.openjdk.java.net/~psadhukhan/8225423/beforefix.png>and 
> After Fix <http://cr.openjdk.java.net/~psadhukhan/8225423/afterfix.png>
>
> Regards
> Prasanta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190708/07dcc75a/attachment.html>