<Swing Dev> [14] JDK-8225423: GTK L&F: JSplitPane: There is no divider shown

[Philip Race]

Hi,

OL 8 Beta is readily available for public download and installs fine in 
VirtualBox.
It should not take very long at all. It took me approximately 1 hour 
from start to finish.
But you need to give it more disk space than I've seen for older releases.
I think I used 16GB and it was very touch and go. Minimum 24 GB I suppose.

Also I propose we should target this to 13, not 14.

-phil.

On 7/9/19, 6:10 AM, Prasanta Sadhukhan wrote:
>
>
> On 08-Jul-19 10:51 PM, Phil Race wrote:
>> Hi,
>>
>>
>> I am a bit confused by some things in the bug report where first it
>> was said it is also not visible in a native app, but now it seems it
>> should be visible ? Why the discrepancy ?
> gtk2 has 3 miniscule horizontal lines in the divider which is not 
> present/visible in gtk3 native app. Also,  in gtk3 native app, space 
> between the 2 panes is narrow (unlike gtk2 where divider is thick and 
> distinct) and appears as a thin line. I perceived that the gap between 
> 2 panes in Java can be construed as a separation but  it can also be 
> perceived as a background and not as a separate line. So, with this 
> fix, we were able to show a thin line in the space between the 2 panes 
> to mark pane separator, akin to native gtk3 app.
>> Have you verified this fix on the OS versions you list below ?
> I have verified on ubuntu18.04, 19.04, OL7.5.
>>
>> I think you should also verify it on OL 8 Beta.
> We do not have OL8 currently so it will take some time to verify it 
> there. Upgrading 7.5 is not a possibility as the other tck-red fix 
> needs to be verified there too.
>>
>>   
>> fp_gtk_hpaned_new andfp_gtk_vpaned_new look to be unused after this change,
>> so should be deleted.
>
> Done...Modified webrev 
> http://cr.openjdk.java.net/~psadhukhan/8225423/webrev.1/
>
> Regards
> Prasanta
>>
>> -phil.
>>
>>
>>
>>
>> On 7/8/19 2:47 AM, Prasanta Sadhukhan wrote:
>>>
>>> Hi All,
>>>
>>> Please review a fix for an issue where it is seen that the splitpane 
>>> divider is not seen for GTK3 in ubuntu18.04, 19.04, oel7.5.
>>>
>>> Due to change in style handling for many widgets from gtk3.20, many 
>>> widgets was not rendered correctly of which we had solved many in 
>>> http://hg.openjdk.java.net/jdk/jdk/rev/76668d618a99
>>> but JSplitPane was not rectified.
>>>
>>> It was seen that from
>>>
>>> https://developer.gnome.org/gtk3/stable/GtkVPaned.html#gtk-vpaned-new and 
>>> https://developer.gnome.org/gtk3/stable/GtkHPaned.html#gtk-hpaned-new
>>>
>>> that GtkHPaned and GtkVPaned has been deprecated and we should use 
>>> GtkPaned instead.
>>>
>>> Proposed fix makes sure that we use GtkPaned for JSplitpane and also 
>>> adjust the position of the handle/splitpane divider in 
>>> render_handle() method to make sure it is visible.
>>>
>>> With this change, we can now see a thin line between the pane as is 
>>> observed via native gtk program.
>>>
>>> Bug:https://bugs.openjdk.java.net/browse/JDK-8225423
>>>
>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8225423/webrev.0/
>>>
>>> Snapshot Before fix and After fix is shown Before Fix 
>>> <http://cr.openjdk.java.net/%7Epsadhukhan/8225423/beforefix.png>and 
>>> After Fix 
>>> <http://cr.openjdk.java.net/%7Epsadhukhan/8225423/afterfix.png>
>>>
>>> Regards
>>> Prasanta
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190709/6986fb86/attachment.html>