From prasanta.sadhukhan at oracle.com  Mon Jun  3 10:24:29 2019
From: prasanta.sadhukhan at oracle.com (Prasanta Sadhukhan)
Date: Mon, 3 Jun 2019 15:54:29 +0530
Subject: <Swing Dev> [13] RFR
 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java
 fails on linux-x64
In-Reply-To: <85251886-7ba3-f74f-2408-6e4e21c647ff@oracle.com>
References: <d6589c20-d38b-bc50-2220-5d5ceb3fa3de@oracle.com>
 <5b9179d9-220e-9838-0454-cc84592fd093@oracle.com>
 <85251886-7ba3-f74f-2408-6e4e21c647ff@oracle.com>
Message-ID: <eb95600b-ffaa-031c-b055-00384ec41783@oracle.com>

Gentle reminder...


On 30-May-19 12:32 PM, Prasanta Sadhukhan wrote:
> I could not find anything amiss when I capture the screen output at 
> the time of fail, so I decided to go to timeout increase route. I 
> guess it is needed to check the test manually in that mach5 specific 
> linux system to see what is happening.
>
> Regards
> Prasanta
> On 29-May-19 2:29 AM, Sergey Bylokhov wrote:
>> Hi, Prasanta.
>>
>> Isn't strange that 1 second is not enough to wait for redraw?
>> I'll reply soon after rechecking the test manually on this system.
>>
>> On 28/05/2019 04:01, Prasanta Sadhukhan wrote:
>>> Hi All,
>>>
>>> Please review a test-fix for an issue where the test check fails 
>>> after the content of window is dragged & resized.
>>> Test is passing in local ubuntu18.04 system but is failing on mach5 
>>> linux headful system as test check for pixels happens too quickly 
>>> after window drag/resize.
>>> Increased delay between test drag&drop and check to make sure check 
>>> happens after reasonable amount of time. Test now pass in all mach5 
>>> systems.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224876
>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8224876/webrev.0/
>>>
>>> Regards
>>> Prasanta
>>
>>
>


From jayathirth.d.v at oracle.com  Mon Jun  3 11:00:52 2019
From: jayathirth.d.v at oracle.com (Jayathirth D V)
Date: Mon, 3 Jun 2019 04:00:52 -0700 (PDT)
Subject: <Swing Dev> [13] RFR
 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java
 fails on linux-x64
In-Reply-To: <eb95600b-ffaa-031c-b055-00384ec41783@oracle.com>
References: <d6589c20-d38b-bc50-2220-5d5ceb3fa3de@oracle.com>
 <5b9179d9-220e-9838-0454-cc84592fd093@oracle.com>
 <85251886-7ba3-f74f-2408-6e4e21c647ff@oracle.com>
 <eb95600b-ffaa-031c-b055-00384ec41783@oracle.com>
Message-ID: <464b8b02-e182-4967-bd84-a3bf0ec4f635@default>

Changes are fine but we should wait on Sergey's manual check of test in the system.

Thanks,
Jay

-----Original Message-----
From: Prasanta Sadhukhan 
Sent: Monday, June 03, 2019 3:54 PM
To: Sergey Bylokhov; swing-dev at openjdk.java.net
Subject: Re: <Swing Dev> [13] RFR 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java fails on linux-x64

Gentle reminder...


On 30-May-19 12:32 PM, Prasanta Sadhukhan wrote:
> I could not find anything amiss when I capture the screen output at 
> the time of fail, so I decided to go to timeout increase route. I 
> guess it is needed to check the test manually in that mach5 specific 
> linux system to see what is happening.
>
> Regards
> Prasanta
> On 29-May-19 2:29 AM, Sergey Bylokhov wrote:
>> Hi, Prasanta.
>>
>> Isn't strange that 1 second is not enough to wait for redraw?
>> I'll reply soon after rechecking the test manually on this system.
>>
>> On 28/05/2019 04:01, Prasanta Sadhukhan wrote:
>>> Hi All,
>>>
>>> Please review a test-fix for an issue where the test check fails 
>>> after the content of window is dragged & resized.
>>> Test is passing in local ubuntu18.04 system but is failing on mach5 
>>> linux headful system as test check for pixels happens too quickly 
>>> after window drag/resize.
>>> Increased delay between test drag&drop and check to make sure check 
>>> happens after reasonable amount of time. Test now pass in all mach5 
>>> systems.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224876
>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8224876/webrev.0/
>>>
>>> Regards
>>> Prasanta
>>
>>
>


From Sergey.Bylokhov at oracle.com  Mon Jun  3 20:00:35 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 3 Jun 2019 13:00:35 -0700
Subject: <Swing Dev> [13] RFR
 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java
 fails on linux-x64
In-Reply-To: <464b8b02-e182-4967-bd84-a3bf0ec4f635@default>
References: <d6589c20-d38b-bc50-2220-5d5ceb3fa3de@oracle.com>
 <5b9179d9-220e-9838-0454-cc84592fd093@oracle.com>
 <85251886-7ba3-f74f-2408-6e4e21c647ff@oracle.com>
 <eb95600b-ffaa-031c-b055-00384ec41783@oracle.com>
 <464b8b02-e182-4967-bd84-a3bf0ec4f635@default>
Message-ID: <a91fcff9-ab69-7d58-b7e0-bf09e907dec9@oracle.com>

Looks fine, I have checked it and looks like it can really  lag time to time.

On 03/06/2019 04:00, Jayathirth D V wrote:
> Changes are fine but we should wait on Sergey's manual check of test in the system.
> 
> Thanks,
> Jay
> 
> -----Original Message-----
> From: Prasanta Sadhukhan
> Sent: Monday, June 03, 2019 3:54 PM
> To: Sergey Bylokhov; swing-dev at openjdk.java.net
> Subject: Re: <Swing Dev> [13] RFR 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java fails on linux-x64
> 
> Gentle reminder...
> 
> 
> On 30-May-19 12:32 PM, Prasanta Sadhukhan wrote:
>> I could not find anything amiss when I capture the screen output at
>> the time of fail, so I decided to go to timeout increase route. I
>> guess it is needed to check the test manually in that mach5 specific
>> linux system to see what is happening.
>>
>> Regards
>> Prasanta
>> On 29-May-19 2:29 AM, Sergey Bylokhov wrote:
>>> Hi, Prasanta.
>>>
>>> Isn't strange that 1 second is not enough to wait for redraw?
>>> I'll reply soon after rechecking the test manually on this system.
>>>
>>> On 28/05/2019 04:01, Prasanta Sadhukhan wrote:
>>>> Hi All,
>>>>
>>>> Please review a test-fix for an issue where the test check fails
>>>> after the content of window is dragged & resized.
>>>> Test is passing in local ubuntu18.04 system but is failing on mach5
>>>> linux headful system as test check for pixels happens too quickly
>>>> after window drag/resize.
>>>> Increased delay between test drag&drop and check to make sure check
>>>> happens after reasonable amount of time. Test now pass in all mach5
>>>> systems.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224876
>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8224876/webrev.0/
>>>>
>>>> Regards
>>>> Prasanta
>>>
>>>
>>
> 


-- 
Best regards, Sergey.

From philip.race at oracle.com  Mon Jun  3 20:07:36 2019
From: philip.race at oracle.com (Phil Race)
Date: Mon, 3 Jun 2019 13:07:36 -0700
Subject: <Swing Dev> [13] RFR 7184956: [macosx]
 JPopupMenu.setDefaultLightPopupEneble(true) doesn't work correctly
In-Reply-To: <59945c45-b9dc-421d-03c3-d750e33585b1@oracle.com>
References: <59945c45-b9dc-421d-03c3-d750e33585b1@oracle.com>
Message-ID: <9d2f6d19-75bc-3274-0f35-a6a46b820cf8@oracle.com>

The test update tests the OS but if I understand correctly, it is the 
Aqua L&F that does not support
lightweight popups. Can we check if it is Aqua rather than by OS ?
If you don't want to hard code Aqua then check if it is macos and system 
L&F.
Ideally there'd be some way to query whether a L&F supports this case 
but there isn't,
so I'd like to see? the test include a comment that says
// No API exists to check this, but Aqua currently does not support 
lightweight popups.

Lightweight popups seem to me to be principally a performance optimisation.
The thing you have to support is heavyweights and lightweights are 
optional, and
since I don't think we are likely to investigate whether this can be 
done for Aqua anytime
soon then the test update seems like an OK step.

-phil

On 5/24/19 1:26 PM, semyon.sadetsky at oracle.com wrote:
> webrev: http://cr.openjdk.java.net/~ssadetsky/7184956/webrev.00/
>
> bug: https://bugs.openjdk.java.net/browse/JDK-7184956
>
> Fix for a test: Mac light weigh popup testing excluded.
>
> --Semyon
>


From semyon.sadetsky at oracle.com  Mon Jun  3 22:49:38 2019
From: semyon.sadetsky at oracle.com (semyon.sadetsky at oracle.com)
Date: Mon, 3 Jun 2019 15:49:38 -0700
Subject: <Swing Dev> [13] RFR 7184956: [macosx]
 JPopupMenu.setDefaultLightPopupEneble(true) doesn't work correctly
In-Reply-To: <9d2f6d19-75bc-3274-0f35-a6a46b820cf8@oracle.com>
References: <59945c45-b9dc-421d-03c3-d750e33585b1@oracle.com>
 <9d2f6d19-75bc-3274-0f35-a6a46b820cf8@oracle.com>
Message-ID: <26fb8d3e-698d-decf-ff66-19c6634c3cb3@oracle.com>

On 6/3/19 1:07 PM, Phil Race wrote:

> The test update tests the OS but if I understand correctly, it is the 
> Aqua L&F that does not support
> lightweight popups. Can we check if it is Aqua rather than by OS ?
> If you don't want to hard code Aqua then check if it is macos and 
> system L&F.
> Ideally there'd be some way to query whether a L&F supports this case 
> but there isn't,
> so I'd like to see  the test include a comment that says
> // No API exists to check this, but Aqua currently does not support 
> lightweight popups.
OK: http://cr.openjdk.java.net/~ssadetsky/7184956/webrev.01
>
> Lightweight popups seem to me to be principally a performance 
> optimisation.
I agree, it is clear from the spec that the property is mostly aimed to 
enforce lightweight popups disabled rather than enabling them.
And this optimization is not very effective since even if the 
lightweight popups are enabled they still cannot
be used beyond the borders of the window and above other windows which 
are the areas where popups are usually showed up.
Also the behavior and appearance of lightweight popups often don't 
correspond to the native apps.  For example, on Mac if a Swing widow is
overlapped by the top window remaining visible some area of the Swing 
window which got the right mouse click
then the appeared popup menu should overlap the top window without 
bringing the Swing window to top.
This is cannot be achieve using the optimized lightweight version of the 
popup that will be selected when the popup size fits in the Swing window
despite it intersects the top window.
> The thing you have to support is heavyweights and lightweights are 
> optional, and
> since I don't think we are likely to investigate whether this can be 
> done for Aqua anytime
> soon then the test update seems like an OK step.
That would require to introduce an API change and the implementation 
which addresses all those behavioral and appearance issues. Just 
unreasonable.

--Semyon
>
> -phil
>
> On 5/24/19 1:26 PM, semyon.sadetsky at oracle.com wrote:
>> webrev: http://cr.openjdk.java.net/~ssadetsky/7184956/webrev.00/
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-7184956
>>
>> Fix for a test: Mac light weigh popup testing excluded.
>>
>> --Semyon
>>
>


From Sergey.Bylokhov at oracle.com  Mon Jun  3 23:19:31 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 3 Jun 2019 16:19:31 -0700
Subject: <Swing Dev> [13] RFR 7184956: [macosx]
 JPopupMenu.setDefaultLightPopupEneble(true) doesn't work correctly
In-Reply-To: <9d2f6d19-75bc-3274-0f35-a6a46b820cf8@oracle.com>
References: <59945c45-b9dc-421d-03c3-d750e33585b1@oracle.com>
 <9d2f6d19-75bc-3274-0f35-a6a46b820cf8@oracle.com>
Message-ID: <30c4614b-86ec-f2da-8551-16b6e60e2884@oracle.com>

On 03/06/2019 13:07, Phil Race wrote:
> Lightweight popups seem to me to be principally a performance optimisation.
> The thing you have to support is heavyweights and lightweights are optional, and
> since I don't think we are likely to investigate whether this can be done for Aqua anytime
> soon then the test update seems like an OK step.

The difference between HW vs LW popups are not only in the performance,
there is a difference in the appearance. The LW popups inherit the visual properties such as
translucency/opacity from the owner window(since the painted on the owner), while HW popup are independent from the owner.
When we break this functionality in JDK 7 we got a regression report:
https://bugs.openjdk.java.net/browse/JDK-7156657

Current bug report is not a testbug, and I do not see a reason why the test should be updated.
Even if we add workaround to the test then we will need to create a new CR to check this behavior later, but why wee need to do it, since we already have this bug, which mentions this issues already.

The common workflow for such product issues is to add it to the "problem list" using the product bugid.

-- 
Best regards, Sergey.

From Sergey.Bylokhov at oracle.com  Tue Jun  4 00:03:55 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 3 Jun 2019 17:03:55 -0700
Subject: <Swing Dev> [13] RFR 7184956: [macosx]
 JPopupMenu.setDefaultLightPopupEneble(true) doesn't work correctly
In-Reply-To: <30c4614b-86ec-f2da-8551-16b6e60e2884@oracle.com>
References: <59945c45-b9dc-421d-03c3-d750e33585b1@oracle.com>
 <9d2f6d19-75bc-3274-0f35-a6a46b820cf8@oracle.com>
 <30c4614b-86ec-f2da-8551-16b6e60e2884@oracle.com>
Message-ID: <fe28c0b8-2c83-1f88-8a7e-16827a628b3c@oracle.com>

On 03/06/2019 16:19, Sergey Bylokhov wrote:
> The common workflow for such product issues is to add it to the "problem list" using the product bugid.

And since this test is already in the problem list under this bugid, and we do not want to fix the bug right now then why we need to do something, we can just do nothing for now and move on to the next issues.


-- 
Best regards, Sergey.

From Sergey.Bylokhov at oracle.com  Tue Jun  4 00:16:53 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 3 Jun 2019 17:16:53 -0700
Subject: <Swing Dev> [13] Review Request: 8225144 [macos] In Aqua L&F
 backspace key does not delete when Shift is pressed
Message-ID: <f6041c3e-dbbb-61e2-430b-3cb21be99781@oracle.com>

Hello.
Please review the fix for JDK 13.

Bug: https://bugs.openjdk.java.net/browse/JDK-8225144
Fix: http://cr.openjdk.java.net/~serb/8225144/webrev.00

This bug is a version of JDK-6361367[1] but this time for Aqua L&F.

In JTextFields and JTextAreas when pressing with backspace and shift nothing happens,
but the native programs delete under these circumstances.

In the fix in the Aqua L&F, the key binding for "shift+backspace" is added, actually, it means that shift in this shortcut will be ignored and simple backspace action will be executed.

[1] https://bugs.openjdk.java.net/browse/JDK-6361367

-- 
Best regards, Sergey.

From philip.race at oracle.com  Tue Jun  4 00:19:44 2019
From: philip.race at oracle.com (Philip Race)
Date: Mon, 03 Jun 2019 17:19:44 -0700
Subject: <Swing Dev> [13] RFR 7184956: [macosx]
 JPopupMenu.setDefaultLightPopupEneble(true) doesn't work correctly
In-Reply-To: <fe28c0b8-2c83-1f88-8a7e-16827a628b3c@oracle.com>
References: <59945c45-b9dc-421d-03c3-d750e33585b1@oracle.com>
 <9d2f6d19-75bc-3274-0f35-a6a46b820cf8@oracle.com>
 <30c4614b-86ec-f2da-8551-16b6e60e2884@oracle.com>
 <fe28c0b8-2c83-1f88-8a7e-16827a628b3c@oracle.com>
Message-ID: <5CF5B920.8000906@oracle.com>

I don't know how much I agree with the earlier email but this much is true,
i.e. it doesn't make any practical difference to avoid running the test 
in a different way.
And our focus right now is supposed to be on failing tests *not* on the 
problem list.

-phil

On 6/3/19, 5:03 PM, Sergey Bylokhov wrote:
> On 03/06/2019 16:19, Sergey Bylokhov wrote:
>> The common workflow for such product issues is to add it to the 
>> "problem list" using the product bugid.
>
> And since this test is already in the problem list under this bugid, 
> and we do not want to fix the bug right now then why we need to do 
> something, we can just do nothing for now and move on to the next issues.
>
>

From prasanta.sadhukhan at oracle.com  Tue Jun  4 05:55:46 2019
From: prasanta.sadhukhan at oracle.com (Prasanta Sadhukhan)
Date: Tue, 4 Jun 2019 11:25:46 +0530
Subject: <Swing Dev> [13] Review Request: 8225144 [macos] In Aqua L&F
 backspace key does not delete when Shift is pressed
In-Reply-To: <f6041c3e-dbbb-61e2-430b-3cb21be99781@oracle.com>
References: <f6041c3e-dbbb-61e2-430b-3cb21be99781@oracle.com>
Message-ID: <a7f13fb3-b8f4-dc58-d9a5-23f2e0cd8665@oracle.com>

+1

Regards
Prasanta
On 04-Jun-19 5:46 AM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for JDK 13.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8225144
> Fix: http://cr.openjdk.java.net/~serb/8225144/webrev.00
>
> This bug is a version of JDK-6361367[1] but this time for Aqua L&F.
>
> In JTextFields and JTextAreas when pressing with backspace and shift 
> nothing happens,
> but the native programs delete under these circumstances.
>
> In the fix in the Aqua L&F, the key binding for "shift+backspace" is 
> added, actually, it means that shift in this shortcut will be ignored 
> and simple backspace action will be executed.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-6361367
>


From semyon.sadetsky at oracle.com  Tue Jun  4 16:18:07 2019
From: semyon.sadetsky at oracle.com (semyon.sadetsky at oracle.com)
Date: Tue, 4 Jun 2019 09:18:07 -0700
Subject: <Swing Dev> [13] Review Request: 8225144 [macos] In Aqua L&F
 backspace key does not delete when Shift is pressed
In-Reply-To: <f6041c3e-dbbb-61e2-430b-3cb21be99781@oracle.com>
References: <f6041c3e-dbbb-61e2-430b-3cb21be99781@oracle.com>
Message-ID: <6f514a50-c7ff-c7f9-0ecd-b490b286abc2@oracle.com>

Hi Sergey,

Please add also Ctrl+BackSpace (delete previous char) and 
Command+BackSpace (delete previous word) keystrokes which are ignored in 
Aqua as well.

--Semyon


On 6/3/19 5:16 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for JDK 13.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8225144
> Fix: http://cr.openjdk.java.net/~serb/8225144/webrev.00
>
> This bug is a version of JDK-6361367[1] but this time for Aqua L&F.
>
> In JTextFields and JTextAreas when pressing with backspace and shift 
> nothing happens,
> but the native programs delete under these circumstances.
>
> In the fix in the Aqua L&F, the key binding for "shift+backspace" is 
> added, actually, it means that shift in this shortcut will be ignored 
> and simple backspace action will be executed.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-6361367
>


From semyon.sadetsky at oracle.com  Tue Jun  4 16:54:51 2019
From: semyon.sadetsky at oracle.com (semyon.sadetsky at oracle.com)
Date: Tue, 4 Jun 2019 09:54:51 -0700
Subject: <Swing Dev> [13] RFR 7184956: [macosx]
 JPopupMenu.setDefaultLightPopupEneble(true) doesn't work correctly
In-Reply-To: <5CF5B920.8000906@oracle.com>
References: <59945c45-b9dc-421d-03c3-d750e33585b1@oracle.com>
 <9d2f6d19-75bc-3274-0f35-a6a46b820cf8@oracle.com>
 <30c4614b-86ec-f2da-8551-16b6e60e2884@oracle.com>
 <fe28c0b8-2c83-1f88-8a7e-16827a628b3c@oracle.com>
 <5CF5B920.8000906@oracle.com>
Message-ID: <30df0ac0-8962-67c1-d811-9fbf41dbe03f@oracle.com>

On 6/3/19 5:19 PM, Philip Race wrote:

> I don't know how much I agree with the earlier email but this much is 
> true,
> i.e. it doesn't make any practical difference to avoid running the 
> test in a different way.
The practical difference is the coverage. We avoid running only one 
specific scenario of the test and only for one L&F other test scenarios 
and L&Fs will not be avoided.

--Semyon

From Sergey.Bylokhov at oracle.com  Wed Jun  5 02:24:15 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 4 Jun 2019 19:24:15 -0700
Subject: <Swing Dev> [13] Review Request: 8225144 [macos] In Aqua L&F
 backspace key does not delete when Shift is pressed
In-Reply-To: <6f514a50-c7ff-c7f9-0ecd-b490b286abc2@oracle.com>
References: <f6041c3e-dbbb-61e2-430b-3cb21be99781@oracle.com>
 <6f514a50-c7ff-c7f9-0ecd-b490b286abc2@oracle.com>
Message-ID: <2f9f5c11-e63a-3107-be93-57c7be5383c3@oracle.com>

Hi, Semyon.

I would like to investigate other macOS specific shortcuts in a separate CR

>> Please add also Ctrl+BackSpace (delete previous char) 

I made a quick look and it seems ctrl+backspace does not work in some application like Thunderbird.

> and Command+BackSpace (delete previous word) keystrokes which are ignored in Aqua as well.

On macOS to remove the previous word the "Opt+BackSpace" is used and it is implemented.

Also "Ctrl+BackSpace" and "Command+BackSpace", unlike "Opt+BackSpace" are not mentioned in the
list of "standard" shortcuts:
https://support.apple.com/en-us/HT201236


On 04/06/2019 09:18, semyon.sadetsky at oracle.com wrote:
> 
> --Semyon
> 
> 
> On 6/3/19 5:16 PM, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for JDK 13.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8225144
>> Fix: http://cr.openjdk.java.net/~serb/8225144/webrev.00
>>
>> This bug is a version of JDK-6361367[1] but this time for Aqua L&F.
>>
>> In JTextFields and JTextAreas when pressing with backspace and shift nothing happens,
>> but the native programs delete under these circumstances.
>>
>> In the fix in the Aqua L&F, the key binding for "shift+backspace" is added, actually, it means that shift in this shortcut will be ignored and simple backspace action will be executed.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-6361367
>>
> 


-- 
Best regards, Sergey.

From semyon.sadetsky at oracle.com  Wed Jun  5 15:52:08 2019
From: semyon.sadetsky at oracle.com (semyon.sadetsky at oracle.com)
Date: Wed, 5 Jun 2019 08:52:08 -0700
Subject: <Swing Dev> [13] Review Request: 8225144 [macos] In Aqua L&F
 backspace key does not delete when Shift is pressed
In-Reply-To: <2f9f5c11-e63a-3107-be93-57c7be5383c3@oracle.com>
References: <f6041c3e-dbbb-61e2-430b-3cb21be99781@oracle.com>
 <6f514a50-c7ff-c7f9-0ecd-b490b286abc2@oracle.com>
 <2f9f5c11-e63a-3107-be93-57c7be5383c3@oracle.com>
Message-ID: <299d5943-f541-0939-0a33-93e25688bc8b@oracle.com>

On 6/4/19 7:24 PM, Sergey Bylokhov wrote:

> Hi, Semyon.
>
> I would like to investigate other macOS specific shortcuts in a 
> separate CR
What specifically you need to investigate? Those keystrokes work for all 
other L&Fs.and I see no other actions mapped to them.
>
>>> Please add also Ctrl+BackSpace (delete previous char) 
>
> I made a quick look and it seems ctrl+backspace does not work in some 
> application like Thunderbird.
That is not a valid argument. Thunderbird is base on Mozilla XUL 
framework which UI components behavior can be different from the 
standard one.
>
>> and Command+BackSpace (delete previous word) keystrokes which are 
>> ignored in Aqua as well.
>
> On macOS to remove the previous word the "Opt+BackSpace" is used and 
> it is implemented.
That's correct, but Command modifier works the same way.
>
> Also "Ctrl+BackSpace" and "Command+BackSpace", unlike "Opt+BackSpace" 
> are not mentioned in the
> list of "standard" shortcuts:
> https://support.apple.com/en-us/HT201236
Anyway it works in macOS native apps and costs nothing to be added to 
Aqua L&F.
OK, this one is up to you...

--Semyon
>
>
> On 04/06/2019 09:18, semyon.sadetsky at oracle.com wrote:
>>
>> --Semyon
>>
>>
>> On 6/3/19 5:16 PM, Sergey Bylokhov wrote:
>>> Hello.
>>> Please review the fix for JDK 13.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8225144
>>> Fix: http://cr.openjdk.java.net/~serb/8225144/webrev.00
>>>
>>> This bug is a version of JDK-6361367[1] but this time for Aqua L&F.
>>>
>>> In JTextFields and JTextAreas when pressing with backspace and shift 
>>> nothing happens,
>>> but the native programs delete under these circumstances.
>>>
>>> In the fix in the Aqua L&F, the key binding for "shift+backspace" is 
>>> added, actually, it means that shift in this shortcut will be 
>>> ignored and simple backspace action will be executed.
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-6361367
>>>
>>
>
>


From prasanta.sadhukhan at oracle.com  Thu Jun  6 07:29:26 2019
From: prasanta.sadhukhan at oracle.com (Prasanta Sadhukhan)
Date: Thu, 6 Jun 2019 12:59:26 +0530
Subject: <Swing Dev> <AWT Dev> [13] RFR 8153090 8223788 8224149: TAB key
 cannot change input focus after the radio button in the Color Selection
 dialog.+
In-Reply-To: <74e3a9b1-b001-28e7-a51a-738f0ab5cfbd@oracle.com>
References: <783fc182-de41-96d1-b0fd-93cdd6dc16a6@oracle.com>
 <5CE2EC30.1040304@oracle.com>
 <3b55845d-a885-cacd-f995-63680846cb0c@oracle.com>
 <65ee59fe-118e-a7e5-b957-95d48d8c84e9@oracle.com>
 <74e3a9b1-b001-28e7-a51a-738f0ab5cfbd@oracle.com>
Message-ID: <43165ce4-b2e7-9982-b8a9-3d0c285415e7@oracle.com>

Hi Semyon,

I do not have much idea of focus traversal code but it seems when your 
regression testcase is run, SwingContainerOrderFocusTraversalPolicy does 
get called as I can see, so I see no harm in putting the code there, 
given Phil's objection.

Regards
Prasanta
On 23-May-19 3:46 AM, semyon.sadetsky at oracle.com wrote:
> On 5/20/19 11:48 PM, Prasanta Sadhukhan wrote:
>
>> Probably we can move this traversal code to 
>> javax.swing.SortingFocusTraversalPolicy#SwingContainerOrderFocusTraversalPolicy 
>> for this JToggleButton swing component to avoid this scepticism.
> Hi Prasanta,
> We cannot move it there because it'd not be called when 
> ContainerOrderFocusTraversalPolicy is used.
> --Semyon
>>
>> Regards
>> Prasanta
>> On 21-May-19 1:36 AM, semyon.sadetsky at oracle.com wrote:
>>> On 5/20/19 11:04 AM, Philip Race wrote:
>>>
>>>> Hi,
>>>>
>>>> I'm afraid I know next to nothing about the focus traversal
>>>> code in Swing or AWT, but it smells very wrong to have
>>>> such knowledge of a specific Swing component in the
>>>> AWT focus code.
>>> I don't see anything wrong here. You can find a lot of Swing 
>>> component specific code in java.awt.* implementations. This is not 
>>> the first Swing aware AWT class.
>>>
>>> --Semyon
>>>>
>>>> -phil.
>>>>
>>>> On 5/20/19, 8:37 AM, semyon.sadetsky at oracle.com wrote:
>>>>> bugs:
>>>>>
>>>>> https://bugs.openjdk.java.net/browse/JDK-8153090
>>>>>
>>>>> https://bugs.openjdk.java.net/browse/JDK-8223788
>>>>>
>>>>> https://bugs.openjdk.java.net/browse/JDK-8224149
>>>>>
>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8153090/webrev.00/
>>>>>
>>>>> The fix eliminates issues in JColorChooser dialog making it more 
>>>>> accessible by keyboard. See JBS for details.
>>>>>
>>>>> --Semyon
>>>>>
>>>
>>
>


From semyon.sadetsky at oracle.com  Thu Jun  6 15:32:25 2019
From: semyon.sadetsky at oracle.com (semyon.sadetsky at oracle.com)
Date: Thu, 6 Jun 2019 08:32:25 -0700
Subject: <Swing Dev> <AWT Dev> [13] RFR 8153090 8223788 8224149: TAB key
 cannot change input focus after the radio button in the Color Selection
 dialog.+
In-Reply-To: <43165ce4-b2e7-9982-b8a9-3d0c285415e7@oracle.com>
References: <783fc182-de41-96d1-b0fd-93cdd6dc16a6@oracle.com>
 <5CE2EC30.1040304@oracle.com>
 <3b55845d-a885-cacd-f995-63680846cb0c@oracle.com>
 <65ee59fe-118e-a7e5-b957-95d48d8c84e9@oracle.com>
 <74e3a9b1-b001-28e7-a51a-738f0ab5cfbd@oracle.com>
 <43165ce4-b2e7-9982-b8a9-3d0c285415e7@oracle.com>
Message-ID: <4dd305e3-1220-3d01-2625-e0c25ae26cab@oracle.com>

On 6/6/19 12:29 AM, Prasanta Sadhukhan wrote:

> Hi Semyon,
>
> I do not have much idea of focus traversal code but it seems when your 
> regression testcase is run, SwingContainerOrderFocusTraversalPolicy 
> does get called as I can see, so I see no harm in putting the code 
> there, given Phil's objection.
You see it called in the color panel or for other container?

--Semyon
>
> Regards
> Prasanta
> On 23-May-19 3:46 AM, semyon.sadetsky at oracle.com wrote:
>> On 5/20/19 11:48 PM, Prasanta Sadhukhan wrote:
>>
>>> Probably we can move this traversal code to 
>>> javax.swing.SortingFocusTraversalPolicy#SwingContainerOrderFocusTraversalPolicy 
>>> for this JToggleButton swing component to avoid this scepticism.
>> Hi Prasanta,
>> We cannot move it there because it'd not be called when 
>> ContainerOrderFocusTraversalPolicy is used.
>> --Semyon
>>>
>>> Regards
>>> Prasanta
>>> On 21-May-19 1:36 AM, semyon.sadetsky at oracle.com wrote:
>>>> On 5/20/19 11:04 AM, Philip Race wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I'm afraid I know next to nothing about the focus traversal
>>>>> code in Swing or AWT, but it smells very wrong to have
>>>>> such knowledge of a specific Swing component in the
>>>>> AWT focus code.
>>>> I don't see anything wrong here. You can find a lot of Swing 
>>>> component specific code in java.awt.* implementations. This is not 
>>>> the first Swing aware AWT class.
>>>>
>>>> --Semyon
>>>>>
>>>>> -phil.
>>>>>
>>>>> On 5/20/19, 8:37 AM, semyon.sadetsky at oracle.com wrote:
>>>>>> bugs:
>>>>>>
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8153090
>>>>>>
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8223788
>>>>>>
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8224149
>>>>>>
>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8153090/webrev.00/
>>>>>>
>>>>>> The fix eliminates issues in JColorChooser dialog making it more 
>>>>>> accessible by keyboard. See JBS for details.
>>>>>>
>>>>>> --Semyon
>>>>>>
>>>>
>>>
>>
>


From prasanta.sadhukhan at oracle.com  Thu Jun  6 15:34:40 2019
From: prasanta.sadhukhan at oracle.com (Prasanta Sadhukhan)
Date: Thu, 6 Jun 2019 21:04:40 +0530
Subject: <Swing Dev> <AWT Dev> [13] RFR 8153090 8223788 8224149: TAB key
 cannot change input focus after the radio button in the Color Selection
 dialog.+
In-Reply-To: <4dd305e3-1220-3d01-2625-e0c25ae26cab@oracle.com>
References: <783fc182-de41-96d1-b0fd-93cdd6dc16a6@oracle.com>
 <5CE2EC30.1040304@oracle.com>
 <3b55845d-a885-cacd-f995-63680846cb0c@oracle.com>
 <65ee59fe-118e-a7e5-b957-95d48d8c84e9@oracle.com>
 <74e3a9b1-b001-28e7-a51a-738f0ab5cfbd@oracle.com>
 <43165ce4-b2e7-9982-b8a9-3d0c285415e7@oracle.com>
 <4dd305e3-1220-3d01-2625-e0c25ae26cab@oracle.com>
Message-ID: <f722956b-0cb5-3628-4dfb-93c614dc2946@oracle.com>



On 06-Jun-19 9:02 PM, semyon.sadetsky at oracle.com wrote:
> On 6/6/19 12:29 AM, Prasanta Sadhukhan wrote:
>
>> Hi Semyon,
>>
>> I do not have much idea of focus traversal code but it seems when 
>> your regression testcase is run, 
>> SwingContainerOrderFocusTraversalPolicy does get called as I can see, 
>> so I see no harm in putting the code there, given Phil's objection.
> You see it called in the color panel or for other container?
>
I did not see from where it is called but I had a print in accept() of 
SwingContainerOrderFocusTraversalPolicy which was getting called when I 
ran the testcase.

Regards
Prasanta
> --Semyon
>>
>> Regards
>> Prasanta
>> On 23-May-19 3:46 AM, semyon.sadetsky at oracle.com wrote:
>>> On 5/20/19 11:48 PM, Prasanta Sadhukhan wrote:
>>>
>>>> Probably we can move this traversal code to 
>>>> javax.swing.SortingFocusTraversalPolicy#SwingContainerOrderFocusTraversalPolicy 
>>>> for this JToggleButton swing component to avoid this scepticism.
>>> Hi Prasanta,
>>> We cannot move it there because it'd not be called when 
>>> ContainerOrderFocusTraversalPolicy is used.
>>> --Semyon
>>>>
>>>> Regards
>>>> Prasanta
>>>> On 21-May-19 1:36 AM, semyon.sadetsky at oracle.com wrote:
>>>>> On 5/20/19 11:04 AM, Philip Race wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I'm afraid I know next to nothing about the focus traversal
>>>>>> code in Swing or AWT, but it smells very wrong to have
>>>>>> such knowledge of a specific Swing component in the
>>>>>> AWT focus code.
>>>>> I don't see anything wrong here. You can find a lot of Swing 
>>>>> component specific code in java.awt.* implementations. This is not 
>>>>> the first Swing aware AWT class.
>>>>>
>>>>> --Semyon
>>>>>>
>>>>>> -phil.
>>>>>>
>>>>>> On 5/20/19, 8:37 AM, semyon.sadetsky at oracle.com wrote:
>>>>>>> bugs:
>>>>>>>
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8153090
>>>>>>>
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8223788
>>>>>>>
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8224149
>>>>>>>
>>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8153090/webrev.00/
>>>>>>>
>>>>>>> The fix eliminates issues in JColorChooser dialog making it more 
>>>>>>> accessible by keyboard. See JBS for details.
>>>>>>>
>>>>>>> --Semyon
>>>>>>>
>>>>>
>>>>
>>>
>>
>


From prasanta.sadhukhan at oracle.com  Mon Jun 10 10:13:46 2019
From: prasanta.sadhukhan at oracle.com (Prasanta Sadhukhan)
Date: Mon, 10 Jun 2019 15:43:46 +0530
Subject: <Swing Dev> [13] RFR
 JDK-8225511:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedTranslucentPerPixelTranslucentGradient.java
 fails in linux-x64
In-Reply-To: <a91fcff9-ab69-7d58-b7e0-bf09e907dec9@oracle.com>
References: <d6589c20-d38b-bc50-2220-5d5ceb3fa3de@oracle.com>
 <5b9179d9-220e-9838-0454-cc84592fd093@oracle.com>
 <85251886-7ba3-f74f-2408-6e4e21c647ff@oracle.com>
 <eb95600b-ffaa-031c-b055-00384ec41783@oracle.com>
 <464b8b02-e182-4967-bd84-a3bf0ec4f635@default>
 <a91fcff9-ab69-7d58-b7e0-bf09e907dec9@oracle.com>
Message-ID: <e519e77d-26df-4990-be08-5af9ecdfa37b@oracle.com>

Hi All,

Similar to JDK-8224876 (as below), 
ShapedTranslucentPerPixelTranslucentGradient.java fails time to time on 
mach5 linux headful system, Proposed fix is similar to other one which 
is to add some more delay for translucent case too.

Bug: https://bugs.openjdk.java.net/browse/JDK-8225511

diff -r de1d2a535c08 
test/jdk/javax/swing/JWindow/ShapedAndTranslucentWindows/Common.java
--- 
a/test/jdk/javax/swing/JWindow/ShapedAndTranslucentWindows/Common.java 
Mon Jun 10 10:52:11 2019 +0530
+++ 
b/test/jdk/javax/swing/JWindow/ShapedAndTranslucentWindows/Common.java 
Mon Jun 10 15:37:58 2019 +0530
@@ -367,13 +367,13 @@
 ???????? // Drag
 ???????? Point location = window.getLocationOnScreen();
 ???????? robot.dragAndDrop(location.x + 30, location.y + 5, location.x 
+ dl + random.nextInt(dl), location.y + random.nextInt(dl));
-??????? robot.waitForIdle(delay);
+??????? robot.waitForIdle(2*delay);
 ???????? checkTranslucentShape();

 ???????? // Resize
 ???????? location = window.getLocationOnScreen();
 ???????? robot.dragAndDrop(location.x + 4, location.y + 4, location.x + 
random.nextInt(2*dl)-dl, location.y + random.nextInt(2*dl)-dl);
-??????? robot.waitForIdle(delay);
+??????? robot.waitForIdle(2*delay);
 ???????? checkTranslucentShape();

Regards
Prasanta
On 04-Jun-19 1:30 AM, Sergey Bylokhov wrote:
> Looks fine, I have checked it and looks like it can really? lag time 
> to time.
>
> On 03/06/2019 04:00, Jayathirth D V wrote:
>> Changes are fine but we should wait on Sergey's manual check of test 
>> in the system.
>>
>> Thanks,
>> Jay
>>
>> -----Original Message-----
>> From: Prasanta Sadhukhan
>> Sent: Monday, June 03, 2019 3:54 PM
>> To: Sergey Bylokhov; swing-dev at openjdk.java.net
>> Subject: Re: <Swing Dev> [13] RFR 
>> 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java 
>> fails on linux-x64
>>
>> Gentle reminder...
>>
>>
>> On 30-May-19 12:32 PM, Prasanta Sadhukhan wrote:
>>> I could not find anything amiss when I capture the screen output at
>>> the time of fail, so I decided to go to timeout increase route. I
>>> guess it is needed to check the test manually in that mach5 specific
>>> linux system to see what is happening.
>>>
>>> Regards
>>> Prasanta
>>> On 29-May-19 2:29 AM, Sergey Bylokhov wrote:
>>>> Hi, Prasanta.
>>>>
>>>> Isn't strange that 1 second is not enough to wait for redraw?
>>>> I'll reply soon after rechecking the test manually on this system.
>>>>
>>>> On 28/05/2019 04:01, Prasanta Sadhukhan wrote:
>>>>> Hi All,
>>>>>
>>>>> Please review a test-fix for an issue where the test check fails
>>>>> after the content of window is dragged & resized.
>>>>> Test is passing in local ubuntu18.04 system but is failing on mach5
>>>>> linux headful system as test check for pixels happens too quickly
>>>>> after window drag/resize.
>>>>> Increased delay between test drag&drop and check to make sure check
>>>>> happens after reasonable amount of time. Test now pass in all mach5
>>>>> systems.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224876
>>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8224876/webrev.0/
>>>>>
>>>>> Regards
>>>>> Prasanta
>>>>
>>>>
>>>
>>
>
>


From Sergey.Bylokhov at oracle.com  Mon Jun 10 18:52:28 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 10 Jun 2019 11:52:28 -0700
Subject: <Swing Dev> [13] RFR
 JDK-8225511:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedTranslucentPerPixelTranslucentGradient.java
 fails in linux-x64
In-Reply-To: <e519e77d-26df-4990-be08-5af9ecdfa37b@oracle.com>
References: <d6589c20-d38b-bc50-2220-5d5ceb3fa3de@oracle.com>
 <5b9179d9-220e-9838-0454-cc84592fd093@oracle.com>
 <85251886-7ba3-f74f-2408-6e4e21c647ff@oracle.com>
 <eb95600b-ffaa-031c-b055-00384ec41783@oracle.com>
 <464b8b02-e182-4967-bd84-a3bf0ec4f635@default>
 <a91fcff9-ab69-7d58-b7e0-bf09e907dec9@oracle.com>
 <e519e77d-26df-4990-be08-5af9ecdfa37b@oracle.com>
Message-ID: <5ed39006-b0b9-fb4c-8659-48988edbd980@oracle.com>

Looks fine.

On 10/06/2019 03:13, Prasanta Sadhukhan wrote:
> Hi All,
> 
> Similar to JDK-8224876 (as below), ShapedTranslucentPerPixelTranslucentGradient.java fails time to time on mach5 linux headful system, Proposed fix is similar to other one which is to add some more delay for translucent case too.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8225511
> 
> diff -r de1d2a535c08 test/jdk/javax/swing/JWindow/ShapedAndTranslucentWindows/Common.java
> --- a/test/jdk/javax/swing/JWindow/ShapedAndTranslucentWindows/Common.java Mon Jun 10 10:52:11 2019 +0530
> +++ b/test/jdk/javax/swing/JWindow/ShapedAndTranslucentWindows/Common.java Mon Jun 10 15:37:58 2019 +0530
> @@ -367,13 +367,13 @@
>  ???????? // Drag
>  ???????? Point location = window.getLocationOnScreen();
>  ???????? robot.dragAndDrop(location.x + 30, location.y + 5, location.x + dl + random.nextInt(dl), location.y + random.nextInt(dl));
> -??????? robot.waitForIdle(delay);
> +??????? robot.waitForIdle(2*delay);
>  ???????? checkTranslucentShape();
> 
>  ???????? // Resize
>  ???????? location = window.getLocationOnScreen();
>  ???????? robot.dragAndDrop(location.x + 4, location.y + 4, location.x + random.nextInt(2*dl)-dl, location.y + random.nextInt(2*dl)-dl);
> -??????? robot.waitForIdle(delay);
> +??????? robot.waitForIdle(2*delay);
>  ???????? checkTranslucentShape();
> 
> Regards
> Prasanta
> On 04-Jun-19 1:30 AM, Sergey Bylokhov wrote:
>> Looks fine, I have checked it and looks like it can really? lag time to time.
>>
>> On 03/06/2019 04:00, Jayathirth D V wrote:
>>> Changes are fine but we should wait on Sergey's manual check of test in the system.
>>>
>>> Thanks,
>>> Jay
>>>
>>> -----Original Message-----
>>> From: Prasanta Sadhukhan
>>> Sent: Monday, June 03, 2019 3:54 PM
>>> To: Sergey Bylokhov; swing-dev at openjdk.java.net
>>> Subject: Re: <Swing Dev> [13] RFR 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java fails on linux-x64
>>>
>>> Gentle reminder...
>>>
>>>
>>> On 30-May-19 12:32 PM, Prasanta Sadhukhan wrote:
>>>> I could not find anything amiss when I capture the screen output at
>>>> the time of fail, so I decided to go to timeout increase route. I
>>>> guess it is needed to check the test manually in that mach5 specific
>>>> linux system to see what is happening.
>>>>
>>>> Regards
>>>> Prasanta
>>>> On 29-May-19 2:29 AM, Sergey Bylokhov wrote:
>>>>> Hi, Prasanta.
>>>>>
>>>>> Isn't strange that 1 second is not enough to wait for redraw?
>>>>> I'll reply soon after rechecking the test manually on this system.
>>>>>
>>>>> On 28/05/2019 04:01, Prasanta Sadhukhan wrote:
>>>>>> Hi All,
>>>>>>
>>>>>> Please review a test-fix for an issue where the test check fails
>>>>>> after the content of window is dragged & resized.
>>>>>> Test is passing in local ubuntu18.04 system but is failing on mach5
>>>>>> linux headful system as test check for pixels happens too quickly
>>>>>> after window drag/resize.
>>>>>> Increased delay between test drag&drop and check to make sure check
>>>>>> happens after reasonable amount of time. Test now pass in all mach5
>>>>>> systems.
>>>>>>
>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224876
>>>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8224876/webrev.0/
>>>>>>
>>>>>> Regards
>>>>>> Prasanta
>>>>>
>>>>>
>>>>
>>>
>>
>>
> 


-- 
Best regards, Sergey.

From philip.race at oracle.com  Mon Jun 10 19:19:30 2019
From: philip.race at oracle.com (Phil Race)
Date: Mon, 10 Jun 2019 12:19:30 -0700
Subject: <Swing Dev> [13] RFR
 JDK-8225511:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedTranslucentPerPixelTranslucentGradient.java
 fails in linux-x64
In-Reply-To: <5ed39006-b0b9-fb4c-8659-48988edbd980@oracle.com>
References: <d6589c20-d38b-bc50-2220-5d5ceb3fa3de@oracle.com>
 <5b9179d9-220e-9838-0454-cc84592fd093@oracle.com>
 <85251886-7ba3-f74f-2408-6e4e21c647ff@oracle.com>
 <eb95600b-ffaa-031c-b055-00384ec41783@oracle.com>
 <464b8b02-e182-4967-bd84-a3bf0ec4f635@default>
 <a91fcff9-ab69-7d58-b7e0-bf09e907dec9@oracle.com>
 <e519e77d-26df-4990-be08-5af9ecdfa37b@oracle.com>
 <5ed39006-b0b9-fb4c-8659-48988edbd980@oracle.com>
Message-ID: <61b098c5-7e43-c927-226f-1398c79da47c@oracle.com>

+1

-phil.

On 6/10/19 11:52 AM, Sergey Bylokhov wrote:
> Looks fine.
>
> On 10/06/2019 03:13, Prasanta Sadhukhan wrote:
>> Hi All,
>>
>> Similar to JDK-8224876 (as below), 
>> ShapedTranslucentPerPixelTranslucentGradient.java fails time to time 
>> on mach5 linux headful system, Proposed fix is similar to other one 
>> which is to add some more delay for translucent case too.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8225511
>>
>> diff -r de1d2a535c08 
>> test/jdk/javax/swing/JWindow/ShapedAndTranslucentWindows/Common.java
>> --- 
>> a/test/jdk/javax/swing/JWindow/ShapedAndTranslucentWindows/Common.java 
>> Mon Jun 10 10:52:11 2019 +0530
>> +++ 
>> b/test/jdk/javax/swing/JWindow/ShapedAndTranslucentWindows/Common.java 
>> Mon Jun 10 15:37:58 2019 +0530
>> @@ -367,13 +367,13 @@
>> ????????? // Drag
>> ????????? Point location = window.getLocationOnScreen();
>> ????????? robot.dragAndDrop(location.x + 30, location.y + 5, 
>> location.x + dl + random.nextInt(dl), location.y + random.nextInt(dl));
>> -??????? robot.waitForIdle(delay);
>> +??????? robot.waitForIdle(2*delay);
>> ????????? checkTranslucentShape();
>>
>> ????????? // Resize
>> ????????? location = window.getLocationOnScreen();
>> ????????? robot.dragAndDrop(location.x + 4, location.y + 4, 
>> location.x + random.nextInt(2*dl)-dl, location.y + 
>> random.nextInt(2*dl)-dl);
>> -??????? robot.waitForIdle(delay);
>> +??????? robot.waitForIdle(2*delay);
>> ????????? checkTranslucentShape();
>>
>> Regards
>> Prasanta
>> On 04-Jun-19 1:30 AM, Sergey Bylokhov wrote:
>>> Looks fine, I have checked it and looks like it can really? lag time 
>>> to time.
>>>
>>> On 03/06/2019 04:00, Jayathirth D V wrote:
>>>> Changes are fine but we should wait on Sergey's manual check of 
>>>> test in the system.
>>>>
>>>> Thanks,
>>>> Jay
>>>>
>>>> -----Original Message-----
>>>> From: Prasanta Sadhukhan
>>>> Sent: Monday, June 03, 2019 3:54 PM
>>>> To: Sergey Bylokhov; swing-dev at openjdk.java.net
>>>> Subject: Re: <Swing Dev> [13] RFR 
>>>> 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java 
>>>> fails on linux-x64
>>>>
>>>> Gentle reminder...
>>>>
>>>>
>>>> On 30-May-19 12:32 PM, Prasanta Sadhukhan wrote:
>>>>> I could not find anything amiss when I capture the screen output at
>>>>> the time of fail, so I decided to go to timeout increase route. I
>>>>> guess it is needed to check the test manually in that mach5 specific
>>>>> linux system to see what is happening.
>>>>>
>>>>> Regards
>>>>> Prasanta
>>>>> On 29-May-19 2:29 AM, Sergey Bylokhov wrote:
>>>>>> Hi, Prasanta.
>>>>>>
>>>>>> Isn't strange that 1 second is not enough to wait for redraw?
>>>>>> I'll reply soon after rechecking the test manually on this system.
>>>>>>
>>>>>> On 28/05/2019 04:01, Prasanta Sadhukhan wrote:
>>>>>>> Hi All,
>>>>>>>
>>>>>>> Please review a test-fix for an issue where the test check fails
>>>>>>> after the content of window is dragged & resized.
>>>>>>> Test is passing in local ubuntu18.04 system but is failing on mach5
>>>>>>> linux headful system as test check for pixels happens too quickly
>>>>>>> after window drag/resize.
>>>>>>> Increased delay between test drag&drop and check to make sure check
>>>>>>> happens after reasonable amount of time. Test now pass in all mach5
>>>>>>> systems.
>>>>>>>
>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224876
>>>>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8224876/webrev.0/
>>>>>>>
>>>>>>> Regards
>>>>>>> Prasanta
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>


From Sergey.Bylokhov at oracle.com  Tue Jun 11 11:41:14 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 11 Jun 2019 04:41:14 -0700
Subject: <Swing Dev> [13] Review Request: 8225146 Accessibility issues in
 javax/swing/plaf/nimbus/doc-files/properties.html
Message-ID: <0f033f29-b4a8-9a1c-a66b-30eba2816601@oracle.com>

Hello.
Please review the fix for JDK 13.

Bug: https://bugs.openjdk.java.net/browse/JDK-8225146
Fix: http://cr.openjdk.java.net/~serb/8225146/webrev.01

Accessibility support was improved for "nimbus/doc-files/properties.html" file, the next changes were done:
  - I have renumbered old h1 tags to h2 and added one h1 tag, which contains the main title of the page
  - Each column now has scope="col" attribute
  - The content of the "Key" column was marked as row header, so "scope=row" was added to each related row
  - I made the caption of the table invisible since it mostly duplicates the text of the h2 header, but even invisible it will be used by the screen reader
  - Note that in each row in the "Preview" column I have added "aria-label="Color preview"", otherwise a11y validator complains about empty data cell

Old page:
http://cr.openjdk.java.net/~serb/8225146/webrev.01/raw_files/old/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html
New page:
http://cr.openjdk.java.net/~serb/8225146/webrev.01/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html

BTW probably this variant looks better? It uses default styles for the "th" tag for rows and contains "less code", personally I like it better:
http://cr.openjdk.java.net/~serb/8225146/webrev.00/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html
http://cr.openjdk.java.net/~serb/8225146/webrev.00

-- 
Best regards, Sergey.

From philip.race at oracle.com  Tue Jun 11 17:23:52 2019
From: philip.race at oracle.com (Phil Race)
Date: Tue, 11 Jun 2019 10:23:52 -0700
Subject: <Swing Dev> [13] RFR
 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java
 fails on linux-x64
In-Reply-To: <a91fcff9-ab69-7d58-b7e0-bf09e907dec9@oracle.com>
References: <d6589c20-d38b-bc50-2220-5d5ceb3fa3de@oracle.com>
 <5b9179d9-220e-9838-0454-cc84592fd093@oracle.com>
 <85251886-7ba3-f74f-2408-6e4e21c647ff@oracle.com>
 <eb95600b-ffaa-031c-b055-00384ec41783@oracle.com>
 <464b8b02-e182-4967-bd84-a3bf0ec4f635@default>
 <a91fcff9-ab69-7d58-b7e0-bf09e907dec9@oracle.com>
Message-ID: <10bc4bdd-43c1-24ff-f2fc-750335d2a742@oracle.com>

Prasanta,

This test still fails every day - and I do 
meanShapedPerPixelTranslucentGradient.java,
not the similarly named ShapedTranslucentPerPixelTranslucentGradient.java
which you just fixed yesterday.

-phil.

On 6/3/19 1:00 PM, Sergey Bylokhov wrote:
> Looks fine, I have checked it and looks like it can really? lag time 
> to time.
>
> On 03/06/2019 04:00, Jayathirth D V wrote:
>> Changes are fine but we should wait on Sergey's manual check of test 
>> in the system.
>>
>> Thanks,
>> Jay
>>
>> -----Original Message-----
>> From: Prasanta Sadhukhan
>> Sent: Monday, June 03, 2019 3:54 PM
>> To: Sergey Bylokhov; swing-dev at openjdk.java.net
>> Subject: Re: <Swing Dev> [13] RFR 
>> 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java 
>> fails on linux-x64
>>
>> Gentle reminder...
>>
>>
>> On 30-May-19 12:32 PM, Prasanta Sadhukhan wrote:
>>> I could not find anything amiss when I capture the screen output at
>>> the time of fail, so I decided to go to timeout increase route. I
>>> guess it is needed to check the test manually in that mach5 specific
>>> linux system to see what is happening.
>>>
>>> Regards
>>> Prasanta
>>> On 29-May-19 2:29 AM, Sergey Bylokhov wrote:
>>>> Hi, Prasanta.
>>>>
>>>> Isn't strange that 1 second is not enough to wait for redraw?
>>>> I'll reply soon after rechecking the test manually on this system.
>>>>
>>>> On 28/05/2019 04:01, Prasanta Sadhukhan wrote:
>>>>> Hi All,
>>>>>
>>>>> Please review a test-fix for an issue where the test check fails
>>>>> after the content of window is dragged & resized.
>>>>> Test is passing in local ubuntu18.04 system but is failing on mach5
>>>>> linux headful system as test check for pixels happens too quickly
>>>>> after window drag/resize.
>>>>> Increased delay between test drag&drop and check to make sure check
>>>>> happens after reasonable amount of time. Test now pass in all mach5
>>>>> systems.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224876
>>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8224876/webrev.0/
>>>>>
>>>>> Regards
>>>>> Prasanta
>>>>
>>>>
>>>
>>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190611/fb6150b5/attachment.html>

From alexey.ivanov at oracle.com  Tue Jun 11 21:11:19 2019
From: alexey.ivanov at oracle.com (Alexey Ivanov)
Date: Tue, 11 Jun 2019 22:11:19 +0100
Subject: <Swing Dev> [13] Review Request: 8225146 Accessibility issues
 in javax/swing/plaf/nimbus/doc-files/properties.html
In-Reply-To: <0f033f29-b4a8-9a1c-a66b-30eba2816601@oracle.com>
References: <0f033f29-b4a8-9a1c-a66b-30eba2816601@oracle.com>
Message-ID: <0afdc817-4c5a-77aa-1bfa-3aa176031464@oracle.com>

Hi Sergey,

Is style="font-weight:normal" necessary for each <th> inside <tbody>?
(The previous version defaulted to bold rendering.)
If yes, is it possible to add a stylesheet to handle this for the entire 
page?
<style type="text/css">
 ??? tbody th {
 ??????? font-weight: normal;
 ??? }
</style>


Should the title of the page use title capitalization?
In this case, ?Used? should be capitalized; at the same time ?and? 
should be lower-case. Thus the title would be ?Colors Used in Nimbus 
Look and Feel?.

?How to Set the Look and Feel? [1] article in the Java Tutorials follows 
this capitalization style.

Regards,
Alexey

[1] https://docs.oracle.com/javase/tutorial/uiswing/lookandfeel/plaf.html

On 11/06/2019 12:41, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for JDK 13.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8225146
> Fix: http://cr.openjdk.java.net/~serb/8225146/webrev.01
>
> Accessibility support was improved for 
> "nimbus/doc-files/properties.html" file, the next changes were done:
> ?- I have renumbered old h1 tags to h2 and added one h1 tag, which 
> contains the main title of the page
> ?- Each column now has scope="col" attribute
> ?- The content of the "Key" column was marked as row header, so 
> "scope=row" was added to each related row
> ?- I made the caption of the table invisible since it mostly 
> duplicates the text of the h2 header, but even invisible it will be 
> used by the screen reader
> ?- Note that in each row in the "Preview" column I have added 
> "aria-label="Color preview"", otherwise a11y validator complains about 
> empty data cell
>
> Old page:
> http://cr.openjdk.java.net/~serb/8225146/webrev.01/raw_files/old/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html 
>
> New page:
> http://cr.openjdk.java.net/~serb/8225146/webrev.01/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html 
>
>
> BTW probably this variant looks better? It uses default styles for the 
> "th" tag for rows and contains "less code", personally I like it better:
> http://cr.openjdk.java.net/~serb/8225146/webrev.00/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html 
>
> http://cr.openjdk.java.net/~serb/8225146/webrev.00
>


From Sergey.Bylokhov at oracle.com  Tue Jun 11 21:26:25 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 11 Jun 2019 14:26:25 -0700
Subject: <Swing Dev> [13] Review Request: 8225146 Accessibility issues
 in javax/swing/plaf/nimbus/doc-files/properties.html
In-Reply-To: <0afdc817-4c5a-77aa-1bfa-3aa176031464@oracle.com>
References: <0f033f29-b4a8-9a1c-a66b-30eba2816601@oracle.com>
 <0afdc817-4c5a-77aa-1bfa-3aa176031464@oracle.com>
Message-ID: <4e29c585-05f0-f86d-eb27-9f451dfcafab@oracle.com>

On 11/06/2019 14:11, Alexey Ivanov wrote:
> Is style="font-weight:normal" necessary for each <th> inside <tbody>?

I tried to set the style to tbody itself and it does not work, will check your suggestion below.

But before that, I would like to confirm that the "bold-version"(webrev.00) is not good enough?

> (The previous version defaulted to bold rendering.)
> If yes, is it possible to add a stylesheet to handle this for the entire page?
> <style type="text/css">
>  ??? tbody th {
>  ??????? font-weight: normal;
>  ??? }
> </style>
> 
> 
> Should the title of the page use title capitalization?
> In this case, ?Used? should be capitalized; at the same time ?and? should be lower-case. Thus the title would be ?Colors Used in Nimbus Look and Feel?.
> 
> ?How to Set the Look and Feel? [1] article in the Java Tutorials follows this capitalization style.
> 
> Regards,
> Alexey
> 
> [1] https://docs.oracle.com/javase/tutorial/uiswing/lookandfeel/plaf.html
> 
> On 11/06/2019 12:41, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for JDK 13.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8225146
>> Fix: http://cr.openjdk.java.net/~serb/8225146/webrev.01
>>
>> Accessibility support was improved for "nimbus/doc-files/properties.html" file, the next changes were done:
>> ?- I have renumbered old h1 tags to h2 and added one h1 tag, which contains the main title of the page
>> ?- Each column now has scope="col" attribute
>> ?- The content of the "Key" column was marked as row header, so "scope=row" was added to each related row
>> ?- I made the caption of the table invisible since it mostly duplicates the text of the h2 header, but even invisible it will be used by the screen reader
>> ?- Note that in each row in the "Preview" column I have added "aria-label="Color preview"", otherwise a11y validator complains about empty data cell
>>
>> Old page:
>> http://cr.openjdk.java.net/~serb/8225146/webrev.01/raw_files/old/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html
>> New page:
>> http://cr.openjdk.java.net/~serb/8225146/webrev.01/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html
>>
>> BTW probably this variant looks better? It uses default styles for the "th" tag for rows and contains "less code", personally I like it better:
>> http://cr.openjdk.java.net/~serb/8225146/webrev.00/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html
>> http://cr.openjdk.java.net/~serb/8225146/webrev.00
>>
> 


-- 
Best regards, Sergey.

From Sergey.Bylokhov at oracle.com  Tue Jun 11 21:40:59 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 11 Jun 2019 14:40:59 -0700
Subject: <Swing Dev> [13] Review Request: 8225146 Accessibility issues
 in javax/swing/plaf/nimbus/doc-files/properties.html
In-Reply-To: <4e29c585-05f0-f86d-eb27-9f451dfcafab@oracle.com>
References: <0f033f29-b4a8-9a1c-a66b-30eba2816601@oracle.com>
 <0afdc817-4c5a-77aa-1bfa-3aa176031464@oracle.com>
 <4e29c585-05f0-f86d-eb27-9f451dfcafab@oracle.com>
Message-ID: <7312a4de-4f44-bb27-3971-09b25e97724e@oracle.com>

On 11/06/2019 14:26, Sergey Bylokhov wrote:
>> Is style="font-weight:normal" necessary for each <th> inside <tbody>?

It works, thank you for suggestion:
http://cr.openjdk.java.net/~serb/8225146/webrev.02
http://cr.openjdk.java.net/~serb/8225146/webrev.02/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html


> 
> I tried to set the style to tbody itself and it does not work, will check your suggestion below.
> 
> But before that, I would like to confirm that the "bold-version"(webrev.00) is not good enough?
> 
>> (The previous version defaulted to bold rendering.)
>> If yes, is it possible to add a stylesheet to handle this for the entire page?
>> <style type="text/css">
>> ???? tbody th {
>> ???????? font-weight: normal;
>> ???? }
>> </style>
>>
>>
>> Should the title of the page use title capitalization?
>> In this case, ?Used? should be capitalized; at the same time ?and? should be lower-case. Thus the title would be ?Colors Used in Nimbus Look and Feel?.
>>
>> ?How to Set the Look and Feel? [1] article in the Java Tutorials follows this capitalization style.
>>
>> Regards,
>> Alexey
>>
>> [1] https://docs.oracle.com/javase/tutorial/uiswing/lookandfeel/plaf.html
>>
>> On 11/06/2019 12:41, Sergey Bylokhov wrote:
>>> Hello.
>>> Please review the fix for JDK 13.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8225146
>>> Fix: http://cr.openjdk.java.net/~serb/8225146/webrev.01
>>>
>>> Accessibility support was improved for "nimbus/doc-files/properties.html" file, the next changes were done:
>>> ?- I have renumbered old h1 tags to h2 and added one h1 tag, which contains the main title of the page
>>> ?- Each column now has scope="col" attribute
>>> ?- The content of the "Key" column was marked as row header, so "scope=row" was added to each related row
>>> ?- I made the caption of the table invisible since it mostly duplicates the text of the h2 header, but even invisible it will be used by the screen reader
>>> ?- Note that in each row in the "Preview" column I have added "aria-label="Color preview"", otherwise a11y validator complains about empty data cell
>>>
>>> Old page:
>>> http://cr.openjdk.java.net/~serb/8225146/webrev.01/raw_files/old/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html
>>> New page:
>>> http://cr.openjdk.java.net/~serb/8225146/webrev.01/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html
>>>
>>> BTW probably this variant looks better? It uses default styles for the "th" tag for rows and contains "less code", personally I like it better:
>>> http://cr.openjdk.java.net/~serb/8225146/webrev.00/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html
>>> http://cr.openjdk.java.net/~serb/8225146/webrev.00
>>>
>>
> 
> 


-- 
Best regards, Sergey.

From alexey.ivanov at oracle.com  Tue Jun 11 21:43:01 2019
From: alexey.ivanov at oracle.com (Alexey Ivanov)
Date: Tue, 11 Jun 2019 22:43:01 +0100
Subject: <Swing Dev> [13] Review Request: 8225146 Accessibility issues
 in javax/swing/plaf/nimbus/doc-files/properties.html
In-Reply-To: <4e29c585-05f0-f86d-eb27-9f451dfcafab@oracle.com>
References: <0f033f29-b4a8-9a1c-a66b-30eba2816601@oracle.com>
 <0afdc817-4c5a-77aa-1bfa-3aa176031464@oracle.com>
 <4e29c585-05f0-f86d-eb27-9f451dfcafab@oracle.com>
Message-ID: <d7881e79-f523-f3da-83b4-543da6d522ad@oracle.com>

On 11/06/2019 22:26, Sergey Bylokhov wrote:
> On 11/06/2019 14:11, Alexey Ivanov wrote:
>> Is style="font-weight:normal" necessary for each <th> inside <tbody>?
>
> I tried to set the style to tbody itself and it does not work, will 
> check your suggestion below.
>
> But before that, I would like to confirm that the 
> "bold-version"(webrev.00) is not good enough?

To my personal taste, it looks good.
So I'd drop this style attribute from <th>.

Yet I'd leave <tbody style="text-align:left"> to make <th> left-aligned. 
I find it easier to scan for keys this way.


Regards,
Alexey

>> (The previous version defaulted to bold rendering.)
>> If yes, is it possible to add a stylesheet to handle this for the 
>> entire page?
>> <style type="text/css">
>> ???? tbody th {
>> ???????? font-weight: normal;
>> ???? }
>> </style>
>>
>>
>> Should the title of the page use title capitalization?
>> In this case, ?Used? should be capitalized; at the same time ?and? 
>> should be lower-case. Thus the title would be ?Colors Used in Nimbus 
>> Look and Feel?.
>>
>> ?How to Set the Look and Feel? [1] article in the Java Tutorials 
>> follows this capitalization style.
>>
>> Regards,
>> Alexey
>>
>> [1] 
>> https://docs.oracle.com/javase/tutorial/uiswing/lookandfeel/plaf.html
>>
>> On 11/06/2019 12:41, Sergey Bylokhov wrote:
>>> Hello.
>>> Please review the fix for JDK 13.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8225146
>>> Fix: http://cr.openjdk.java.net/~serb/8225146/webrev.01
>>>
>>> Accessibility support was improved for 
>>> "nimbus/doc-files/properties.html" file, the next changes were done:
>>> ?- I have renumbered old h1 tags to h2 and added one h1 tag, which 
>>> contains the main title of the page
>>> ?- Each column now has scope="col" attribute
>>> ?- The content of the "Key" column was marked as row header, so 
>>> "scope=row" was added to each related row
>>> ?- I made the caption of the table invisible since it mostly 
>>> duplicates the text of the h2 header, but even invisible it will be 
>>> used by the screen reader
>>> ?- Note that in each row in the "Preview" column I have added 
>>> "aria-label="Color preview"", otherwise a11y validator complains 
>>> about empty data cell
>>>
>>> Old page:
>>> http://cr.openjdk.java.net/~serb/8225146/webrev.01/raw_files/old/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html 
>>>
>>> New page:
>>> http://cr.openjdk.java.net/~serb/8225146/webrev.01/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html 
>>>
>>>
>>> BTW probably this variant looks better? It uses default styles for 
>>> the "th" tag for rows and contains "less code", personally I like it 
>>> better:
>>> http://cr.openjdk.java.net/~serb/8225146/webrev.00/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html 
>>>
>>> http://cr.openjdk.java.net/~serb/8225146/webrev.00

From Sergey.Bylokhov at oracle.com  Wed Jun 12 05:29:41 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 11 Jun 2019 22:29:41 -0700
Subject: <Swing Dev> [13] Review Request: 8225372 accessibility errors in
 tables in java.desktop files
Message-ID: <7a29ed58-906a-7048-07e1-04e9fdbc0bca@oracle.com>

Hello.
Please review the fix for JDK 13.

Bug: https://bugs.openjdk.java.net/browse/JDK-8225372
Fix: http://cr.openjdk.java.net/~serb/8225372/webrev.00
Doc: http://cr.openjdk.java.net/~serb/8225372/docs/api/java.desktop/module-summary.html

In the fix, some(most) of the issues which were reported by the accessibility checker were fixed.

Changes description:

  - In the simplest case, the "scope=col/row" attribute was added to the tables:
      http://cr.openjdk.java.net/~serb/8225372/webrev.00/src/java.desktop/share/classes/javax/swing/plaf/synth/doc-files/componentProperties.html.sdiff.html

  - The tables which are used for a layout were replaced by the <div>.(In fact, this is just emulation of <figure>):
      http://cr.openjdk.java.net/~serb/8225372/webrev.00/src/java.desktop/share/classes/javax/swing/JScrollPane.java.sdiff.html

  - Some tables do not have the meaningful cell to be row header, so I have added an additional column "index" and use it cells as row header:
      http://cr.openjdk.java.net/~serb/8225372/webrev.00/src/java.desktop/share/classes/javax/imageio/metadata/doc-files/gif_metadata.html.sdiff.html

  - In one place I have added a special role to the table "role=presentation" because the table was used just for layout and its content can be read without information about this table:
      http://cr.openjdk.java.net/~serb/8225372/docs/api/java.desktop/java/awt/doc-files/Modality.html#Examples

  - In some cases I have dropped the table, and replace it by the list of elements:
      http://cr.openjdk.java.net/~serb/8225372/webrev.00/src/java.desktop/share/classes/javax/print/attribute/standard/Finishings.java.sdiff.html
      New: http://cr.openjdk.java.net/~serb/8225372/docs/api/java.desktop/javax/print/attribute/standard/Finishings.html
      Old: https://docs.oracle.com/en/java/javase/11/docs/api/java.desktop/javax/print/attribute/standard/Finishings.html

Note that I cannot fix two reported issues:
    Take a look to the "Common dialog" and "HTML Content of example above" on the links below:
      http://cr.openjdk.java.net/~serb/8225372/docs/api/java.desktop/javax/swing/JOptionPane.html
      http://cr.openjdk.java.net/~serb/8225372/docs/api/java.desktop/javax/swing/text/html/HTMLDocument.html

I tried to mark these tables as "role=presentation" or "aria-hidden=true", but it does not work because Javadoc tool generates HTML4 and these attributes are supported by the HTML5.

-- 
Best regards, Sergey.

From prasanta.sadhukhan at oracle.com  Wed Jun 12 06:20:28 2019
From: prasanta.sadhukhan at oracle.com (Prasanta Sadhukhan)
Date: Wed, 12 Jun 2019 11:50:28 +0530
Subject: <Swing Dev> [13] RFR
 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java
 fails on linux-x64
In-Reply-To: <10bc4bdd-43c1-24ff-f2fc-750335d2a742@oracle.com>
References: <d6589c20-d38b-bc50-2220-5d5ceb3fa3de@oracle.com>
 <5b9179d9-220e-9838-0454-cc84592fd093@oracle.com>
 <85251886-7ba3-f74f-2408-6e4e21c647ff@oracle.com>
 <eb95600b-ffaa-031c-b055-00384ec41783@oracle.com>
 <464b8b02-e182-4967-bd84-a3bf0ec4f635@default>
 <a91fcff9-ab69-7d58-b7e0-bf09e907dec9@oracle.com>
 <10bc4bdd-43c1-24ff-f2fc-750335d2a742@oracle.com>
Message-ID: <134a714c-58f2-25e7-8f84-eea16cbe166c@oracle.com>

Hi Phil,

This test does not fail in local ubuntu18.04 PIT system but only fails 
in the mach5 systems. I tried the test in mach5 system in standalone 
mode and I saw it was failing without my fix and passed after the 
increased delay, so I proposed the change and committed on 4th June and 
I can see this test pass on 5th June mach5 test results, but is again 
failing, not sure if it requires more delay or not, which may not be 
advisable as it might affect in other systems too. I also saw if I ran 
all the failed test in bunch, then this test passes.
I guess it requires someone to see what is happening while the test 
being run in that mach5 system.

Regards
Prasanta
On 11-Jun-19 10:53 PM, Phil Race wrote:
> Prasanta,
>
> This test still fails every day - and I do 
> meanShapedPerPixelTranslucentGradient.java,
> not the similarly named ShapedTranslucentPerPixelTranslucentGradient.java
> which you just fixed yesterday.
>
> -phil.
>
> On 6/3/19 1:00 PM, Sergey Bylokhov wrote:
>> Looks fine, I have checked it and looks like it can really? lag time 
>> to time.
>>
>> On 03/06/2019 04:00, Jayathirth D V wrote:
>>> Changes are fine but we should wait on Sergey's manual check of test 
>>> in the system.
>>>
>>> Thanks,
>>> Jay
>>>
>>> -----Original Message-----
>>> From: Prasanta Sadhukhan
>>> Sent: Monday, June 03, 2019 3:54 PM
>>> To: Sergey Bylokhov; swing-dev at openjdk.java.net
>>> Subject: Re: <Swing Dev> [13] RFR 
>>> 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java 
>>> fails on linux-x64
>>>
>>> Gentle reminder...
>>>
>>>
>>> On 30-May-19 12:32 PM, Prasanta Sadhukhan wrote:
>>>> I could not find anything amiss when I capture the screen output at
>>>> the time of fail, so I decided to go to timeout increase route. I
>>>> guess it is needed to check the test manually in that mach5 specific
>>>> linux system to see what is happening.
>>>>
>>>> Regards
>>>> Prasanta
>>>> On 29-May-19 2:29 AM, Sergey Bylokhov wrote:
>>>>> Hi, Prasanta.
>>>>>
>>>>> Isn't strange that 1 second is not enough to wait for redraw?
>>>>> I'll reply soon after rechecking the test manually on this system.
>>>>>
>>>>> On 28/05/2019 04:01, Prasanta Sadhukhan wrote:
>>>>>> Hi All,
>>>>>>
>>>>>> Please review a test-fix for an issue where the test check fails
>>>>>> after the content of window is dragged & resized.
>>>>>> Test is passing in local ubuntu18.04 system but is failing on mach5
>>>>>> linux headful system as test check for pixels happens too quickly
>>>>>> after window drag/resize.
>>>>>> Increased delay between test drag&drop and check to make sure check
>>>>>> happens after reasonable amount of time. Test now pass in all mach5
>>>>>> systems.
>>>>>>
>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224876
>>>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8224876/webrev.0/
>>>>>>
>>>>>> Regards
>>>>>> Prasanta
>>>>>
>>>>>
>>>>
>>>
>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190612/0ccaf03c/attachment.html>

From alexey.ivanov at oracle.com  Wed Jun 12 14:09:40 2019
From: alexey.ivanov at oracle.com (Alexey Ivanov)
Date: Wed, 12 Jun 2019 15:09:40 +0100
Subject: <Swing Dev> [13] Review Request: 8225146 Accessibility issues
 in javax/swing/plaf/nimbus/doc-files/properties.html
In-Reply-To: <7312a4de-4f44-bb27-3971-09b25e97724e@oracle.com>
References: <0f033f29-b4a8-9a1c-a66b-30eba2816601@oracle.com>
 <0afdc817-4c5a-77aa-1bfa-3aa176031464@oracle.com>
 <4e29c585-05f0-f86d-eb27-9f451dfcafab@oracle.com>
 <7312a4de-4f44-bb27-3971-09b25e97724e@oracle.com>
Message-ID: <7b9d8d85-9255-657a-c3bc-8dc1dfd65684@oracle.com>

On 11/06/2019 22:40, Sergey Bylokhov wrote:
> On 11/06/2019 14:26, Sergey Bylokhov wrote:
>>> Is style="font-weight:normal" necessary for each <th> inside <tbody>?
>
> It works, thank you for suggestion:
> http://cr.openjdk.java.net/~serb/8225146/webrev.02
> http://cr.openjdk.java.net/~serb/8225146/webrev.02/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html 
>

Looks good.

However, I'd prefer a more ?verbose? version of <style> element, I mean 
with added line-breaks and indents unless we're saving disk space.
I also wonder whether it's preserved intact after passing through javadoc.

I'd rather leave bold rendering for keys, I think it makes sense. Yet 
it's up to you to decide.

The <caption> element is optional. Does it make any difference to have 
one if it's hidden? With ?display: none? it will not be visible to 
assistive technologies such as screen reader, will it?


I'm still for lower-case ?and? in the page title and <h1>. But it's 
mostly nitpicking?

>> I tried to set the style to tbody itself and it does not work, will 
>> check your suggestion below.
>>
>> But before that, I would like to confirm that the 
>> "bold-version"(webrev.00) is not good enough?
>>
>>> (The previous version defaulted to bold rendering.)
>>> If yes, is it possible to add a stylesheet to handle this for the 
>>> entire page?
>>> <style type="text/css">
>>> ???? tbody th {
>>> ???????? font-weight: normal;
>>> ???? }
>>> </style>
>>>
>>>
>>> Should the title of the page use title capitalization?
>>> In this case, ?Used? should be capitalized; at the same time ?and? 
>>> should be lower-case. Thus the title would be ?Colors Used in Nimbus 
>>> Look and Feel?.
>>>
>>> ?How to Set the Look and Feel? [1] article in the Java Tutorials 
>>> follows this capitalization style.
>>>
>>> Regards,
>>> Alexey
>>>
>>> [1] 
>>> https://docs.oracle.com/javase/tutorial/uiswing/lookandfeel/plaf.html
>>>
>>> On 11/06/2019 12:41, Sergey Bylokhov wrote:
>>>> Hello.
>>>> Please review the fix for JDK 13.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8225146
>>>> Fix: http://cr.openjdk.java.net/~serb/8225146/webrev.01
>>>>
>>>> <SNIP>
-- 
Regards,
Alexey

From turbanoff at gmail.com  Fri Jun 14 09:35:43 2019
From: turbanoff at gmail.com (Andrey Turbanov)
Date: Fri, 14 Jun 2019 12:35:43 +0300
Subject: <Swing Dev> RFR: 6573239: Typo in jfc text file
Message-ID: <CAF+DQ5dFfCF4_ujJZDDd6neg0a5EhTAFFDQ7xq3Se29VzH5Pig@mail.gmail.com>

Hello.

I would like to contribute a small patch for bug:
https://bugs.openjdk.java.net/browse/JDK-6573239

Index: src/demo/share/jfc/SwingSet2/resources/tree.txt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- src/demo/share/jfc/SwingSet2/resources/tree.txt    (revision
dab3f5ab5c94975769e34b8139fe892a86085635)
+++ src/demo/share/jfc/SwingSet2/resources/tree.txt    (date 1560450025564)
@@ -8,7 +8,7 @@
 # A = Artist    / Composer
         #
 # R = Record    / Style
         #
 # S = Song Name / Composition
         #
-# C = Catagory
         #
+# C = Category
         #
 #
         #
 ################################################################################
 C Classical
Index: test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/resources/tree.txt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/resources/tree.txt
   (revision dab3f5ab5c94975769e34b8139fe892a86085635)
+++ test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/resources/tree.txt
   (date 1560450025589)
@@ -8,7 +8,7 @@
 # A = Artist    / Composer
         #
 # R = Record    / Style
         #
 # S = Song Name / Composition
         #
-# C = Catagory
         #
+# C = Category
         #
 #
         #
 ################################################################################
 C Classical
Index: test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/TreeDemo.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/TreeDemo.java
   (revision dab3f5ab5c94975769e34b8139fe892a86085635)
+++ test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/TreeDemo.java
   (date 1560450025588)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2007, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2007, 2019, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -83,7 +83,7 @@

     private JTree createTree() {
         DefaultMutableTreeNode top = new
DefaultMutableTreeNode(resourceManager.getString("TreeDemo.music"));
-        DefaultMutableTreeNode catagory = null;
+        DefaultMutableTreeNode category = null;
         DefaultMutableTreeNode artist = null;
         DefaultMutableTreeNode record = null;

@@ -103,12 +103,12 @@
                 char linetype = line.charAt(0);
                 switch (linetype) {
                     case 'C':
-                        catagory = new
DefaultMutableTreeNode(line.substring(2));
-                        top.add(catagory);
+                        category = new
DefaultMutableTreeNode(line.substring(2));
+                        top.add(category);
                         break;
                     case 'A':
-                        if (catagory != null) {
-                            catagory.add(artist = new
DefaultMutableTreeNode(line.substring(2)));
+                        if (category != null) {
+                            category.add(artist = new
DefaultMutableTreeNode(line.substring(2)));
                         }
                         break;
                     case 'R':
Index: src/demo/share/jfc/SwingSet2/TreeDemo.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- src/demo/share/jfc/SwingSet2/TreeDemo.java    (revision
dab3f5ab5c94975769e34b8139fe892a86085635)
+++ src/demo/share/jfc/SwingSet2/TreeDemo.java    (date 1560450025563)
@@ -1,6 +1,6 @@
 /*
  *
- * Copyright (c) 2007, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2007, 2019 Oracle and/or its affiliates. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -74,7 +74,7 @@

     public JScrollPane createTree() {
         DefaultMutableTreeNode top = new
DefaultMutableTreeNode(getString("TreeDemo.music"));
-        DefaultMutableTreeNode catagory = null ;
+        DefaultMutableTreeNode category = null;
         DefaultMutableTreeNode artist = null;
         DefaultMutableTreeNode record = null;

@@ -94,12 +94,12 @@
                 char linetype = line.charAt(0);
                 switch(linetype) {
                    case 'C':
-                     catagory = new DefaultMutableTreeNode(line.substring(2));
-                     top.add(catagory);
+                     category = new DefaultMutableTreeNode(line.substring(2));
+                     top.add(category);
                      break;
                    case 'A':
-                     if(catagory != null) {
-                         catagory.add(artist = new
DefaultMutableTreeNode(line.substring(2)));
+                     if(category != null) {
+                         category.add(artist = new
DefaultMutableTreeNode(line.substring(2)));
                      }
                      break;
                    case 'R':


Andrey Turbanov

From alexey.ivanov at oracle.com  Fri Jun 14 16:19:05 2019
From: alexey.ivanov at oracle.com (Alexey Ivanov)
Date: Fri, 14 Jun 2019 17:19:05 +0100
Subject: <Swing Dev> [13] Review Request: 8225372 accessibility errors
 in tables in java.desktop files
In-Reply-To: <7a29ed58-906a-7048-07e1-04e9fdbc0bca@oracle.com>
References: <7a29ed58-906a-7048-07e1-04e9fdbc0bca@oracle.com>
Message-ID: <00becf2b-b1e4-7937-4671-f829490ea200@oracle.com>

Hi Sergey,

*GridBagLayout.java*
Does it make sense to use nested lists for valid values?
It could make the presentation clearer rather than a paragraph followed 
by a list.

Line 125?
<ul>
 ??? <li>Absolute Values:
 ??????? <ul>
 ? ?? ?????? <li>{@code GridBagConstraints.NORTH}</li>
 ??????? </ul>
 ??? </li>
 ??? <li>Orientation Relative Values:
 ??????? <ul>
 ??????????? <li>{@code GridBagConstraints.PAGE_START}</li>
 ??????? </ul>
 ??? </li>
</ul>


Lines 187?191:
<div> seems to be redundant as well as ?<p>Baseline Layout? that comes 
from former <caption> element. I think a <p> would be enough:
<p style="text-align: center"><img src=?>
</p>
to replace the table.

The value ?center? is invalid for ?float? property in CSS, so it must be 
removed, including style attribute of <img> element.


*DesktopProperties.html*
I'm still unsure we should suppress rendering <th> in bold, should we not?


*Modality.html*
The table in examples could be replaced by a series of <ol style="float: 
left"> element with , followed by <p style="float: left"><img ...></p>
Then goes <div style="clear: left"></div>.
I would probably add titles to the examples to make the distinction 
between the examples clearer. If each example is preceded by <h3>Example 
#</h3>, then style="clear: left" can be applied to it.
If this sounds reasonable, I can file a new bug to handle this. This way 
we'll get rid of presentation table.


*NumericShaper.html*
The table has only one row group, so you have to add row groups:
117? * <tbody>
118? *?? <tr>
119? *???? <th scope="rowgroup" rowspan="2">Arabic
129? *???? <td>{@link NumericShaper.Range#EASTERN_ARABIC}
</tr>
</tbody>
<tbody>
130? *?? <tr>

<tbody> elements create the row group that will be associated with 
?Arabic? row group header.


*gif_metadata.html*
As you mention, some tables don't have meaningful row header. And it's 
not required in this case.
Adding the additional index column which does not make the table clearer 
does not make any sense to me. We already have column headers (yes, 
scope="col" should be added), and that resolves the missing header 
problem, doesn't it?

See ?Tables with one header? article in Web Accessibility Tutorial:
https://www.w3.org/WAI/tutorials/tables/one-header/#table-with-ambiguous-data


*tiff_metadata.html*
Compression type headers should be in <thead> (lines 516?518) and other 
table content in <tbody>

In case of Mapping the Standard Metadata Format to TIFF Native Image 
Metadata, the first column could probably be the row header. I'm not sure.

The extra row in this table, lines 869?872 could be removed completely.

*BoxLayout.java*
It would suggest more semantic mark-up for "Example" (lines 39?44):
<p><b>Example:</b>
<p><img ...>
instead of changing only text presentation by ?font-weight: bold? 
property on <div> element.
This is applicable to other similar cases.
<b> [1] has new semantics since HTML5; <strong> [2] can also be used, 
however, in this case this snipped does not represent anything of 
certain importance.

style attribute on <img> element has invalid value of ?bottom? for 
property ?float?, so it must be removed.

[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Element/b
[2] https://developer.mozilla.org/en-US/docs/Web/HTML/Element/strong


*componentProperties.html*
The same as DesktopProperties.html: should we suppress rendering <th> in 
bold?

JFileChooser, JInternalFrame, JInternalFrameTitlePane, JProgressBar, 
JSlider, JTabbedPane, Text Properties tables lack <thead> element around 
the header row. Because of the style applied, the header row is not 
rendered in bold. So suppressing bold rendering proved to be useful.

On 12/06/2019 06:29, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for JDK 13.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8225372
> Fix: http://cr.openjdk.java.net/~serb/8225372/webrev.00
> Doc: 
> http://cr.openjdk.java.net/~serb/8225372/docs/api/java.desktop/module-summary.html
>
> In the fix, some(most) of the issues which were reported by the 
> accessibility checker were fixed.
>
> Changes description:
>
> ?- In the simplest case, the "scope=col/row" attribute was added to 
> the tables:
> http://cr.openjdk.java.net/~serb/8225372/webrev.00/src/java.desktop/share/classes/javax/swing/plaf/synth/doc-files/componentProperties.html.sdiff.html
>
> ?- The tables which are used for a layout were replaced by the 
> <div>.(In fact, this is just emulation of <figure>):
> http://cr.openjdk.java.net/~serb/8225372/webrev.00/src/java.desktop/share/classes/javax/swing/JScrollPane.java.sdiff.html
>
> ?- Some tables do not have the meaningful cell to be row header, so I 
> have added an additional column "index" and use it cells as row header:
> http://cr.openjdk.java.net/~serb/8225372/webrev.00/src/java.desktop/share/classes/javax/imageio/metadata/doc-files/gif_metadata.html.sdiff.html
>
> ?- In one place I have added a special role to the table 
> "role=presentation" because the table was used just for layout and its 
> content can be read without information about this table:
> http://cr.openjdk.java.net/~serb/8225372/docs/api/java.desktop/java/awt/doc-files/Modality.html#Examples
>
> ?- In some cases I have dropped the table, and replace it by the list 
> of elements:
> http://cr.openjdk.java.net/~serb/8225372/webrev.00/src/java.desktop/share/classes/javax/print/attribute/standard/Finishings.java.sdiff.html
> ???? New: 
> http://cr.openjdk.java.net/~serb/8225372/docs/api/java.desktop/javax/print/attribute/standard/Finishings.html
> ???? Old: 
> https://docs.oracle.com/en/java/javase/11/docs/api/java.desktop/javax/print/attribute/standard/Finishings.html
>
> Note that I cannot fix two reported issues:
> ?? Take a look to the "Common dialog" and "HTML Content of example 
> above" on the links below:
> http://cr.openjdk.java.net/~serb/8225372/docs/api/java.desktop/javax/swing/JOptionPane.html
> http://cr.openjdk.java.net/~serb/8225372/docs/api/java.desktop/javax/swing/text/html/HTMLDocument.html
>
> I tried to mark these tables as "role=presentation" or 
> "aria-hidden=true", but it does not work because Javadoc tool 
> generates HTML4 and these attributes are supported by the HTML5.
>
-- 
Regards,
Alexey

From tejpal.rebari at oracle.com  Mon Jun 17 09:35:24 2019
From: tejpal.rebari at oracle.com (Tejpal Rebari)
Date: Mon, 17 Jun 2019 15:05:24 +0530
Subject: <Swing Dev> [13] RFR
 8196467:javax/swing/JInternalFrame/Test6325652.java fails
Message-ID: <A2AA2428-714B-4E6A-8E10-8D4CF10B7A21@oracle.com>

Hi All,
Please review a test fix for issue where test fails while restoring the iconified frame in linux platform, and fails while iconifying the frame in Mac platform.
Adding some delay after robot events solves the problem.
	1.Linux :  Test runs successfully.
	2.Mac   :	Test was failing while iconifying the frame .After adding the delay it passes this step but fails on another step when is tries to restore the iconified frame.This is because of a product bug in AquaLookAnd Feel where pressing control + F5 does not 				restore the iconified frame.A bug is reported for the same  : https://bugs.openjdk.java.net/browse/JDK-8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977>

Bug https://bugs.openjdk.java.net/browse/JDK-8160880 <https://bugs.openjdk.java.net/browse/JDK-8160880> will be automatically fixed once https://bugs.openjdk.java.net/browse/JDK-8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977> is fixed.

Bug  	:  https://bugs.openjdk.java.net/browse/JDK-8196467 <https://bugs.openjdk.java.net/browse/JDK-8196467>
webrev 	: http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev0/ <http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev0/>


Thanks and regards
Tejpal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190617/7ebc9320/attachment.html>

From prasanta.sadhukhan at oracle.com  Mon Jun 17 09:50:48 2019
From: prasanta.sadhukhan at oracle.com (Prasanta Sadhukhan)
Date: Mon, 17 Jun 2019 15:20:48 +0530
Subject: <Swing Dev> [13] RFR
 8196467:javax/swing/JInternalFrame/Test6325652.java fails
In-Reply-To: <A2AA2428-714B-4E6A-8E10-8D4CF10B7A21@oracle.com>
References: <A2AA2428-714B-4E6A-8E10-8D4CF10B7A21@oracle.com>
Message-ID: <0b4d9f0b-97cb-b186-2b7e-c449d1e913b1@oracle.com>

looks ok to me but I think ProblemList really should have 8224977 
<https://bugs.openjdk.java.net/browse/JDK-8224977> as the bug id which 
is the product issue.

Regards
Prasanta
On 17-Jun-19 3:05 PM, Tejpal Rebari wrote:
> Hi All,
> Please review a test fix for issue where test fails while restoring 
> the iconified frame in linux platform, and fails while iconifying the 
> frame in Mac platform.
> Adding some delay after robot events solves the problem.
> 1.Linux : ?Test runs successfully.
> 2.Mac ??:Test was failing while iconifying the frame .After adding the 
> delay it passes this step but fails on another step when is tries to 
> restore the iconified frame.This is because of a product bug in 
> AquaLookAnd Feel where pressing control + F5 does not restore the 
> iconified frame.A bug is reported for the same ?: 
> https://bugs.openjdk.java.net/browse/JDK-8224977
>
> Bug https://bugs.openjdk.java.net/browse/JDK-8160880?will be 
> automatically fixed once 
> https://bugs.openjdk.java.net/browse/JDK-8224977?is fixed.
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8196467
> webrev : http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev0/ 
> <http://cr.openjdk.java.net/%7Epkbalakr/Tejpal/8196467/webrev0/>
>
>
> Thanks and regards
> Tejpal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190617/a0184a3f/attachment.html>

From tejpal.rebari at oracle.com  Mon Jun 17 10:21:17 2019
From: tejpal.rebari at oracle.com (Tejpal Rebari)
Date: Mon, 17 Jun 2019 15:51:17 +0530
Subject: <Swing Dev> [13] RFR 8194048:Regression automated test
 '/open/test/jdk/javax/swing/text/DefaultCaret/HidingSelection/HidingSelectionTest.java'
 fails
Message-ID: <8B84159E-102F-47CC-9E26-D40625D975E9@oracle.com>

Hi All,
Please review a test-fix for JDK-8194048 where the test fails on windows 7 because, when selection ownership goes to second window the selection is still shown in first window.
In Windows and Mac platform when some text field is selected on second Window, the selected text in first Window remains selected, while clears in Linux Platform.

In Windows 10 and Mac the screenshot image of text field on first window after the some text is selected on second window, differ from the screenshot image of the same text field initially when there was only one window and the text field was selected ,(It differ in terms of colour) but it remains same in Windows 7. That's why the test is failing only on Windows 7.

Proposed solution is to check that the selected text field in first window should be shown selected after some text field is selected on second window in windows 7, 
while it should not be shown selected in other platform.

Bug		: https://bugs.openjdk.java.net/browse/JDK-8194048 <https://bugs.openjdk.java.net/browse/JDK-8194048>
webrev 	: http://cr.openjdk.java.net/~pkbalakr/Tejpal/8194048/webrev0/ <http://cr.openjdk.java.net/~pkbalakr/Tejpal/8194048/webrev0/>


Thanks and regards
Tejpal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190617/7e207a54/attachment.html>

From Sergey.Bylokhov at oracle.com  Tue Jun 18 19:30:21 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 18 Jun 2019 12:30:21 -0700
Subject: <Swing Dev> RFR: 6573239: Typo in jfc text file
In-Reply-To: <CAF+DQ5dFfCF4_ujJZDDd6neg0a5EhTAFFDQ7xq3Se29VzH5Pig@mail.gmail.com>
References: <CAF+DQ5dFfCF4_ujJZDDd6neg0a5EhTAFFDQ7xq3Se29VzH5Pig@mail.gmail.com>
Message-ID: <a5dca47a-9a5d-e11d-68e3-b34c08e7eaad@oracle.com>

Hi, Andrey

It looks like in one place the comma is missing after the 2019 year.
Can you please check the format of the patch, the content of "resources/tree.txt" looks shifted.

On 14/06/2019 02:35, Andrey Turbanov wrote:
> Hello.
> 
> I would like to contribute a small patch for bug:
> https://bugs.openjdk.java.net/browse/JDK-6573239
> 
> Index: src/demo/share/jfc/SwingSet2/resources/tree.txt
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===================================================================
> --- src/demo/share/jfc/SwingSet2/resources/tree.txt    (revision
> dab3f5ab5c94975769e34b8139fe892a86085635)
> +++ src/demo/share/jfc/SwingSet2/resources/tree.txt    (date 1560450025564)
> @@ -8,7 +8,7 @@
>   # A = Artist    / Composer
>           #
>   # R = Record    / Style
>           #
>   # S = Song Name / Composition
>           #
> -# C = Catagory
>           #
> +# C = Category
>           #
>   #
>           #
>   ################################################################################
>   C Classical
> Index: test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/resources/tree.txt
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===================================================================
> --- test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/resources/tree.txt
>     (revision dab3f5ab5c94975769e34b8139fe892a86085635)
> +++ test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/resources/tree.txt
>     (date 1560450025589)
> @@ -8,7 +8,7 @@
>   # A = Artist    / Composer
>           #
>   # R = Record    / Style
>           #
>   # S = Song Name / Composition
>           #
> -# C = Catagory
>           #
> +# C = Category
>           #
>   #
>           #
>   ################################################################################
>   C Classical
> Index: test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/TreeDemo.java
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===================================================================
> --- test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/TreeDemo.java
>     (revision dab3f5ab5c94975769e34b8139fe892a86085635)
> +++ test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/TreeDemo.java
>     (date 1560450025588)
> @@ -1,5 +1,5 @@
>   /*
> - * Copyright (c) 2007, 2016, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2007, 2019, Oracle and/or its affiliates. All rights reserved.
>    * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>    *
>    * This code is free software; you can redistribute it and/or modify it
> @@ -83,7 +83,7 @@
> 
>       private JTree createTree() {
>           DefaultMutableTreeNode top = new
> DefaultMutableTreeNode(resourceManager.getString("TreeDemo.music"));
> -        DefaultMutableTreeNode catagory = null;
> +        DefaultMutableTreeNode category = null;
>           DefaultMutableTreeNode artist = null;
>           DefaultMutableTreeNode record = null;
> 
> @@ -103,12 +103,12 @@
>                   char linetype = line.charAt(0);
>                   switch (linetype) {
>                       case 'C':
> -                        catagory = new
> DefaultMutableTreeNode(line.substring(2));
> -                        top.add(catagory);
> +                        category = new
> DefaultMutableTreeNode(line.substring(2));
> +                        top.add(category);
>                           break;
>                       case 'A':
> -                        if (catagory != null) {
> -                            catagory.add(artist = new
> DefaultMutableTreeNode(line.substring(2)));
> +                        if (category != null) {
> +                            category.add(artist = new
> DefaultMutableTreeNode(line.substring(2)));
>                           }
>                           break;
>                       case 'R':
> Index: src/demo/share/jfc/SwingSet2/TreeDemo.java
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===================================================================
> --- src/demo/share/jfc/SwingSet2/TreeDemo.java    (revision
> dab3f5ab5c94975769e34b8139fe892a86085635)
> +++ src/demo/share/jfc/SwingSet2/TreeDemo.java    (date 1560450025563)
> @@ -1,6 +1,6 @@
>   /*
>    *
> - * Copyright (c) 2007, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2007, 2019 Oracle and/or its affiliates. All rights reserved.
>    *
>    * Redistribution and use in source and binary forms, with or without
>    * modification, are permitted provided that the following conditions
> @@ -74,7 +74,7 @@
> 
>       public JScrollPane createTree() {
>           DefaultMutableTreeNode top = new
> DefaultMutableTreeNode(getString("TreeDemo.music"));
> -        DefaultMutableTreeNode catagory = null ;
> +        DefaultMutableTreeNode category = null;
>           DefaultMutableTreeNode artist = null;
>           DefaultMutableTreeNode record = null;
> 
> @@ -94,12 +94,12 @@
>                   char linetype = line.charAt(0);
>                   switch(linetype) {
>                      case 'C':
> -                     catagory = new DefaultMutableTreeNode(line.substring(2));
> -                     top.add(catagory);
> +                     category = new DefaultMutableTreeNode(line.substring(2));
> +                     top.add(category);
>                        break;
>                      case 'A':
> -                     if(catagory != null) {
> -                         catagory.add(artist = new
> DefaultMutableTreeNode(line.substring(2)));
> +                     if(category != null) {
> +                         category.add(artist = new
> DefaultMutableTreeNode(line.substring(2)));
>                        }
>                        break;
>                      case 'R':
> 
> 
> Andrey Turbanov
> 


-- 
Best regards, Sergey.

From turbanoff at gmail.com  Tue Jun 18 20:36:53 2019
From: turbanoff at gmail.com (Andrey Turbanov)
Date: Tue, 18 Jun 2019 23:36:53 +0300
Subject: <Swing Dev> RFR: 6573239: Typo in jfc text file
In-Reply-To: <a5dca47a-9a5d-e11d-68e3-b34c08e7eaad@oracle.com>
References: <CAF+DQ5dFfCF4_ujJZDDd6neg0a5EhTAFFDQ7xq3Se29VzH5Pig@mail.gmail.com>
 <a5dca47a-9a5d-e11d-68e3-b34c08e7eaad@oracle.com>
Message-ID: <CAF+DQ5cMMZ1OwzS_gU5vWOuj4VHaG85AJttZ0h1qw_PzYsMqAg@mail.gmail.com>

>It looks like in one place the comma is missing after the 2019 year.
You are right. Fixed.


https://bugs.openjdk.java.net/browse/JDK-6573239


Index: test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/resources/tree.txt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/resources/tree.txt
   (revision c80eb5ffe8a3c6db35b96849455bda7abcef1c0b)
+++ test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/resources/tree.txt
   (date 1560889924193)
@@ -8,7 +8,7 @@
 # A = Artist    / Composer
         #
 # R = Record    / Style
         #
 # S = Song Name / Composition
         #
-# C = Catagory
         #
+# C = Category
         #
 #
         #
 ################################################################################
 C Classical
Index: src/demo/share/jfc/SwingSet2/resources/tree.txt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- src/demo/share/jfc/SwingSet2/resources/tree.txt    (revision
c80eb5ffe8a3c6db35b96849455bda7abcef1c0b)
+++ src/demo/share/jfc/SwingSet2/resources/tree.txt    (date 1560889924154)
@@ -8,7 +8,7 @@
 # A = Artist    / Composer
         #
 # R = Record    / Style
         #
 # S = Song Name / Composition
         #
-# C = Catagory
         #
+# C = Category
         #
 #
         #
 ################################################################################
 C Classical
Index: test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/TreeDemo.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/TreeDemo.java
   (revision c80eb5ffe8a3c6db35b96849455bda7abcef1c0b)
+++ test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/TreeDemo.java
   (date 1560889924192)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2007, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2007, 2019, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -83,7 +83,7 @@

     private JTree createTree() {
         DefaultMutableTreeNode top = new
DefaultMutableTreeNode(resourceManager.getString("TreeDemo.music"));
-        DefaultMutableTreeNode catagory = null;
+        DefaultMutableTreeNode category = null;
         DefaultMutableTreeNode artist = null;
         DefaultMutableTreeNode record = null;

@@ -103,12 +103,12 @@
                 char linetype = line.charAt(0);
                 switch (linetype) {
                     case 'C':
-                        catagory = new
DefaultMutableTreeNode(line.substring(2));
-                        top.add(catagory);
+                        category = new
DefaultMutableTreeNode(line.substring(2));
+                        top.add(category);
                         break;
                     case 'A':
-                        if (catagory != null) {
-                            catagory.add(artist = new
DefaultMutableTreeNode(line.substring(2)));
+                        if (category != null) {
+                            category.add(artist = new
DefaultMutableTreeNode(line.substring(2)));
                         }
                         break;
                     case 'R':
Index: src/demo/share/jfc/SwingSet2/TreeDemo.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- src/demo/share/jfc/SwingSet2/TreeDemo.java    (revision
c80eb5ffe8a3c6db35b96849455bda7abcef1c0b)
+++ src/demo/share/jfc/SwingSet2/TreeDemo.java    (date 1560889969724)
@@ -1,6 +1,6 @@
 /*
  *
- * Copyright (c) 2007, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2007, 2019, Oracle and/or its affiliates. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -74,7 +74,7 @@

     public JScrollPane createTree() {
         DefaultMutableTreeNode top = new
DefaultMutableTreeNode(getString("TreeDemo.music"));
-        DefaultMutableTreeNode catagory = null ;
+        DefaultMutableTreeNode category = null;
         DefaultMutableTreeNode artist = null;
         DefaultMutableTreeNode record = null;

@@ -94,12 +94,12 @@
                 char linetype = line.charAt(0);
                 switch(linetype) {
                    case 'C':
-                     catagory = new DefaultMutableTreeNode(line.substring(2));
-                     top.add(catagory);
+                     category = new DefaultMutableTreeNode(line.substring(2));
+                     top.add(category);
                      break;
                    case 'A':
-                     if(catagory != null) {
-                         catagory.add(artist = new
DefaultMutableTreeNode(line.substring(2)));
+                     if(category != null) {
+                         category.add(artist = new
DefaultMutableTreeNode(line.substring(2)));
                      }
                      break;
                    case 'R':

From Sergey.Bylokhov at oracle.com  Tue Jun 18 21:53:37 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 18 Jun 2019 14:53:37 -0700
Subject: <Swing Dev> RFR: 6573239: Typo in jfc text file
In-Reply-To: <CAF+DQ5cMMZ1OwzS_gU5vWOuj4VHaG85AJttZ0h1qw_PzYsMqAg@mail.gmail.com>
References: <CAF+DQ5dFfCF4_ujJZDDd6neg0a5EhTAFFDQ7xq3Se29VzH5Pig@mail.gmail.com>
 <a5dca47a-9a5d-e11d-68e3-b34c08e7eaad@oracle.com>
 <CAF+DQ5cMMZ1OwzS_gU5vWOuj4VHaG85AJttZ0h1qw_PzYsMqAg@mail.gmail.com>
Message-ID: <59ff4e2d-2041-3439-abf0-8b829b632acc@oracle.com>

Hi, Andrey.

Take a look to the text in the patch below, it looks like a Gmail wrap the long lines in the plain text email(see the place of "#")

On 18/06/2019 13:36, Andrey Turbanov wrote:
> --- test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/resources/tree.txt
>     (revision c80eb5ffe8a3c6db35b96849455bda7abcef1c0b)
> +++ test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tree/resources/tree.txt
>     (date 1560889924193)
> @@ -8,7 +8,7 @@
>   # A = Artist    / Composer
>           #
>   # R = Record    / Style
>           #
>   # S = Song Name / Composition
>           #
> -# C = Catagory
>           #
> +# C = Category





-- 
Best regards, Sergey.

From tejpal.rebari at oracle.com  Wed Jun 19 08:47:41 2019
From: tejpal.rebari at oracle.com (Tejpal Rebari)
Date: Wed, 19 Jun 2019 14:17:41 +0530
Subject: <Swing Dev> [13] RFR
 8196467:javax/swing/JInternalFrame/Test6325652.java fails
In-Reply-To: <0b4d9f0b-97cb-b186-2b7e-c449d1e913b1@oracle.com>
References: <A2AA2428-714B-4E6A-8E10-8D4CF10B7A21@oracle.com>
 <0b4d9f0b-97cb-b186-2b7e-c449d1e913b1@oracle.com>
Message-ID: <0FB6CC95-C644-444B-BA98-DD82D6556DAB@oracle.com>

Hi All,
Changed the Bug Id In the ProblemList  to 8224977.
Updated webrev : http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev1/ <http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev1/>

Thanks and regards
Tejpal


> On 17-Jun-2019, at 3:20 PM, Prasanta Sadhukhan <prasanta.sadhukhan at oracle.com> wrote:
> 
> looks ok to me but I think ProblemList really should have 8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977> as the bug id which is the product issue.
> Regards
> Prasanta
> On 17-Jun-19 3:05 PM, Tejpal Rebari wrote:
>> Hi All,
>> Please review a test fix for issue where test fails while restoring the iconified frame in linux platform, and fails while iconifying the frame in Mac platform.
>> Adding some delay after robot events solves the problem.
>> 	1.Linux :  Test runs successfully.
>> 	2.Mac   :	Test was failing while iconifying the frame .After adding the delay it passes this step but fails on another step when is tries to restore the iconified frame.This is because of a product bug in AquaLookAnd Feel where pressing control + F5 does not 				restore the iconified frame.A bug is reported for the same  : https://bugs.openjdk.java.net/browse/JDK-8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977>
>> 
>> Bug https://bugs.openjdk.java.net/browse/JDK-8160880 <https://bugs.openjdk.java.net/browse/JDK-8160880> will be automatically fixed once https://bugs.openjdk.java.net/browse/JDK-8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977> is fixed.
>> 
>> Bug  	:  https://bugs.openjdk.java.net/browse/JDK-8196467 <https://bugs.openjdk.java.net/browse/JDK-8196467>
>> webrev 	: http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev0/ <http://cr.openjdk.java.net/%7Epkbalakr/Tejpal/8196467/webrev0/>
>> 
>> 
>> Thanks and regards
>> Tejpal
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190619/d5f539e2/attachment-0001.html>

From prasanta.sadhukhan at oracle.com  Wed Jun 19 09:10:34 2019
From: prasanta.sadhukhan at oracle.com (Prasanta Sadhukhan)
Date: Wed, 19 Jun 2019 14:40:34 +0530
Subject: <Swing Dev> [13] RFR
 8196467:javax/swing/JInternalFrame/Test6325652.java fails
In-Reply-To: <0FB6CC95-C644-444B-BA98-DD82D6556DAB@oracle.com>
References: <A2AA2428-714B-4E6A-8E10-8D4CF10B7A21@oracle.com>
 <0b4d9f0b-97cb-b186-2b7e-c449d1e913b1@oracle.com>
 <0FB6CC95-C644-444B-BA98-DD82D6556DAB@oracle.com>
Message-ID: <80c45edb-f9ee-fd3c-2a3b-03fcef378c98@oracle.com>

looks ok to me.

Regards
Prasanta
On 19-Jun-19 2:17 PM, Tejpal Rebari wrote:
> Hi All,
> Changed the Bug Id In the ProblemList ?to 8224977.
> Updated webrev : 
> http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev1/ 
> <http://cr.openjdk.java.net/%7Epkbalakr/Tejpal/8196467/webrev1/>
>
> Thanks and regards
> Tejpal
>
>
>> On 17-Jun-2019, at 3:20 PM, Prasanta Sadhukhan 
>> <prasanta.sadhukhan at oracle.com 
>> <mailto:prasanta.sadhukhan at oracle.com>> wrote:
>>
>> looks ok to me but I think ProblemList really should have 8224977 
>> <https://bugs.openjdk.java.net/browse/JDK-8224977> as the bug id 
>> which is the product issue.
>>
>> Regards
>> Prasanta
>> On 17-Jun-19 3:05 PM, Tejpal Rebari wrote:
>>> Hi All,
>>> Please review a test fix for issue where test fails while restoring 
>>> the iconified frame in linux platform, and fails while iconifying 
>>> the frame in Mac platform.
>>> Adding some delay after robot events solves the problem.
>>> 1.Linux : ?Test runs successfully.
>>> 2.Mac ??:Test was failing while iconifying the frame .After adding 
>>> the delay it passes this step but fails on another step when is 
>>> tries to restore the iconified frame.This is because of a product 
>>> bug in AquaLookAnd Feel where pressing control + F5 does not restore 
>>> the iconified frame.A bug is reported for the same ?: 
>>> https://bugs.openjdk.java.net/browse/JDK-8224977
>>>
>>> Bug https://bugs.openjdk.java.net/browse/JDK-8160880?will be 
>>> automatically fixed once 
>>> https://bugs.openjdk.java.net/browse/JDK-8224977?is fixed.
>>>
>>> Bug : https://bugs.openjdk.java.net/browse/JDK-8196467
>>> webrev : 
>>> http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev0/ 
>>> <http://cr.openjdk.java.net/%7Epkbalakr/Tejpal/8196467/webrev0/>
>>>
>>>
>>> Thanks and regards
>>> Tejpal
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190619/628bd8f0/attachment.html>

From jayathirth.d.v at oracle.com  Wed Jun 19 09:22:37 2019
From: jayathirth.d.v at oracle.com (Jayathirth Rao)
Date: Wed, 19 Jun 2019 14:52:37 +0530
Subject: <Swing Dev> [13] RFR
 8196467:javax/swing/JInternalFrame/Test6325652.java fails
In-Reply-To: <0FB6CC95-C644-444B-BA98-DD82D6556DAB@oracle.com>
References: <A2AA2428-714B-4E6A-8E10-8D4CF10B7A21@oracle.com>
 <0b4d9f0b-97cb-b186-2b7e-c449d1e913b1@oracle.com>
 <0FB6CC95-C644-444B-BA98-DD82D6556DAB@oracle.com>
Message-ID: <D1149C79-EB16-4DE4-B7A7-70A543F1F3AB@oracle.com>

Changes are fine.
Run the test in mach5 and see the behaviour for Ubuntu before pushing, as it is removed from problem list.

Thanks,
Jay

> On 19-Jun-2019, at 2:17 PM, Tejpal Rebari <tejpal.rebari at oracle.com> wrote:
> 
> Hi All,
> Changed the Bug Id In the ProblemList  to 8224977.
> Updated webrev : http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev1/ <http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev1/>
> 
> Thanks and regards
> Tejpal
> 
> 
>> On 17-Jun-2019, at 3:20 PM, Prasanta Sadhukhan <prasanta.sadhukhan at oracle.com <mailto:prasanta.sadhukhan at oracle.com>> wrote:
>> 
>> looks ok to me but I think ProblemList really should have 8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977> as the bug id which is the product issue.
>> Regards
>> Prasanta
>> On 17-Jun-19 3:05 PM, Tejpal Rebari wrote:
>>> Hi All,
>>> Please review a test fix for issue where test fails while restoring the iconified frame in linux platform, and fails while iconifying the frame in Mac platform.
>>> Adding some delay after robot events solves the problem.
>>> 	1.Linux :  Test runs successfully.
>>> 	2.Mac   :	Test was failing while iconifying the frame .After adding the delay it passes this step but fails on another step when is tries to restore the iconified frame.This is because of a product bug in AquaLookAnd Feel where pressing control + F5 does not 				restore the iconified frame.A bug is reported for the same  : https://bugs.openjdk.java.net/browse/JDK-8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977>
>>> 
>>> Bug https://bugs.openjdk.java.net/browse/JDK-8160880 <https://bugs.openjdk.java.net/browse/JDK-8160880> will be automatically fixed once https://bugs.openjdk.java.net/browse/JDK-8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977> is fixed.
>>> 
>>> Bug  	:  https://bugs.openjdk.java.net/browse/JDK-8196467 <https://bugs.openjdk.java.net/browse/JDK-8196467>
>>> webrev 	: http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev0/ <http://cr.openjdk.java.net/%7Epkbalakr/Tejpal/8196467/webrev0/>
>>> 
>>> 
>>> Thanks and regards
>>> Tejpal
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190619/344dc092/attachment.html>

From prasanta.sadhukhan at oracle.com  Wed Jun 19 09:28:16 2019
From: prasanta.sadhukhan at oracle.com (Prasanta Sadhukhan)
Date: Wed, 19 Jun 2019 14:58:16 +0530
Subject: <Swing Dev> [13] RFR 8194048:Regression automated test
 '/open/test/jdk/javax/swing/text/DefaultCaret/HidingSelection/HidingSelectionTest.java'
 fails
In-Reply-To: <8B84159E-102F-47CC-9E26-D40625D975E9@oracle.com>
References: <8B84159E-102F-47CC-9E26-D40625D975E9@oracle.com>
Message-ID: <e14b1f89-f2e8-91cf-410d-dbc20cf66a1b@oracle.com>

It seems from your explanation that, in windows 10(& mac) the text 
selection is "not" cleared in 1st window if another text is selected in 
2nd window BUT 1st window text selection is in "inactive" color(greyed) 
whereas 2nd window's text selection is in "active" color (bold black) as 
2nd window has focus.

But, in windows 7, both text selection in both window is in "active" 
color. Did you check in any native app whether the behaviour is same in 
windows 7 that 1st text remains active (but not cleared) even after 2nd 
window text is selected. If not, then probably there is a product bug in 
java for windows 7!!

Also, how native app behaves in windows 10?same as in java?

Regards
Prasanta
On 17-Jun-19 3:51 PM, Tejpal Rebari wrote:
> Hi All,
> Please review a test-fix for?JDK-8194048 where the test fails on 
> windows 7 because, when selection ownership goes to second window the 
> selection is still shown in first window.
> In Windows and Mac platform when some text field is selected on second 
> Window, the selected text in first Window remains selected, while 
> clears in Linux Platform.
>
> In Windows 10 and Mac the screenshot image of text field on first 
> window after the some text is selected on second window, differ from 
> the screenshot image of the same text field initially when there was 
> only one window and the text field was selected ,(It differ in terms 
> of colour) but it remains same in Windows 7. That's why the test is 
> failing only on Windows 7.
>
> Proposed solution is to check that the selected text field in first 
> window should be shown selected after some text field is selected on 
> second window *in windows 7,*
> while it should not be shown selected in other platform.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8194048
> webrev : http://cr.openjdk.java.net/~pkbalakr/Tejpal/8194048/webrev0/ 
> <http://cr.openjdk.java.net/%7Epkbalakr/Tejpal/8194048/webrev0/>
>
>
> Thanks and regards
> Tejpal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190619/da0b1725/attachment-0001.html>

From Sergey.Bylokhov at oracle.com  Thu Jun 20 00:00:50 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Wed, 19 Jun 2019 17:00:50 -0700
Subject: <Swing Dev> [13] Review Request: 8225146 Accessibility issues
 in javax/swing/plaf/nimbus/doc-files/properties.html
In-Reply-To: <7b9d8d85-9255-657a-c3bc-8dc1dfd65684@oracle.com>
References: <0f033f29-b4a8-9a1c-a66b-30eba2816601@oracle.com>
 <0afdc817-4c5a-77aa-1bfa-3aa176031464@oracle.com>
 <4e29c585-05f0-f86d-eb27-9f451dfcafab@oracle.com>
 <7312a4de-4f44-bb27-3971-09b25e97724e@oracle.com>
 <7b9d8d85-9255-657a-c3bc-8dc1dfd65684@oracle.com>
Message-ID: <8405dddc-ff02-d40d-bd78-2b789b7e6ebe@oracle.com>

On 12/06/2019 07:09, Alexey Ivanov wrote:
> However, I'd prefer a more ?verbose? version of <style> element, I mean with added line-breaks and indents unless we're saving disk space.
> I also wonder whether it's preserved intact after passing through javadoc.

I tried to save the space before the copyright header, and not to move it to the middle of the page.

> I'd rather leave bold rendering for keys, I think it makes sense. Yet it's up to you to decide.

Something like this?
http://cr.openjdk.java.net/~serb/8225146/webrev.03
http://cr.openjdk.java.net/~serb/8225146/webrev.03/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html

> 
> The <caption> element is optional. Does it make any difference to have one if it's hidden? With ?display: none? it will not be visible to assistive technologies such as screen reader, will it?

The "caption" tag is used across our javadocs because in most cases the content of the "caption" tag is a content of the "summary" tag which was deprecated in html5, I guess at some point we will need to migrate to "aria-label" or something like this.

> 
> 
> I'm still for lower-case ?and? in the page title and <h1>. But it's mostly nitpicking?
> 
>>> I tried to set the style to tbody itself and it does not work, will check your suggestion below.
>>>
>>> But before that, I would like to confirm that the "bold-version"(webrev.00) is not good enough?
>>>
>>>> (The previous version defaulted to bold rendering.)
>>>> If yes, is it possible to add a stylesheet to handle this for the entire page?
>>>> <style type="text/css">
>>>> ???? tbody th {
>>>> ???????? font-weight: normal;
>>>> ???? }
>>>> </style>
>>>>
>>>>
>>>> Should the title of the page use title capitalization?
>>>> In this case, ?Used? should be capitalized; at the same time ?and? should be lower-case. Thus the title would be ?Colors Used in Nimbus Look and Feel?.
>>>>
>>>> ?How to Set the Look and Feel? [1] article in the Java Tutorials follows this capitalization style.
>>>>
>>>> Regards,
>>>> Alexey
>>>>
>>>> [1] https://docs.oracle.com/javase/tutorial/uiswing/lookandfeel/plaf.html
>>>>
>>>> On 11/06/2019 12:41, Sergey Bylokhov wrote:
>>>>> Hello.
>>>>> Please review the fix for JDK 13.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8225146
>>>>> Fix: http://cr.openjdk.java.net/~serb/8225146/webrev.01
>>>>>
>>>>> <SNIP>


-- 
Best regards, Sergey.

From alexey.ivanov at oracle.com  Fri Jun 21 20:54:31 2019
From: alexey.ivanov at oracle.com (Alexey Ivanov)
Date: Fri, 21 Jun 2019 21:54:31 +0100
Subject: <Swing Dev> [13] Review Request: 8225146 Accessibility issues
 in javax/swing/plaf/nimbus/doc-files/properties.html
In-Reply-To: <8405dddc-ff02-d40d-bd78-2b789b7e6ebe@oracle.com>
References: <0f033f29-b4a8-9a1c-a66b-30eba2816601@oracle.com>
 <0afdc817-4c5a-77aa-1bfa-3aa176031464@oracle.com>
 <4e29c585-05f0-f86d-eb27-9f451dfcafab@oracle.com>
 <7312a4de-4f44-bb27-3971-09b25e97724e@oracle.com>
 <7b9d8d85-9255-657a-c3bc-8dc1dfd65684@oracle.com>
 <8405dddc-ff02-d40d-bd78-2b789b7e6ebe@oracle.com>
Message-ID: <52bad603-482d-5840-1a3d-7ec5fa874959@oracle.com>

On 20/06/2019 01:00, Sergey Bylokhov wrote:
> On 12/06/2019 07:09, Alexey Ivanov wrote:
> <SNIP>
>
>> I'd rather leave bold rendering for keys, I think it makes sense. Yet 
>> it's up to you to decide.
>
> Something like this?
> http://cr.openjdk.java.net/~serb/8225146/webrev.03
> http://cr.openjdk.java.net/~serb/8225146/webrev.03/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html 
>

Yes, looks good to me.

>> The <caption> element is optional. Does it make any difference to 
>> have one if it's hidden? With ?display: none? it will not be visible 
>> to assistive technologies such as screen reader, will it?
>
> The "caption" tag is used across our javadocs because in most cases 
> the content of the "caption" tag is a content of the "summary" tag 
> which was deprecated in html5, I guess at some point we will need to 
> migrate to "aria-label" or something like this.

Yeah, I understand that. And it makes sense where <caption> is visible.
In this case, <caption> element has ?display: none? style, thus it's 
invisible for visual browser users, and it's invisible for screen reader 
users as well. As such, we could drop <caption> element completely.

It's rather a concern for discussion?

>> <SNIP>
-- 
Regards,
Alexey

From jonathan.gibbons at oracle.com  Fri Jun 21 21:00:31 2019
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Fri, 21 Jun 2019 14:00:31 -0700
Subject: <Swing Dev> [13] Review Request: 8225146 Accessibility issues
 in javax/swing/plaf/nimbus/doc-files/properties.html
In-Reply-To: <52bad603-482d-5840-1a3d-7ec5fa874959@oracle.com>
References: <0f033f29-b4a8-9a1c-a66b-30eba2816601@oracle.com>
 <0afdc817-4c5a-77aa-1bfa-3aa176031464@oracle.com>
 <4e29c585-05f0-f86d-eb27-9f451dfcafab@oracle.com>
 <7312a4de-4f44-bb27-3971-09b25e97724e@oracle.com>
 <7b9d8d85-9255-657a-c3bc-8dc1dfd65684@oracle.com>
 <8405dddc-ff02-d40d-bd78-2b789b7e6ebe@oracle.com>
 <52bad603-482d-5840-1a3d-7ec5fa874959@oracle.com>
Message-ID: <2a74f0bb-d5ee-fe2f-8455-913ff15fd8e1@oracle.com>

"Invisible" captions need to be discussed for our documentation in general.

Although <caption> is optional for HTML 5, the accessibility guidelines 
that we follow require that we use it. We need to work to provide useful 
(and visible) captions on tables.

-- Jon


On 06/21/2019 01:54 PM, Alexey Ivanov wrote:
> On 20/06/2019 01:00, Sergey Bylokhov wrote:
>> On 12/06/2019 07:09, Alexey Ivanov wrote:
>> <SNIP>
>>
>>> I'd rather leave bold rendering for keys, I think it makes sense. 
>>> Yet it's up to you to decide.
>>
>> Something like this?
>> http://cr.openjdk.java.net/~serb/8225146/webrev.03
>> http://cr.openjdk.java.net/~serb/8225146/webrev.03/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html 
>>
>
> Yes, looks good to me.
>
>>> The <caption> element is optional. Does it make any difference to 
>>> have one if it's hidden? With ?display: none? it will not be visible 
>>> to assistive technologies such as screen reader, will it?
>>
>> The "caption" tag is used across our javadocs because in most cases 
>> the content of the "caption" tag is a content of the "summary" tag 
>> which was deprecated in html5, I guess at some point we will need to 
>> migrate to "aria-label" or something like this.
>
> Yeah, I understand that. And it makes sense where <caption> is visible.
> In this case, <caption> element has ?display: none? style, thus it's 
> invisible for visual browser users, and it's invisible for screen 
> reader users as well. As such, we could drop <caption> element 
> completely.
>
> It's rather a concern for discussion?
>
>>> <SNIP>


From tejpal.rebari at oracle.com  Mon Jun 24 06:50:37 2019
From: tejpal.rebari at oracle.com (Tejpal Rebari)
Date: Mon, 24 Jun 2019 12:20:37 +0530
Subject: <Swing Dev> [13] RFR
 8196467:javax/swing/JInternalFrame/Test6325652.java fails
In-Reply-To: <D1149C79-EB16-4DE4-B7A7-70A543F1F3AB@oracle.com>
References: <A2AA2428-714B-4E6A-8E10-8D4CF10B7A21@oracle.com>
 <0b4d9f0b-97cb-b186-2b7e-c449d1e913b1@oracle.com>
 <0FB6CC95-C644-444B-BA98-DD82D6556DAB@oracle.com>
 <D1149C79-EB16-4DE4-B7A7-70A543F1F3AB@oracle.com>
Message-ID: <0057D09B-D67D-493F-A2D8-652D13BD7E6E@oracle.com>

Hi All,
I ran the test in mach5 and test passed for Ubuntu and Windows.

Regards
Tejpal

> On 19-Jun-2019, at 2:52 PM, Jayathirth Rao <jayathirth.d.v at oracle.com> wrote:
> 
> Changes are fine.
> Run the test in mach5 and see the behaviour for Ubuntu before pushing, as it is removed from problem list.
> 
> Thanks,
> Jay
> 
>> On 19-Jun-2019, at 2:17 PM, Tejpal Rebari <tejpal.rebari at oracle.com <mailto:tejpal.rebari at oracle.com>> wrote:
>> 
>> Hi All,
>> Changed the Bug Id In the ProblemList  to 8224977.
>> Updated webrev : http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev1/ <http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev1/>
>> 
>> Thanks and regards
>> Tejpal
>> 
>> 
>>> On 17-Jun-2019, at 3:20 PM, Prasanta Sadhukhan <prasanta.sadhukhan at oracle.com <mailto:prasanta.sadhukhan at oracle.com>> wrote:
>>> 
>>> looks ok to me but I think ProblemList really should have 8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977> as the bug id which is the product issue.
>>> Regards
>>> Prasanta
>>> On 17-Jun-19 3:05 PM, Tejpal Rebari wrote:
>>>> Hi All,
>>>> Please review a test fix for issue where test fails while restoring the iconified frame in linux platform, and fails while iconifying the frame in Mac platform.
>>>> Adding some delay after robot events solves the problem.
>>>> 	1.Linux :  Test runs successfully.
>>>> 	2.Mac   :	Test was failing while iconifying the frame .After adding the delay it passes this step but fails on another step when is tries to restore the iconified frame.This is because of a product bug in AquaLookAnd Feel where pressing control + F5 does not 				restore the iconified frame.A bug is reported for the same  : https://bugs.openjdk.java.net/browse/JDK-8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977>
>>>> 
>>>> Bug https://bugs.openjdk.java.net/browse/JDK-8160880 <https://bugs.openjdk.java.net/browse/JDK-8160880> will be automatically fixed once https://bugs.openjdk.java.net/browse/JDK-8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977> is fixed.
>>>> 
>>>> Bug  	:  https://bugs.openjdk.java.net/browse/JDK-8196467 <https://bugs.openjdk.java.net/browse/JDK-8196467>
>>>> webrev 	: http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev0/ <http://cr.openjdk.java.net/%7Epkbalakr/Tejpal/8196467/webrev0/>
>>>> 
>>>> 
>>>> Thanks and regards
>>>> Tejpal
>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190624/3864db3d/attachment.html>

From jayathirth.d.v at oracle.com  Mon Jun 24 06:55:15 2019
From: jayathirth.d.v at oracle.com (Jayathirth Rao)
Date: Mon, 24 Jun 2019 12:25:15 +0530
Subject: <Swing Dev> [13] RFR
 8196467:javax/swing/JInternalFrame/Test6325652.java fails
In-Reply-To: <0057D09B-D67D-493F-A2D8-652D13BD7E6E@oracle.com>
References: <A2AA2428-714B-4E6A-8E10-8D4CF10B7A21@oracle.com>
 <0b4d9f0b-97cb-b186-2b7e-c449d1e913b1@oracle.com>
 <0FB6CC95-C644-444B-BA98-DD82D6556DAB@oracle.com>
 <D1149C79-EB16-4DE4-B7A7-70A543F1F3AB@oracle.com>
 <0057D09B-D67D-493F-A2D8-652D13BD7E6E@oracle.com>
Message-ID: <0304AA15-3964-4F01-84D4-D8F0CEC199EB@oracle.com>

Thanks for the update.

> On 24-Jun-2019, at 12:20 PM, Tejpal Rebari <tejpal.rebari at oracle.com> wrote:
> 
> Hi All,
> I ran the test in mach5 and test passed for Ubuntu and Windows.
> 
> Regards
> Tejpal
> 
>> On 19-Jun-2019, at 2:52 PM, Jayathirth Rao <jayathirth.d.v at oracle.com <mailto:jayathirth.d.v at oracle.com>> wrote:
>> 
>> Changes are fine.
>> Run the test in mach5 and see the behaviour for Ubuntu before pushing, as it is removed from problem list.
>> 
>> Thanks,
>> Jay
>> 
>>> On 19-Jun-2019, at 2:17 PM, Tejpal Rebari <tejpal.rebari at oracle.com <mailto:tejpal.rebari at oracle.com>> wrote:
>>> 
>>> Hi All,
>>> Changed the Bug Id In the ProblemList  to 8224977.
>>> Updated webrev : http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev1/ <http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev1/>
>>> 
>>> Thanks and regards
>>> Tejpal
>>> 
>>> 
>>>> On 17-Jun-2019, at 3:20 PM, Prasanta Sadhukhan <prasanta.sadhukhan at oracle.com <mailto:prasanta.sadhukhan at oracle.com>> wrote:
>>>> 
>>>> looks ok to me but I think ProblemList really should have 8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977> as the bug id which is the product issue.
>>>> Regards
>>>> Prasanta
>>>> On 17-Jun-19 3:05 PM, Tejpal Rebari wrote:
>>>>> Hi All,
>>>>> Please review a test fix for issue where test fails while restoring the iconified frame in linux platform, and fails while iconifying the frame in Mac platform.
>>>>> Adding some delay after robot events solves the problem.
>>>>> 	1.Linux :  Test runs successfully.
>>>>> 	2.Mac   :	Test was failing while iconifying the frame .After adding the delay it passes this step but fails on another step when is tries to restore the iconified frame.This is because of a product bug in AquaLookAnd Feel where pressing control + F5 does not 				restore the iconified frame.A bug is reported for the same  : https://bugs.openjdk.java.net/browse/JDK-8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977>
>>>>> 
>>>>> Bug https://bugs.openjdk.java.net/browse/JDK-8160880 <https://bugs.openjdk.java.net/browse/JDK-8160880> will be automatically fixed once https://bugs.openjdk.java.net/browse/JDK-8224977 <https://bugs.openjdk.java.net/browse/JDK-8224977> is fixed.
>>>>> 
>>>>> Bug  	:  https://bugs.openjdk.java.net/browse/JDK-8196467 <https://bugs.openjdk.java.net/browse/JDK-8196467>
>>>>> webrev 	: http://cr.openjdk.java.net/~pkbalakr/Tejpal/8196467/webrev0/ <http://cr.openjdk.java.net/%7Epkbalakr/Tejpal/8196467/webrev0/>
>>>>> 
>>>>> 
>>>>> Thanks and regards
>>>>> Tejpal
>>>> 
>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190624/6983a414/attachment.html>

From philip.race at oracle.com  Mon Jun 24 19:33:13 2019
From: philip.race at oracle.com (Phil Race)
Date: Mon, 24 Jun 2019 12:33:13 -0700
Subject: <Swing Dev> RFR: 8226697: Several tests which need the @key headful
 keyword are missing it.
Message-ID: <e006135c-8449-5051-08de-ed92c9fa4c09@oracle.com>

bug : https://bugs.openjdk.java.net/browse/JDK-8226697
webrev : http://cr.openjdk.java.net/~prr/8226697/

These tests need to be run in headful mode, so for our test systems
to handle them properly they need to be tagged as such.
See the bug report for more details.

-phil.

From Sergey.Bylokhov at oracle.com  Mon Jun 24 22:41:00 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 24 Jun 2019 15:41:00 -0700
Subject: <Swing Dev> RFR: 8226697: Several tests which need the @key
 headful keyword are missing it.
In-Reply-To: <e006135c-8449-5051-08de-ed92c9fa4c09@oracle.com>
References: <e006135c-8449-5051-08de-ed92c9fa4c09@oracle.com>
Message-ID: <b48a0aa4-5056-f852-4778-c7f396bd8a91@oracle.com>

Looks fine.

On 24/06/2019 12:33, Phil Race wrote:
> bug : https://bugs.openjdk.java.net/browse/JDK-8226697
> webrev : http://cr.openjdk.java.net/~prr/8226697/
> 
> These tests need to be run in headful mode, so for our test systems
> to handle them properly they need to be tagged as such.
> See the bug report for more details.
> 
> -phil.


-- 
Best regards, Sergey.

From tejpal.rebari at oracle.com  Wed Jun 26 10:17:27 2019
From: tejpal.rebari at oracle.com (Tejpal Rebari)
Date: Wed, 26 Jun 2019 15:47:27 +0530
Subject: <Swing Dev> [13] RFR
 8042383:javax/swing/plaf/basic/BasicMenuUI/4983388/bug4983388.java fails
 with shortcuts on menus do not work
Message-ID: <121D1AD7-A680-4864-85FD-87A914E4D6C5@oracle.com>

Hi All,

Please review a test fix for the issue where the test fails while selecting menu by shortcut keys in Mac OS.

The test contains some KeyPress and KeyRelease events in the hitMnemonics method of Util.And there is no delay added after these events.
Adding some delay after robot events solves the issue.
Before the check for menu selected reduced the delay from 1000 to 200 as auto delay is already set and reducing it could save some time.

Tested in our internal build and test system and test passes on all the three Platforms.

Bug 		: 	https://bugs.openjdk.java.net/browse/JDK-8042383 <https://bugs.openjdk.java.net/browse/JDK-8042383>
webrev 	:	http://cr.openjdk.java.net/~pkbalakr/Tejpal/8042383/webrev0/ <http://cr.openjdk.java.net/~pkbalakr/Tejpal/8042383/webrev0/>

Thanks and Regards
Tejpal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190626/3d85b2aa/attachment.html>

From prasanta.sadhukhan at oracle.com  Wed Jun 26 10:42:42 2019
From: prasanta.sadhukhan at oracle.com (Prasanta Sadhukhan)
Date: Wed, 26 Jun 2019 16:12:42 +0530
Subject: <Swing Dev> [13] RFR
 8042383:javax/swing/plaf/basic/BasicMenuUI/4983388/bug4983388.java fails
 with shortcuts on menus do not work
In-Reply-To: <121D1AD7-A680-4864-85FD-87A914E4D6C5@oracle.com>
References: <121D1AD7-A680-4864-85FD-87A914E4D6C5@oracle.com>
Message-ID: <fa325437-e954-9e59-319e-b9c3e974e745@oracle.com>

looks ok to me.

Regards
Prasanta
On 26-Jun-19 3:47 PM, Tejpal Rebari wrote:
> Hi All,
>
> Please review a test fix for the issue where the test fails while 
> selecting menu by shortcut keys in Mac OS.
>
> The test contains some KeyPress and KeyRelease events in the 
> hitMnemonics method of Util.And there is no delay added after these 
> events.
> Adding some delay after robot events solves the issue.
> Before the check for menu selected reduced the delay from 1000 to 200 
> as auto delay is already set and reducing it could save some time.
>
> Tested in our internal build and test system and test passes on all 
> the three Platforms.
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8042383
> webrev :http://cr.openjdk.java.net/~pkbalakr/Tejpal/8042383/webrev0/ 
> <http://cr.openjdk.java.net/%7Epkbalakr/Tejpal/8042383/webrev0/>
>
> Thanks and Regards
> Tejpal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190626/8427b6d8/attachment.html>

From philip.race at oracle.com  Wed Jun 26 20:31:34 2019
From: philip.race at oracle.com (Phil Race)
Date: Wed, 26 Jun 2019 13:31:34 -0700
Subject: <Swing Dev> RFR [13] 8226783: GTK is not being returned as the
 System L&F on Gnome.
Message-ID: <3dea4bc3-55a0-0f6a-5fbd-58d96fc9c343@oracle.com>

Bug: https://bugs.openjdk.java.net/browse/JDK-8226783
Webrev: http://cr.openjdk.java.net/~prr/8226783/

This fix is for JDK 13 to fix a regression in a recent build of JDK 13.

We use the presence of an environment variable

GNOME_DESKTOP_SESSION_ID

to determine if GTK should be the System L&F on Linux & Solaris

Due to a typo when relocating this from native code to Java code
JDK 13 fails to find it and defaults to Metal as the system L&F - this
is what we do on a KDE desktop for example.

I've added a test that would have helped spot this outage earlier
and should help in a similar future situation.

-phil.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190626/bc876150/attachment.html>

From sergey.bylokhov at oracle.com  Wed Jun 26 20:53:09 2019
From: sergey.bylokhov at oracle.com (Sergey Bylokhov)
Date: Wed, 26 Jun 2019 13:53:09 -0700 (PDT)
Subject: <Swing Dev> RFR [13] 8226783: GTK is not being returned as the
 System L&F on Gnome.
Message-ID: <c6ff02f0-802d-4413-a5ad-4f8f56994506@default>


Looks fine. 

-- 
Best regards, Sergey.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190626/951f073c/attachment.html>

From dmitry.markov at oracle.com  Thu Jun 27 09:59:22 2019
From: dmitry.markov at oracle.com (Dmitry Markov)
Date: Thu, 27 Jun 2019 10:59:22 +0100
Subject: <Swing Dev> [14] RFR 8225505: ctrl-F1 does not show the tooltip of
 a menu item (JMenuItems)
Message-ID: <77039A19-B5C8-43D2-B915-2111DBA8F28C@oracle.com>

Hello,

Could you review a fix for jdk14, please?

 	bug: https://bugs.openjdk.java.net/browse/JDK-8225505 <https://bugs.openjdk.java.net/browse/JDK-8225505>
 	webrev: http://cr.openjdk.java.net/~dmarkov/8225505/webrev.00/ <http://cr.openjdk.java.net/~dmarkov/8225505/webrev.00/>

Problem description:
When tool tip is set for JMenuItem ToolTipManger registers a special key listener for this item. The listener is intended for processing tool tip key bindings, (i.e CTRL + F1) and show or hide tool tip message. However BasicPopupMenuUI.MenuKeyboardHelper handles all key events for menu elements. In other words a menu element such as JMenuItem does not handle a key event directly. As a result the tool tip messages, which is set for JMenuItem, cannot be shown using CTRL + F1 combination.

Fix:
BasicPopupMenuUI.MenuKeyboardHelper should detect tool tip key sequence and forward it to currently highlighted(selected) for further processing. 

Thanks,
Dmitry 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190627/68fd41ce/attachment.html>

From prasanta.sadhukhan at oracle.com  Thu Jun 27 13:38:33 2019
From: prasanta.sadhukhan at oracle.com (Prasanta Sadhukhan)
Date: Thu, 27 Jun 2019 19:08:33 +0530
Subject: <Swing Dev> RFR [13] 8226783: GTK is not being returned as the
 System L&F on Gnome.
In-Reply-To: <3dea4bc3-55a0-0f6a-5fbd-58d96fc9c343@oracle.com>
References: <3dea4bc3-55a0-0f6a-5fbd-58d96fc9c343@oracle.com>
Message-ID: <724401d0-12c8-2df1-b595-dc6a65794a31@oracle.com>

looks ok to me (apart from some indentation issue in the test)

Regards
Prasanta
On 27-Jun-19 2:01 AM, Phil Race wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8226783
> Webrev: http://cr.openjdk.java.net/~prr/8226783/
>
> This fix is for JDK 13 to fix a regression in a recent build of JDK 13.
>
> We use the presence of an environment variable
> GNOME_DESKTOP_SESSION_ID
> to determine if GTK should be the System L&F on Linux & Solaris
>
> Due to a typo when relocating this from native code to Java code
> JDK 13 fails to find it and defaults to Metal as the system L&F - this
> is what we do on a KDE desktop for example.
>
> I've added a test that would have helped spot this outage earlier
> and should help in a similar future situation.
>
> -phil.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190627/972c6cbd/attachment.html>