<Swing Dev> [13] RFR 7184956: [macosx] JPopupMenu.setDefaultLightPopupEneble(true) doesn't work correctly

Phil Race philip.race at oracle.com
Mon Jun 3 20:07:36 UTC 2019


The test update tests the OS but if I understand correctly, it is the 
Aqua L&F that does not support
lightweight popups. Can we check if it is Aqua rather than by OS ?
If you don't want to hard code Aqua then check if it is macos and system 
L&F.
Ideally there'd be some way to query whether a L&F supports this case 
but there isn't,
so I'd like to see  the test include a comment that says
// No API exists to check this, but Aqua currently does not support 
lightweight popups.

Lightweight popups seem to me to be principally a performance optimisation.
The thing you have to support is heavyweights and lightweights are 
optional, and
since I don't think we are likely to investigate whether this can be 
done for Aqua anytime
soon then the test update seems like an OK step.

-phil

On 5/24/19 1:26 PM, semyon.sadetsky at oracle.com wrote:
> webrev: http://cr.openjdk.java.net/~ssadetsky/7184956/webrev.00/
>
> bug: https://bugs.openjdk.java.net/browse/JDK-7184956
>
> Fix for a test: Mac light weigh popup testing excluded.
>
> --Semyon
>



More information about the swing-dev mailing list