<Swing Dev> <AWT Dev> [13] RFR 8153090 8223788 8224149: TAB key cannot change input focus after the radio button in the Color Selection dialog.+

[Prasanta Sadhukhan]

On 06-Jun-19 9:02 PM, semyon.sadetsky at oracle.com wrote:
> On 6/6/19 12:29 AM, Prasanta Sadhukhan wrote:
>
>> Hi Semyon,
>>
>> I do not have much idea of focus traversal code but it seems when 
>> your regression testcase is run, 
>> SwingContainerOrderFocusTraversalPolicy does get called as I can see, 
>> so I see no harm in putting the code there, given Phil's objection.
> You see it called in the color panel or for other container?
>
I did not see from where it is called but I had a print in accept() of 
SwingContainerOrderFocusTraversalPolicy which was getting called when I 
ran the testcase.

Regards
Prasanta
> --Semyon
>>
>> Regards
>> Prasanta
>> On 23-May-19 3:46 AM, semyon.sadetsky at oracle.com wrote:
>>> On 5/20/19 11:48 PM, Prasanta Sadhukhan wrote:
>>>
>>>> Probably we can move this traversal code to 
>>>> javax.swing.SortingFocusTraversalPolicy#SwingContainerOrderFocusTraversalPolicy 
>>>> for this JToggleButton swing component to avoid this scepticism.
>>> Hi Prasanta,
>>> We cannot move it there because it'd not be called when 
>>> ContainerOrderFocusTraversalPolicy is used.
>>> --Semyon
>>>>
>>>> Regards
>>>> Prasanta
>>>> On 21-May-19 1:36 AM, semyon.sadetsky at oracle.com wrote:
>>>>> On 5/20/19 11:04 AM, Philip Race wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I'm afraid I know next to nothing about the focus traversal
>>>>>> code in Swing or AWT, but it smells very wrong to have
>>>>>> such knowledge of a specific Swing component in the
>>>>>> AWT focus code.
>>>>> I don't see anything wrong here. You can find a lot of Swing 
>>>>> component specific code in java.awt.* implementations. This is not 
>>>>> the first Swing aware AWT class.
>>>>>
>>>>> --Semyon
>>>>>>
>>>>>> -phil.
>>>>>>
>>>>>> On 5/20/19, 8:37 AM, semyon.sadetsky at oracle.com wrote:
>>>>>>> bugs:
>>>>>>>
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8153090
>>>>>>>
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8223788
>>>>>>>
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8224149
>>>>>>>
>>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8153090/webrev.00/
>>>>>>>
>>>>>>> The fix eliminates issues in JColorChooser dialog making it more 
>>>>>>> accessible by keyboard. See JBS for details.
>>>>>>>
>>>>>>> --Semyon
>>>>>>>
>>>>>
>>>>
>>>
>>
>