<Swing Dev> [13] RFR JDK-8225511:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedTranslucentPerPixelTranslucentGradient.java fails in linux-x64

[Phil Race]

+1

-phil.

On 6/10/19 11:52 AM, Sergey Bylokhov wrote:
> Looks fine.
>
> On 10/06/2019 03:13, Prasanta Sadhukhan wrote:
>> Hi All,
>>
>> Similar to JDK-8224876 (as below), 
>> ShapedTranslucentPerPixelTranslucentGradient.java fails time to time 
>> on mach5 linux headful system, Proposed fix is similar to other one 
>> which is to add some more delay for translucent case too.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8225511
>>
>> diff -r de1d2a535c08 
>> test/jdk/javax/swing/JWindow/ShapedAndTranslucentWindows/Common.java
>> --- 
>> a/test/jdk/javax/swing/JWindow/ShapedAndTranslucentWindows/Common.java 
>> Mon Jun 10 10:52:11 2019 +0530
>> +++ 
>> b/test/jdk/javax/swing/JWindow/ShapedAndTranslucentWindows/Common.java 
>> Mon Jun 10 15:37:58 2019 +0530
>> @@ -367,13 +367,13 @@
>>           // Drag
>>           Point location = window.getLocationOnScreen();
>>           robot.dragAndDrop(location.x + 30, location.y + 5, 
>> location.x + dl + random.nextInt(dl), location.y + random.nextInt(dl));
>> -        robot.waitForIdle(delay);
>> +        robot.waitForIdle(2*delay);
>>           checkTranslucentShape();
>>
>>           // Resize
>>           location = window.getLocationOnScreen();
>>           robot.dragAndDrop(location.x + 4, location.y + 4, 
>> location.x + random.nextInt(2*dl)-dl, location.y + 
>> random.nextInt(2*dl)-dl);
>> -        robot.waitForIdle(delay);
>> +        robot.waitForIdle(2*delay);
>>           checkTranslucentShape();
>>
>> Regards
>> Prasanta
>> On 04-Jun-19 1:30 AM, Sergey Bylokhov wrote:
>>> Looks fine, I have checked it and looks like it can really  lag time 
>>> to time.
>>>
>>> On 03/06/2019 04:00, Jayathirth D V wrote:
>>>> Changes are fine but we should wait on Sergey's manual check of 
>>>> test in the system.
>>>>
>>>> Thanks,
>>>> Jay
>>>>
>>>> -----Original Message-----
>>>> From: Prasanta Sadhukhan
>>>> Sent: Monday, June 03, 2019 3:54 PM
>>>> To: Sergey Bylokhov; swing-dev at openjdk.java.net
>>>> Subject: Re: <Swing Dev> [13] RFR 
>>>> 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java 
>>>> fails on linux-x64
>>>>
>>>> Gentle reminder...
>>>>
>>>>
>>>> On 30-May-19 12:32 PM, Prasanta Sadhukhan wrote:
>>>>> I could not find anything amiss when I capture the screen output at
>>>>> the time of fail, so I decided to go to timeout increase route. I
>>>>> guess it is needed to check the test manually in that mach5 specific
>>>>> linux system to see what is happening.
>>>>>
>>>>> Regards
>>>>> Prasanta
>>>>> On 29-May-19 2:29 AM, Sergey Bylokhov wrote:
>>>>>> Hi, Prasanta.
>>>>>>
>>>>>> Isn't strange that 1 second is not enough to wait for redraw?
>>>>>> I'll reply soon after rechecking the test manually on this system.
>>>>>>
>>>>>> On 28/05/2019 04:01, Prasanta Sadhukhan wrote:
>>>>>>> Hi All,
>>>>>>>
>>>>>>> Please review a test-fix for an issue where the test check fails
>>>>>>> after the content of window is dragged & resized.
>>>>>>> Test is passing in local ubuntu18.04 system but is failing on mach5
>>>>>>> linux headful system as test check for pixels happens too quickly
>>>>>>> after window drag/resize.
>>>>>>> Increased delay between test drag&drop and check to make sure check
>>>>>>> happens after reasonable amount of time. Test now pass in all mach5
>>>>>>> systems.
>>>>>>>
>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224876
>>>>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8224876/webrev.0/
>>>>>>>
>>>>>>> Regards
>>>>>>> Prasanta
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>