<Swing Dev> [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

[Alexey Ivanov]

On 20/06/2019 01:00, Sergey Bylokhov wrote:
> On 12/06/2019 07:09, Alexey Ivanov wrote:
> <SNIP>
>
>> I'd rather leave bold rendering for keys, I think it makes sense. Yet 
>> it's up to you to decide.
>
> Something like this?
> http://cr.openjdk.java.net/~serb/8225146/webrev.03
> http://cr.openjdk.java.net/~serb/8225146/webrev.03/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html 
>

Yes, looks good to me.

>> The <caption> element is optional. Does it make any difference to 
>> have one if it's hidden? With “display: none” it will not be visible 
>> to assistive technologies such as screen reader, will it?
>
> The "caption" tag is used across our javadocs because in most cases 
> the content of the "caption" tag is a content of the "summary" tag 
> which was deprecated in html5, I guess at some point we will need to 
> migrate to "aria-label" or something like this.

Yeah, I understand that. And it makes sense where <caption> is visible.
In this case, <caption> element has “display: none” style, thus it's 
invisible for visual browser users, and it's invisible for screen reader 
users as well. As such, we could drop <caption> element completely.

It's rather a concern for discussion…

>> <SNIP>
-- 
Regards,
Alexey