<Swing Dev> [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

[Shashidhara Veerabhadraiah]

Hi Sergey\Phil, Here is a new Webrev containing the new test case along with the fix. With this change, the test fails before the fix and passes after the fix.

http://cr.openjdk.java.net/~sveerabhadra/8213516/webrev.04/

Please review this change.

Thanks and regards,
Shashi

-----Original Message-----
From: Shashidhara Veerabhadraiah 
Sent: Friday, February 15, 2019 4:27 PM
To: Sergey Bylokhov <sergey.bylokhov at oracle.com>; Philip Race <philip.race at oracle.com>
Cc: swing-dev at openjdk.java.net; Dmitry Bessonov <dmitry.bessonov at oracle.com>
Subject: Re: <Swing Dev> [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

Hi Phil\Sergey, I have a question regarding the test. The test is supposed to fail before the fix and pass after the fix. But this bug fails because of earlier ran resource bundle test caching the file and which is getting used by the fields test causing failure.
Now even if I write the test it will still pass before and after the fix, so was not sure how do I go about that!! Please clarify.

Thanks and regards,
Shashi

-----Original Message-----
From: Shashidhara Veerabhadraiah 
Sent: Friday, February 15, 2019 3:14 PM
To: Sergey Bylokhov <sergey.bylokhov at oracle.com>; Philip Race <philip.race at oracle.com>
Cc: swing-dev at openjdk.java.net; Dmitry Bessonov <dmitry.bessonov at oracle.com>
Subject: Re: <Swing Dev> [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

Hi Sergey\Phil, Here is the new webrev:
http://cr.openjdk.java.net/~sveerabhadra/8213516/webrev.03/

I assumed the table.get() function calls the equals() method of the key class. But that was not the case. My mistake.

Thanks and regards,
Shashi

-----Original Message-----
From: Sergey Bylokhov 
Sent: Friday, February 15, 2019 4:23 AM
To: Shashidhara Veerabhadraiah <shashidhara.veerabhadraiah at oracle.com>; Philip Race <philip.race at oracle.com>
Cc: swing-dev at openjdk.java.net; Dmitry Bessonov <dmitry.bessonov at oracle.com>; Krishna Addepalli <krishna.addepalli at oracle.com>
Subject: Re: <Swing Dev> [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

Hi, Shashi.

> HashTable class uses these methods for key types used in the hash table, hence they need to be implemented as part of the key types. The JCK test already tests this, so Sergey do you want me to write another open test for this problem?

The rules above are applicable to the keys of the hashtable, but you did not use your new class as a key.
The new test is needed because the old test will be excluded.
Please take a look to this comment as well:
https://mail.openjdk.java.net/pipermail/swing-dev/2019-January/009277.html

-- 
Best regards, Sergey.