<Swing Dev> [13] RFR JDK-8214112: The whole text in target JPasswordField image are not selected.

[Pankaj Bansal]

Thanks Prasanta and Sergey for the review.

 

Sergey, this is the new bug I have created for reading the values from the CSS.

https://bugs.openjdk.java.net/browse/JDK-8220053

 

-Pankaj

 

From: Prasanta Sadhukhan 
Sent: Monday, March 4, 2019 2:06 PM
To: Pankaj Bansal; swing-dev at openjdk.java.net
Subject: Re: <Swing Dev> [13] RFR JDK-8214112: The whole text in target JPasswordField image are not selected.

 

ok. +1

Regards
Prasanta

On 04-Mar-19 1:50 PM, Pankaj Bansal wrote:

Hi Prasanta,

 

<< Dont we have to take care of else part for if (gtk3_version_3_20)?

Actually this change has been done in gtk 3.20. So all works well before that and nothing needs to be done.

 

-Pankaj

 

 

From: Prasanta Sadhukhan 
Sent: Monday, March 4, 2019 1:43 PM
To: Pankaj Bansal; HYPERLINK "mailto:swing-dev at openjdk.java.net"swing-dev at openjdk.java.net
Subject: Re: <Swing Dev> [13] RFR JDK-8214112: The whole text in target JPasswordField image are not selected.

 

Hi Pankaj,

Dont we have to take care of else part for if (gtk3_version_3_20)?

Regards
Prasanta

On 26-Feb-19 4:03 PM, Pankaj Bansal wrote:

Hi All,

Please review the following fix. 


Bug: https://bugs.openjdk.java.net/browse/JDK-8214112

webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epbansal/8214112/webrev00/"http://cr.openjdk.java.net/~pbansal/8214112/webrev00/

Issue:

The whole text in target JPasswordField image are not selected.

 

Fix:

This bug is similar to https://bugs.openjdk.java.net/browse/JDK-8218473. Gtk3 does not set the selected background color for some widgets like SPINNER_TEXT_FIELD, FORMATTED_TEXT_FIELD, PASSWORD_FIELD and TEXT_FIELD after gtk version 3.20. The TEXT_FIELD widget case was corrected by https://bugs.openjdk.java.net/browse/JDK-8218473. This fix corrects the other widgets.

 

This can be verified by running any sample/demo of these widgets and selecting the text in the widget. This issue is coming in Adwaita and Yaru themes. So, this will be easily reproducible on OEL 7.5, 7.6 and Ubuntu 18.10. To reproduce this on Ubuntu 18.04, switch the gtk3 theme to Adwaita. I have tested this on Ubuntu 18.10, 18.04, 16.04 and OEL 7.5.


Regards,
Pankaj Bansal

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20190304/f47e4c74/attachment-0001.html>