<Swing Dev> [13] RFR JDK-8220349: The fix done for JDK-8214253 have caused issues in JTree behaviour

[Pankaj Bansal]

Thanks for review Sergey and Phil.

<< Is it possible at runtime in the test check that the color of the selected node is the same as background?
I am not able to find a way to write an automated test case for this. I can write a Manual test but don't know how much that will help as SwingSet2 can also be used to verify this. Please let me know your thoughts on this.

-Pankaj


-----Original Message-----
From: Sergey Bylokhov 
Sent: Saturday, March 9, 2019 3:56 AM
To: Pankaj Bansal; swing-dev at openjdk.java.net
Subject: Re: <Swing Dev> [13] RFR JDK-8220349: The fix done for JDK-8214253 have caused issues in JTree behaviour

Hi, Pankaj.

Is it possible at runtime in the test check that the color of the selected node is the same as background?

On 08/03/2019 05:50, Pankaj Bansal wrote:
> Hi All,
> 
> Please review the following fix.
> 
> 
> Bug:
> 
> https://bugs.openjdk.java.net/browse/JDK-8220349
> 
> webrev
> 
> http://cr.openjdk.java.net/~pbansal/8220349/webrev00/
> 
> Issue:
> 
> The fix done for JDK-8214253 have caused issues in JTree behaviour. If the JTree node is selected, its background and text color become white and nothing is readable.
> 
> The changes done in gtk3_paint_flat_box for JDK-8214253 have caused this issue as the changes were made for all the widgets. JDK-8214253 is specific to TOOL_TIP. So JDK-8214253 can be fixed by making changes only for TOOL_TIP like done in gtk3_get_color_for_state. The gtk3_paint_flat_box is also called by other widegts like JTree cell rendering and they have been handled well in transform_detail_string. So we don't want to copy the same code in get_style.
> 
> Fix:
> 
> This patch fixes the issue by making the changes done in gtk3_paint_flat_box specific to TOOL_TIP like were done in gtk3_get_color_for_state
> 
> Testing:
> 
> This fix can be verified by running SwingSet2 and using JTree. I have verified this on Ubuntu 16.04, 18.04, 18.10 and OEL 7.5.
> 
> 
> Regards,
> Pankaj Bansal
> 


-- 
Best regards, Sergey.