<Swing Dev> [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

Shashidhara Veerabhadraiah shashidhara.veerabhadraiah at oracle.com
Tue Mar 12 10:52:52 UTC 2019


Hi Sergey, Please find the updated Webrev with fixes for the below comments:

http://cr.openjdk.java.net/~sveerabhadra/8213516/webrev.06/

Thanks and regards,
Shashi

-----Original Message-----
From: Sergey Bylokhov 
Sent: Wednesday, March 6, 2019 5:19 AM
To: Shashidhara Veerabhadraiah <shashidhara.veerabhadraiah at oracle.com>; Philip Race <philip.race at oracle.com>
Cc: swing-dev at openjdk.java.net; Dmitry Bessonov <dmitry.bessonov at oracle.com>
Subject: Re: <Swing Dev> [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

Hi, Shashi.
On 04/03/2019 01:40, Shashidhara Veerabhadraiah wrote:
> Hi Sergey\Phil, Here is a new Webrev containing the new test case along with the fix. With this change, the test fails before the fix and passes after the fix.
> 
> http://cr.openjdk.java.net/~sveerabhadra/8213516/webrev.04/
> 
> Please review this change.

The hashcode() does not guarantee that it will produce different numbers for different inputs.
You need a compound key like in previous fix(but not in the public APi), or you need a compound map like this:
Hashtable<Locale, Hashtable<String, Hashtable<String, Object>>> table = new Hashtable<>();

-- 
Best regards, Sergey.


More information about the swing-dev mailing list