<Swing Dev> [13] RFR 7184956: [macosx] JPopupMenu.setDefaultLightPopupEneble(true) doesn't work correctly

semyon.sadetsky at oracle.com semyon.sadetsky at oracle.com
Tue May 28 16:19:23 UTC 2019


On 5/24/19 2:07 PM, Sergey Bylokhov wrote:

> Hi, Semyon.
>
> I am not sure that this is a test bug, the Aqua L&F uses HW popup by 
> default, but the case when the user requests LW popup for some reason 
> should work, it is just not implemented yet.
Hi Sergey,
I think your understanding of the lightWeightPopupEnabled property 
purpose is not fully correct. The specification of the property is very 
clear on that:
    /**
      * Sets the value of the <code>lightWeightPopupEnabled</code> property,
      * which by default is <code>true</code>.
      * By default, when a look and feel displays a popup,
      * it can choose to
      * use a lightweight (all-Java) popup.
      * Lightweight popup windows are more efficient than heavyweight
      * (native peer) windows,
      * but lightweight and heavyweight components do not mix well in a GUI.
      * If your application mixes lightweight and heavyweight components,
      * you should disable lightweight popups.
      * Some look and feels might always use heavyweight popups,
      * no matter what the value of this property.
      */
So, there is nothing to implement in Aqua L&F about it.
--Semyon
>
> BTW: note that the current two weeks sprint is about the cleanup of 
> our internal CI, which has some failing tests which are not in the 
> problem list. It is not necessary to change the tests which are 
> already in the problem list.
>
> On 24/05/2019 13:26, semyon.sadetsky at oracle.com wrote:
>> webrev: http://cr.openjdk.java.net/~ssadetsky/7184956/webrev.00/
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-7184956
>>
>> Fix for a test: Mac light weigh popup testing excluded.
>>
>> --Semyon
>>
>
>



More information about the swing-dev mailing list