<Swing Dev> [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

[Prasanta Sadhukhan]

It works for oel8 too. So the fix looks fine to me.

Regards

Prasanta

On 27-Nov-19 3:54 PM, Prasanta Sadhukhan wrote:
>
> Hi Pankaj,
>
> I can see the issue resolved in ubuntu18.04 but not in OEL8. Also, 
> SwingSet2 does not have JSpinner demo so we cannot put noreg-demo in 
> JBS, so we probably need a regression test, even manual, for this.
>
> Regards
>
> Prasanta
>
> On 25-Nov-19 4:13 PM, Pankaj Bansal wrote:
>>
>> Hi All,
>>
>> Please review the following fix for jdk14.
>>
>>
>> Bug:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8234733
>>
>> webrev:
>>
>> http://cr.openjdk.java.net/~pbansal/8234733/webrev00/
>>
>> Issue:
>>
>> In GTKL&F, the spinner’s up/down buttons are drawn in same way 
>> whether the button is pressed or not. We can't distinguish visually 
>> whether a button is pressed or not. The buttons should be highlighted 
>> when they are in pressed state. The issue is due to style and theme 
>> changes done in gtk3 in version gtk3.20.
>>
>> Fix:
>>
>> The fix sets the style properly when drawing the spinner buttons with 
>> gtk3.20 or higher. All works as it is if the gtk3 version is lower 
>> than gtk3.20. The current fix is in continuity of the fixes done for 
>> issues like https://bugs.openjdk.java.net/browse/JDK-8218469
>>
>> Testing:
>>
>> The fix can be verified by running SwingSet2 or any other demo/sample 
>> of JSpinner (one is attached in the JBS) and it has to be verified 
>> manually. I have verified this on Ubuntu 18.04, 19.04, 19.10 and OEL 
>> 7.5. The issue is solved on all platforms.
>>
>>
>> Regards,
>> Pankaj Bansal
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20191127/57601102/attachment.html>