<Swing Dev> RFR: 8152332 [macosx] JFileChooser cannot be serialized on Mac OS X

Pankaj Bansal pankaj.b.bansal at oracle.com
Sun Apr 12 14:37:29 UTC 2020


Looks good to me.
One minor nit, don’t we need to add the current bug id to the test?

-Pankaj

-----Original Message-----
From: Sergey Bylokhov 
Sent: Monday, March 16, 2020 2:06 PM
To: Swing-Dev <swing-dev at openjdk.java.net>
Subject: <Swing Dev> RFR: 8152332 [macosx] JFileChooser cannot be serialized on Mac OS X

Hello.
Please review the fix for JDK/client.

Bug: https://bugs.openjdk.java.net/browse/JDK-8152332
Fix: http://cr.openjdk.java.net/~serb/8152332/webrev.00

This test failed because of two product bugs
JDK-8240633 and JDK-8240690(still under review).

But there is an issue in the test itself, it uses a sequence of robot events which does not work on L&Fs such as Aqua/Nimbus but works on Metal. The test was updated to close the file chooser w/o robot, and the default button is verified explicitly, also added a check for all L&Fs.

I have checked that it is possible to verify the initial bug JDK-8146301 using an updated test.

--
Best regards, Sergey.


More information about the swing-dev mailing list