<Swing Dev> RFR: 8152332 [macosx] JFileChooser cannot be serialized on Mac OS X

[Jayathirth D v]

+1.

Regards,
Jay

> On 13-Apr-2020, at 6:33 PM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> On 4/12/20 7:37 am, Pankaj Bansal wrote:
>> Looks good to me.
> 
> Thank you.
> 
>> One minor nit, don’t we need to add the current bug id to the test?
> 
> Nope, that field mostly for the product bugs, which is useful when the test is updated,
> we need to check that the previous product bug still can be verified by the test, like
> I did in this fix and JDK-8146301.
> 
>> -Pankaj
>> -----Original Message-----
>> From: Sergey Bylokhov
>> Sent: Monday, March 16, 2020 2:06 PM
>> To: Swing-Dev <swing-dev at openjdk.java.net>
>> Subject: <Swing Dev> RFR: 8152332 [macosx] JFileChooser cannot be serialized on Mac OS X
>> Hello.
>> Please review the fix for JDK/client.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8152332
>> Fix: http://cr.openjdk.java.net/~serb/8152332/webrev.00
>> This test failed because of two product bugs
>> JDK-8240633 and JDK-8240690(still under review).
>> But there is an issue in the test itself, it uses a sequence of robot events which does not work on L&Fs such as Aqua/Nimbus but works on Metal. The test was updated to close the file chooser w/o robot, and the default button is verified explicitly, also added a check for all L&Fs.
>> I have checked that it is possible to verify the initial bug JDK-8146301 using an updated test.
>> --
>> Best regards, Sergey.
> 
> 
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200413/651f9ffa/attachment.htm>