<Swing Dev> RFR: 8233584: [Win LAF] When navigating the contents of the file list changes in Win LAF

[Bhawesh Choudhary]

Hi Alexey,
Please review below fix updated as per your suggestion.

-Bhawesh

On 4/6/2020 12:22 PM, Bhawesh Choudhary wrote:
> Hi Alexey,
>
> Please find updated Webrev as per suggestion. I couldn't make test 
> automatic due to not able to read contents currently being displayed 
> in JFileChooser.
>
> JBS:         https://bugs.openjdk.java.net/browse/JDK-8233584
> Webrev: http://cr.openjdk.java.net/~psadhukhan/8233584/webrev.2/
>
> -Bhawesh
>
> On 4/2/2020 12:17 AM, Alexey Ivanov wrote:
>> Hi Bhawesh,
>>
>> Shall we add
>> @requires |os.family == "windows"
>> to the test? Then it won't be even selected for running by jtreg.
>>
>> It think the copyright year should be updated in both modified files, 
>> should it?
>>
>> I'd also suggest using explicit import statements for javax.swing.* 
>> classes instead of the wildcard one.
>>
>> Is it possible to make the automatic? However, this is out of scope 
>> of this bug.
>>
>>
>> Regards,
>> Alexey
>> |
>> On 31/03/2020 10:16, Bhawesh Choudhary wrote:
>>> Hi,
>>>
>>> Please find updated Webrev as per suggestions [Test case updates for 
>>> WindowsLookAndFeel]
>>>
>>> JBS:         https://bugs.openjdk.java.net/browse/JDK-8233584
>>> Webrev: http://cr.openjdk.java.net/~psadhukhan/8233584/webrev.1/
>>>
>>> -Bhawesh
>>>
>>> On 3/13/2020 12:10 PM, Bhawesh Choudhary wrote:
>>>> Hi,
>>>>
>>>> Please find updated Webrev as per suggestions [Test name update and 
>>>> Code formatting]
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8233584
>>>> Webrev: http://cr.openjdk.java.net/~psadhukhan/8233584/webrev.01/
>>>>
>>>> -Bhawesh
>>>>
>>>> On 3/4/2020 4:13 PM, Bhawesh Choudhary wrote:
>>>>> Hi,
>>>>>
>>>>> Please review this fix,
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8233584
>>>>> Webrev: http://cr.openjdk.java.net/~psadhukhan/8233584/webrev/
>>>>>
>>>>> Issue:
>>>>> In Windows LookAndFeel, When navigating Combobox's list of 
>>>>> JFileChooser via keys, the contents of JFileChooser changes.
>>>>>
>>>>> Fix:
>>>>> Set flag "JComboBox.isTableCellEditor" to True which prohibits 
>>>>> JCombobox from sending selection change event when JCombobox's 
>>>>> list selection change happens via keys.
>>>>>
>>>>>
>>>>> Verification:
>>>>> Tested the fix with JFileChooser with WindowsLookAndFeelEnabled as 
>>>>> well as BasicLookAndFeel with keys navigation. also added a test 
>>>>> case to verify the same.
>>>>>
>>>>> Did not find any misbehavior with the fix.
>>>>>
>>>>> Regards
>>>>> Bhawesh
>