<Swing Dev> RFR JDK-8250811: Address reliance on default constructors in the javax.swing.plaf.multi APIs
Prasanta Sadhukhan
prasanta.sadhukhan at oracle.com
Wed Aug 5 04:09:54 UTC 2020
I guess since it is mentioned in the coding guidelines, we should follow
that. We should try changing the event package and others, if time
permits to match coding guidelines.
But having said that, I am open to follow whatever you leads decide.
Regards
Prasanta
On 05-Aug-20 8:17 AM, Sergey Bylokhov wrote:
> On 04.08.2020 14:05, Philip Race wrote:
>>
>> Section 6.4 of the 23 year old coding guidelines
>> https://www.oracle.com/technetwork/java/codeconventions-150003.pdf
>> appear to suggest {} for empty methods.
>>
>> However I know this only because I went to look.
>> I would have guessed the opposite .. and prefer that opposite.
>
> On the other side lots of classes in the client-libs(for example in
> the "java.awt.event" package) use such style:
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/event/ComponentAdapter.java
>
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/event/ContainerAdapter.java
>
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/event/KeyAdapter.java
>
> etc.
> So maybe this is a common practice
>
More information about the swing-dev
mailing list