<Swing Dev> RFR JDK-8250849: Address reliance on default constructors in the javax.swing.plaf APIs

[Philip Race]

yep, +1

-phil

On 8/13/20, 2:37 PM, Sergey Bylokhov wrote:
> Looks fine.
>
> On 12.08.2020 10:13, Prasanta Sadhukhan wrote:
>> Hi All,
>>
>> Please review a fix for issue where it was seen that several classes 
>> rely on default constructors as part of their public API.
>>
>> It's to be noted that "A no-arg public constructor is generated by 
>> the compiler for a class if it does not declare an explicit 
>> constructor. While convenient, this is inappropriate for many kinds 
>> of formal classes, both because the constructor will have no javadoc 
>> and because the constructor may be unintended."
>>
>> For the JDK, classes intended to be used outside of the JDK, public 
>> classes in exported packages, should not rely on default constructors.
>>
>> Proposed fix is to create protected constructors to the public 
>> abstract classes for javax.swing.plaf module (as one part of overalll 
>> java.desktop change)
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8250849
>>
>> webrev:http://cr.openjdk.java.net/~psadhukhan/8250849/webrev.0/
>>
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8251491
>>
>> Regards
>> Prasanta
>>
>
>