<Swing Dev> RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v2]

[Tejpal Rebari]

On Mon, 30 Nov 2020 17:53:48 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>>> not wrong but different account but that doesnot make the comment invalid, I guess.
>> 
>> But nobody sees it, it is hidden.
>
> Well, the comment was added on Oct 15 and it got hidden on Oct28 because the ac was not of github author/committer. I think the fix submitter should have seen the comment lying there for 2 weeks before it got hidden.

I have seen the comment, it is not visible in github but its there in mailing-list.

"It seems the effect is in WindowsLookAndFeel but you are fixing in Basic L&F. If the cause is in Basic L&F, then it
would have affected other L&F also like Metal,Nimbus, doesn't it? If MouseGrabber not removed is the problem, the I
guess MouseGrabber.uninstall() is not called. This is called in BasicLookAndFeel#uninitialize() and is overridden in
WindowsLookAndFeel. Metal does not override this so maybe that's why the issue is not seen in Metal.  Probably the
right fix is to call this MouseGrabber.uninstall() in Windows:LookAndFeel.uninitialize() same way as is done in
BasicLookAndFeel.uninitialize()"

the current fix doesn't looks correct so working on finding the correct fix.

-------------

PR: https://git.openjdk.java.net/jdk/pull/600