<Swing Dev> RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

Phil Race prr at openjdk.java.net
Sat Dec 12 23:35:58 UTC 2020


On Tue, 1 Dec 2020 18:18:21 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Since the apple forum post is still unanswered and if we want it to be fixed for JDK16, I dont see any other alternative than to fix by what I did in the 1st iteration of this by hardcoding. I dont think we are going to enable dark mode in JDk16 so we will have time to think on that when we enable that and hopefully Apple will come back by that time and we can revisit this.
>
>> Since the apple forum post is still unanswered and if we want it to be fixed for JDK16, I dont see any other alternative than to fix by what I did in the 1st iteration of this by hardcoding. I dont think we are going to enable dark mode in JDk16 so we will have time to think on that when we enable that and hopefully Apple will come back by that time and we can revisit this.
> 
> Can you try some small sample code and create the tabpane using Cocoa then set some state to the pane(like selected) and request its font?

Where exactly is this forum post ?
The current version of the fix isn't obviously hard-coding it. The source looks to be
NSColor selectedControlColor

how is that hard-coded ?

 Why isn't that sensitive to dark vs light theme ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1182


More information about the swing-dev mailing list