<Swing Dev> RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]
Prasanta Sadhukhan
psadhukhan at openjdk.java.net
Fri Dec 18 03:38:02 UTC 2020
On Thu, 17 Dec 2020 18:03:04 GMT, Phil Race <prr at openjdk.org> wrote:
>>> If 1st, is there any way to integrate the 1st version without updating the PR?
>>
>> No, this is not possible. If you need to integrate an earlier version, you will need to revert those changes in your local branch and push them.
>
> I wouldn't know how to approve an earlier version. SFAIK I approved the current version.
> One thing here though is that I think you should WITHDRAW this PR and re-submit for JDK 16.
> I don't think we want to have to wait until JDK 17 to be able to read tabs on macOS 11.
The current version has the issue of text color obtained through [selectedControlColor] being changed through "Preferences->General->Accent Color", which is not in our control, which was already discussed. So, I thought the 1st version, which is more robust, is the one which is approved.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1182
More information about the swing-dev
mailing list