<Swing Dev> [jdk16] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v2]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Thu Dec 24 18:36:12 UTC 2020


> Please review a fix for jdk16.
> On macOS 11 (bigsur), using the Swing Aqua Look and Feel, the text of the selected JTabbedPane tab title text is just a light gray outline of white text on a white background. The macOS 11 design inverted from dark background / light text to light background / dark text, so white text on white background is not legible.
> Correct system color to use for this scenario, as per Apple, is [NSColor controlTextColor]
> so the proposed fix is to use this system color for BigSur. 
> For preBigSur releases, "white" is still used as the above color is for text color but the tabPane background color is still not readable through any Apple API, so [NSColor controlTextColor] which returns black will not be legible on preBigSur releases which has black background.

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Check for BigSur and above

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk16/pull/65/files
  - new: https://git.openjdk.java.net/jdk16/pull/65/files/504f1bd0..ad3c52b5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk16&pr=65&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk16&pr=65&range=00-01

  Stats: 6 lines in 2 files changed: 5 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk16/pull/65.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/65/head:pull/65

PR: https://git.openjdk.java.net/jdk16/pull/65


More information about the swing-dev mailing list