<Swing Dev> [15] RFR JDK-8231042: [macos] JFileChooser creates new folder on ESC

[Sergey Bylokhov]

Looks fine.

On 2/27/20 4:22 am, Pankaj Bansal wrote:
> Hi Sergey,
> 
> Thanks for the review.
> 
> << It would be good to filter out the test on non-mac systems by the "@requires" tag.
> I added the filter in main method, so if someone is running this as standalone test, even then the test is filtered out. But yes, adding the tag is useful when using jtreg to stop the test from running altogether. I have added the tag "@requires". Please have a look.
> webrev: http://cr.openjdk.java.net/~pbansal/8231042/webrev01/
> 
> Regards,
> Pankaj
> 
> -----Original Message-----
> From: Sergey Bylokhov
> Sent: Thursday, February 27, 2020 4:32 PM
> To: Pankaj Bansal <pankaj.b.bansal at oracle.com>; swing-dev at openjdk.java.net
> Subject: Re: <Swing Dev> [15] RFR JDK-8231042: [macos] JFileChooser creates new folder on ESC
> 
> Hi, Pankaj.
> 
> It would be good to filter out the test on non-mac systems by the "@requires" tag.
> 
> On 2/25/20 8:43 am, Pankaj Bansal wrote:
>> Hi All,
>>
>> Please review the following fix for jdk15.
>>
>>
>> Bug:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8231042
>>
>> webrev:
>>
>> http://cr.openjdk.java.net/~pbansal/8231042/webrev00/
>>
>> Issue:
>>
>> In case of AquaLookAndFeel, if a JFileChooser is created and if we try to abort the "New Folder" create action by pressing "ESC" key, there is a new folder created named "uninitializedValue". If the new folder creation is aborted, it should not create any folder as pressing "ESC" key is equivalent to cancelling the folder creation.
>>
>> Cause:
>>
>> In JFileChooser, the check if the JOptionPane is cancelled is missing. This issue is specific to AquaLookAndFeel.
>>
>> Fix:
>>
>> The fix is to add the required check in JFileChoose create NewFolder Action for a Cancelled JOptionPane. I this case, no folder should be created.
>>
>>
>> Regards,
>> Pankaj Bansal
>>
> 
> 


-- 
Best regards, Sergey.