<Swing Dev> Remove System.out.println from ImageIcon.loadImage

[Sergey Bylokhov]

On 1/21/20 1:14 pm, Volodin, Vladislav wrote:
> Hi all,
> 
> If I am not mistaken, this method is called from the constructor and other methods. How long should we try loading the icon using the unmanaged (by any thread pool, but I am not sure about this statement) thread?
> 
> We don’t even have the flag “interrupted”. So technically this icon has to be loaded.

I think it is necessary to save the "interrupted" state in the catch
block and try to call waitForID() again. It will be necessary to set
"interrupted" flag for the Thread after that(when the waitForID will
return without exception).


> Sent from myFone
> 
>> On 21. Jan 2020, at 21:55, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>>
>> On 1/21/20 12:26 pm, Jason Mehrens wrote:
>>> +1 for Sergey suggestion.
>>
>> Or probably we need to try to load the image again because of the spec of the method state this:
>> "Loads the image, returning only when the image is loaded."
>>
>>> ________________________________________
>>> From: Sergey Bylokhov <Sergey.Bylokhov at oracle.com>
>>> Sent: Sunday, January 19, 2020 9:31 PM
>>> To: Volodin, Vladislav; Jason Mehrens
>>> Cc: swing-dev at openjdk.java.net
>>> Subject: Re: <Swing Dev> Remove System.out.println from ImageIcon.loadImage
>>> I guess there are no objections, probably the best way to fix
>>> it is to drop the System.out.println and set interrupted flag.
>>> On 1/16/20 7:05 am, Volodin, Vladislav wrote:
>>>> If people in this distribution list agree, I can start working on a simple fix and either remove the logging (System.out.println), or replace it with PlatformLogger. I guess the second solution sounds better, but I don't know what is the better way to write a test-case for it.
>>> --
>>> Best regards, Sergey.
>>
>>
>> -- 
>> Best regards, Sergey.


-- 
Best regards, Sergey.