<Swing Dev> [15] Review Request: 8237746 Fixing compiler warnings in src/demo/share/jfc

Marc Hoffmann hoffmann at mountainminds.com
Thu Jan 23 08:54:38 UTC 2020


Hi Sergey,

thanks for sponsoring this patch!

I successfully applied the webrev patch on current JDK head (57807:7bae17e00566). The build runs without warnings on the demo code :)

But I noticed a minor glitch: I inserted a tab in src/demo/share/jfc/SwingSet2/DirectionPanel.java Line 97 where only spaces are used in the rest of the file. Probably this should be fixed before merge.

Regards,
-marc 





> On 23. Jan 2020, at 01:35, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> Hello.
> Please review the fix for compiler warnings in the demo/jfc in JDK 15.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8237746
> Fix: http://cr.openjdk.java.net/~serb/8237746/webrev.00
> 
> This fix contributed by the Marc Hoffmann:
> https://mail.openjdk.java.net/pipermail/swing-dev/2019-October/009846.html
> 
> Fixed warnings: raw types, deprecated APIs, deprecated Applet APIs.
> 
> -- 
> Best regards, Sergey.



More information about the swing-dev mailing list