<Swing Dev> RFR: 8041705 Bugs in DefaultTreeCellRenderer.updateUI()

[Pankaj Bansal]

Hello Tejpal,

Few comments about the test

1. Remove all wild imports

2. Why do you need to create "lf" variable? Just call setLookAndFeel 
with L&F name

3. Dispose the frame in EDT thread in finally block

4. I am not able to understand the use of Robot in your program.

Regards,

Pankaj


On 02/07/20 10:51 AM, Tejpal Rebari wrote:
> Hi Prasanta,
>
> Thanks for the review.
>
>> On 29-Jun-2020, at 9:06 AM, Prasanta Sadhukhan 
>> <prasanta.sadhukhan at oracle.com 
>> <mailto:prasanta.sadhukhan at oracle.com>> wrote:
>>
>> Fix looks ok but I think the test should actually set 
>> "Tree.rendererMargins" value for NimbusL&F and check insets for other 
>> L&F is not same as nimbus when "Tree.rendererMargins" is reset to null.
>>
> I have modified the test to set “Tree.rendererMargins” property for 
> nimbus and check
>  insets is not same as other L&F after “Tree.rendererMargins” Is reset 
> to null
> .
> I have verified that the test passes with the fix and fails without 
> the fix.
> Mach5 link is in JBS.
>
> Update webrev : 
> http://cr.openjdk.java.net/~trebari/swing/8041705/webrev01/ 
> <http://cr.openjdk.java.net/%7Etrebari/swing/8041705/webrev01/>
>
> Regards
> Tejpal
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200702/6b3a1141/attachment.htm>