<Swing Dev> RFR: 8041705 Bugs in DefaultTreeCellRenderer.updateUI()

Pankaj Bansal pankaj.b.bansal at oracle.com
Wed Jul 8 07:00:44 UTC 2020


Looks good to me

-Pankaj


On 07/07/20 10:53 AM, Tejpal Rebari wrote:
>
>
>> On 02-Jul-2020, at 2:44 PM, Tejpal Rebari <tejpal.rebari at oracle.com 
>> <mailto:tejpal.rebari at oracle.com>> wrote:
>>
>> Hi Pankaj,
>>
>> Thanks for the review.
>>
>>> On 02-Jul-2020, at 2:05 PM, Pankaj Bansal 
>>> <pankaj.b.bansal at oracle.com <mailto:pankaj.b.bansal at oracle.com>> wrote:
>>>
>>> Hello Tejpal,
>>>
>>> Few comments about the test
>>>
>>> 1. Remove all wild imports
>>>
>>> 2. Why do you need to create "lf" variable? Just call setLookAndFeel 
>>> with L&F name
>>>
>>> 3. Dispose the frame in EDT thread in finally block
>>>
>> Will update the test.
>
> Updated webrev : 
> http://cr.openjdk.java.net/~trebari/swing/8041705/webrev02/ 
> <http://cr.openjdk.java.net/%7Etrebari/swing/8041705/webrev02/>
>
> Regards
> Tejpal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200708/5ccd884e/attachment.htm>


More information about the swing-dev mailing list