<Swing Dev> RFR JDK-8232927:ToolTipManager is unable to force heavy weight popups

[Philip Race]

Sure looks like it.

Comments
  - the side effect of

  164         lightWeightPopupEnabled = !aFlag;

needs to be called out.

Also I am not sure what to make of the fact that one may then call

setHeavyWeightPopupEnabled(true);
setLightWeightPopupEnabled(true);


and break what was set by the first call.

What is supposed to happen then ?

I think you need to look at the whole picture here.

Also (minor nit after the big issue) you always should have @since 
<release> on new methods etc.

-phil.

On 7/22/20, 1:52 PM, Sergey Bylokhov wrote:
> Hi, Prasanta.
>
> Isn't the current bug a duplicate of
> https://bugs.openjdk.java.net/browse/JDK-8147521
> ?
>
> On 22.07.2020 00:44, Prasanta Sadhukhan wrote:
>> Hi All,
>>
>> Please review a fix for an issue whereby Java developer is not able 
>> to to force the tooltips to be displayed in a heavyweight popup.
>>
>> In ToolTipManager#showTipWindow() , even if we do 
>> "ToolTipManager.setLightWeightPopupEnabled(false)" we can only force 
>> a medium weight popup as can be seen here
>>
>> [http://hg.openjdk.java.net/jdk/client/file/f054a3a03050/src/java.desktop/share/classes/javax/swing/ToolTipManager.java#l338] 
>>
>>
>> In addition, there is also a field "heavyWeightPopupEnabled" inside 
>> the ToolTipManager which is not used..
>> There should be at least one way to force a heavy weight popup in the 
>> ToolTipManager.
>>
>> Proposed fix is to give an option to developer to force tooltip to be 
>> displayed in HW. CSR will be raised after technical review
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8232927
>>
>> webrev: http://cr.openjdk.java.net/~psadhukhan/8232927/webrev.0
>>
>> Regards
>> Prasanta
>>
>>
>
>